Skip to content
Snippets Groups Projects
  1. Jul 11, 2017
    • Roman Tsisyk's avatar
      Debian: add a workaround for buggy cdbs/0.4.150 · d4ac637f
      Roman Tsisyk authored
      dh_systemd_enable called BEFORE dh_install, which installs file(s)
      (tarantool.service), required for dh_systemd_enable. A quick workaround
      is to symlink tarantool.service into debian/ directory.
      
      Issue appeared only in cdbs comming with Debian 9.
      
      See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=864489
      
      Thanks for Alexander Sbitnev
      
      + Fix inconsistent debian/changelog and debian/control.
      d4ac637f
    • Vladimir Davydov's avatar
      vinyl: move vy_tx to its own source file · 7c42ca7a
      Vladimir Davydov authored
      Needed for #1906
      7c42ca7a
    • Vladimir Davydov's avatar
      vinyl: use trigger to close tx cursors · f20c7756
      Vladimir Davydov authored
      So that vy_tx does not depend on vy_cursor.
      
      Needed for #1906
      f20c7756
    • Vladimir Davydov's avatar
      vinyl: move vy_index to its own source file · d80fa779
      Vladimir Davydov authored
      Needed for #1906
      d80fa779
    • Vladimir Davydov's avatar
      vinyl: refactor index creation and deletion functions · d54835e2
      Vladimir Davydov authored
      We can't move vy_index_new() to a separate file right now, because it
      depends on vy_env and we can't just replace vy_env with vy_index_env and
      vy_cache_env there, because the function is called from outside vinyl.c.
      To deal with that, let's introduce wrappers around vy_index_new() and
      vy_index_delete(), vy_new_index() and vy_delete_index(), which are vinyl
      C API functions that simply call the internal functions with appropriate
      arguments. Also, remove vy_index_ref() and vy_index_unref() from the C
      API, as they are not really necessary.
      
      Needed for #1906
      d54835e2
    • Vladimir Davydov's avatar
      vinyl: remove vy_env reference from vy_index and tx_manager · 00adaf04
      Vladimir Davydov authored
       - Introduce vy_index_env hosting fields common to all indexes and
         replace vy_index->env with it.
       - Use a callback to trigger async upsert squashing.
       - Pass vy_env or vy_schedule in function arguments instead of using
         index->env.
      
      Needed for #1906
      00adaf04
    • Vladimir Davydov's avatar
      vinyl: pass vy_env to all Vinyl C API methods · 18a7f4a4
      Vladimir Davydov authored
      So that we can remove vy_env reference from internal Vinyl structures.
      
      Needed for #1906
      18a7f4a4
    • Vladislav Shpilevoy's avatar
      schema: space_def object size is variable · 29d1caa8
      Vladislav Shpilevoy authored
      Needed for #944
      
      alter: remove snprintf from func_def_new_from_tuple
      29d1caa8
    • Alexandr Lyapunov's avatar
      vinyl: fix broken rollback to savepoint · b9bdcd31
      Alexandr Lyapunov authored
      Now vinyl's rollback to TX savepoint doesn't work in case when one
      TX has several statements modifying the same key.
      
      A simple example is presented in gh ticket 2589.
      
      Fix it.
      
      Add a big test that compares vinyl with memtx in case of many
      failing (catched with pcall) statements done in a transaction.
      
      Fixes #2589
      b9bdcd31
    • Alexandr Lyapunov's avatar
      vinyl: fix TX log order · 9648cfd5
      Alexandr Lyapunov authored
      Now if a TX (in vinyl) changes the same key again, it uses
      previously created struct txv and updates the tuple in it.
      Therefore the change is not added to the transaction log; instead,
      the old entry in the log is updated.
      
      At the same time, the order of TX log is important, especially when
      there are several indexes in a vinyl space: tx_prepare traverses
      TX log, determines the beginning of a tarantool statement (that
      could consist of several vinyl statements) and behave with several
      conjuncted txvs as a whole.
      
      Fix it by leaving old txv and always creating new txv.
      
      Fixes #2577
      9648cfd5
    • Alexandr Lyapunov's avatar
      vinyl: fix a pair of bugs · b525e8fc
      Alexandr Lyapunov authored
      - don't reference the upserted tuple twice in vy_tx_set(..)
      - handle txv allocaion error properly in vy_tx_et(..)
      
      The return value of txv_new was not checked.
      b525e8fc
  2. Jul 10, 2017
    • Vladimir Davydov's avatar
      vinyl: get rid of vy_run_iterator->coio_read · eeb9a81e
      Vladimir Davydov authored
      Instead introduce vy_run_env_enable_coio(), which starts reader threads,
      and make vy_run_iterator automatically switch to coio if reader threads
      are running. With this patch, vy_read_iterator doesn't need a pointer to
      vy_env to add a run as a source, only vy_run_env.
      
      While we are at it, cleanup vy_conf a bit.
      
      Needed for #1906
      eeb9a81e
    • Vladimir Davydov's avatar
      vinyl: fix use-after-free of last_stmt in vy_run_write_page · 63f59df4
      Vladimir Davydov authored
      vy_run_write_page() doesn't take a reference to last_stmt, because it
      assumes that the write iterator guarantees it won't be deleted until
      'next' is called again. The iterator does pin a statement if it is read
      from a run file - see vy_write_iterator_set_tuple() - however there's a
      case when the last returned statement can go away under us. This will
      happen if the iterator is used for major compaction and the last source
      statement is a DELETE. In this case the iterator will unreference the
      last statement it returned to the caller, take a reference to the DELETE
      instead, but won't return the DELETE - see vy_write_iterator_next(). As
      a result, the caller, i.e. vy_run_write_page(), will hit use-after-free
      on an attempt to read last_stmt.
      
      To fix this bug, let's make vy_run_write_page() take a reference to
      last_stmt as it used to before the write iterator was reworked. A test
      case will be added later, after all iterator-related issues have been
      fixed.
      
      Closes #2578
      63f59df4
    • Georgy Kirichenko's avatar
      Add iconv support · aff6235c
      Georgy Kirichenko authored
      Iconv is a library to convert a sequence of characters in one
      character encoding to a sequence of characters in another character
      encoding. Example below converts utf-16 big endian string into utf-8
      string:
      
          convertor = require('iconv').new('UTF-16BE', 'UTF-8')
          converted_string = convertor(source_string)
      
      Closes #2587
      aff6235c
    • Vladimir Davydov's avatar
      vinyl: add missing mem_list_version increment · 3a73e5dc
      Vladimir Davydov authored
      vy_task_dump_new() deletes empty in-memory trees right away, but
      doesn't increment vy_index->mem_list_version, which may result in
      a read iterator crash accessing a deleted vy_mem.
      3a73e5dc
    • alyapunov's avatar
      Use open MP sort optimisation only for huge arrays · 2e864b5a
      alyapunov authored
      Now open MP sort is used for any size of an array.
      For small arrays it's an overkill and even can cause overhead
      due to thread pool creation.
      
      Invoke open MP sort only for big arrays and use old good
      single-thread qsort for small arrays.
      
      Fix #2431
      2e864b5a
    • Roman Tsisyk's avatar
      Fix logging of box.cfg.replication option · 6015e0df
      Roman Tsisyk authored
      Print original uri as is if it doesn't contain sensitive
      information.
      
      Closes #2292
      6015e0df
  3. Jul 09, 2017
  4. Jul 08, 2017
    • Vladimir Davydov's avatar
      vinyl: move read_set from vy_index to tx_manager · 56871b94
      Vladimir Davydov authored
      Needed to remove dependency of vy_index on struct txv.
      
      Needed for #1906
      56871b94
    • Konstantin Osipov's avatar
    • Georgy Kirichenko's avatar
      Altering a space takes effect immediately. · 8631ffb2
      Georgy Kirichenko authored
      Before this patch, the new space, created by alter specification,
      would be put into space cache only after successful WAL write.
      
      This behaviour is not linearizable: on a replica, the WAL is
      played sequentially, and the order of events could differ from the
      master.
      
      Besides, it could crash, as demonstrated in gh-2074 test case.
      
      Since we use a cascading rollback for all transactions on WAL
      write error, it's OK to put a space into space cache
      before WAL write, so that the new transactions apply to the new
      space.
      
      This patch does exactly that.
      
      All subsequent requests are executed against the new space.
      
      This patch also removes on_replace trigger in the old space, since
      all checks against the new tuple format are performed using the new
      space.
      
      Fixes #2074.
      8631ffb2
  5. Jul 07, 2017
  6. Jul 06, 2017
    • Konstantin Osipov's avatar
      alter: MoveIndex review fixes · 7b1028a4
      Konstantin Osipov authored
      * update comments
      * add a test case for altering a primary key on the fly
      * rename AddIndex to CreateIndex
      * factor out common code into a function
      7b1028a4
    • Georgy Kirichenko's avatar
      alter: introduce MoveIndex and RebuildIndex operations · 8c854d7f
      Georgy Kirichenko authored
      MoveIndex operation is used to move an existing index from the old space
      to the new one. Semantically it's a no-op.
      
      RebuildIndex is introduced for case when essential index properties are
      changed, so it is necessary to drop the old index and create a new one in
      its place in the new space.
      
      AlterSpaceOp::prepare() is removed: all checks are moved to
      on_replace trigger in _index system space from it.
      All checks are done before any alter operation is created.
      
      Necessary for gh-2074 and gh-1796.
      8c854d7f
    • alyapunov's avatar
      alter: move modify vs rebuild index check · 4c87d443
      alyapunov authored
      Move the check which decides on an alter strategy whenever
      a row in _index space is changed, from AlterSpaceOp::preapre()
      to on_replace trigger on _index space.
      
      The check chooses between two options: a heavy-weight index rebuild,
      invoked when index definition, such as key parts, is changed, vs.
      lightweight modify, invoked when index name or minor options are
      modified..
      
      Before this patch, index alteration creates a pair of operations
      (DropIndex + AddIndex) in all cases, but later
      replaces two operations with one at AlterSpaceOp::prepare() phase.
      
      This is bad by several reasons:
      
      - it's done while traversing of a linked list of operations,
        and it changes the list being traversed.
      
      - an order in the list of operations is required for this
      to work: drop must precede add.
      
      - needless allocation and deallocation of operations makes the logic
        unnecessarily complex.
      
      Necessary for gh-1796.
      4c87d443
    • Konstantin Osipov's avatar
      space: create the primary key index first. · 25a99f42
      Konstantin Osipov authored
      Always first create the primary key index in a space. Put
      the primary key key def first in the array of key_defs, passed
      into tuple_format_new(). This is necessary for gh-1796.
      25a99f42
    • Konstantin Osipov's avatar
      space add an assert on state of space object · 5bca3f7c
      Konstantin Osipov authored
      Assert that we can't create a space with secondary key but no primary.
      5bca3f7c
    • alyapunov's avatar
      Move drop primary index check to the stage before new space creation · f6d06b9f
      alyapunov authored
      Now drop primary index checks are made in alter triggers after
      new space creation. Such an implementation leads to temporary
      creation of a space with invalid index set. Fix it and check
      the index set before space_new call.
      f6d06b9f
    • Georgy Kirichenko's avatar
      Add swap_index_def function · 8ec3e3ed
      Georgy Kirichenko authored
      Non destructive swap_index_def function sould be used because memtx_tree
      stores a pointer to an index_def used while tree creation. Fixed #2570
      8ec3e3ed
  7. Jul 05, 2017
  8. Jul 04, 2017
    • Vladimir Davydov's avatar
      vinyl: fix snapshot consistency · 4586f2d6
      Vladimir Davydov authored
      Commit dbfd515f ("vinyl: fix crash if snapshot is called while dump
      is in progress") introduced a bug that can result in statements inserted
      after WAL checkpoint being included in a snapshot. This happens, because
      vy_begin_checkpoint() doesn't force rotation of in-memory trees anymore:
      it bumps checkpoint_generation, but doesn't touch scheduler->generation,
      which is used to trigger in-memory tree rotation.
      
      To fix this issue, this patch zaps scheduler->checkpoint_generation and
      makes vy_begin_checkpoint() bump scheduler->generation directly as it
      used to. To guarantee dump consistency (the issued fixed by commit
      dbfd515f), scheduler->dump_generation is introduced - it defines the
      generation of in-memory data that are currently being dumped. The
      scheduler won't start dumping newer trees until all trees whose
      generation equals dump_generation have been dumped. The counter is only
      bumped by the scheduler itself when all old in-memory trees have been
      dumped. Together, this guarantees that each dump contains data of the
      same generation, i.e. is consistent.
      
      While we are at it, let's also remove vy_scheduler->dump_fifo, the list
      of all in-memory trees sorted in the chronological order. The scheduler
      uses it to keep track of the oldest in-memory tree, which is needed to
      invoke lsregion_gc(). However, since we do not remove indexes from the
      dump_heap, as we used to not so long ago, we can use the heap for this.
      The only problem is indexes that are currently being dumped are moved
      off the top of the heap, but we can detect this case by maintaining a
      counter of dump tasks in progress: if dump_task_count is > 0 when a dump
      task is completed, we must not call lsregion_gc() irrespective of the
      generation of the index at the top of the heap. A good thing about
      ridding of vy_scheduler->dump_fifo is that it is a step forward towards
      making vy_index independent of vy_scheduler so that it can be moved to a
      separate source file.
      
      Closes #2541
      Needed for #1906
      4586f2d6
    • Vladimir Davydov's avatar
      vinyl: zap vy_index->generation · 199836db
      Vladimir Davydov authored
      vy_index->generation equals to the generation of the oldest in-memory
      tree, which can be looked up efficiently as vy_index->sealed list is
      sorted by generation so let's zap it and add vy_index_generation()
      function instead.
      199836db
    • Vladimir Davydov's avatar
      vinyl: move vy_range to its own source file · 448b643e
      Vladimir Davydov authored
      Needed for #1906
      448b643e
Loading