Skip to content
Snippets Groups Projects
  1. Sep 28, 2021
    • Vladimir Davydov's avatar
      Do not check return value of mh(new) · 841fdb35
      Vladimir Davydov authored
      It never returns NULL anymore, because it uses xmalloc for memory
      allocations.
      841fdb35
    • Vladimir Davydov's avatar
      mhash: use xmalloc · eb7592e0
      Vladimir Davydov authored
      An mhash is used for allocating system objects. Failing to grow it is
      likely to render the Tarantool instance unusuable so better fail early.
      
      Checks of mh(new) and mh(put) return value will be removed in follow-up
      patches.
      eb7592e0
    • Vladimir Davydov's avatar
      Move xmalloc to trivia/util.h · f3b5ad97
      Vladimir Davydov authored
      We want to use the xmalloc helper throughout the code, not only in
      the core lib. Move its definition to trivia/util.h and use fprintf+exit
      instead of say/panic in order not to create circular dependencies.
      f3b5ad97
  2. Sep 27, 2021
    • Vladimir Davydov's avatar
      net.box: move send/recv buffers to C · b424f44d
      Vladimir Davydov authored
      No need to pass them around when we can embed them in netbox_transport.
      This is a step towards rewriting the netbox state machine in C.
      
      Part of #6291
      b424f44d
    • Vladimir Davydov's avatar
      net.box: alert worker fiber unconditionally on request · 4bad376f
      Vladimir Davydov authored
      There's no need to optimize out fiber.wakeup:
       - we already have C function calls on the code path;
       - fiber.wakeup is pretty cheap to be called unconditionally.
      
      This is a preparation for moving send/recv buffers to C.
      4bad376f
    • Vladimir Davydov's avatar
      net.box: recycle send/recv buffers in one place · 38d99958
      Vladimir Davydov authored
      Let's recycle buffers in the same place where we reset the transport:
      when switching the state to 'closed', 'error', or 'error_reconnect'.
      
      This is a preparation for moving send/recv buffers to C.
      38d99958
    • Vladimir Davydov's avatar
      net.box: rename registry/requests to transport · 9ce5fa4a
      Vladimir Davydov authored
      In future we will store watchers in this struct. Besides, we can already
      move send/recv buffers there. So 'registry' is not an appropriate name.
      Let's rename it to 'transport' - the name which is already used in
      net.box for a net.box connection implementation object.
      9ce5fa4a
    • Vladimir Davydov's avatar
      net.box: rename connection variable to sock · 9ddde28a
      Vladimir Davydov authored
      It stores a socket, not a net.box connection. Let's rename it to sock to
      avoid confusion.
      9ddde28a
    • Leonid Vasiliev's avatar
      export: wrap exported msgpack symbols · 592db3b0
      Leonid Vasiliev authored
      Exporting symbols of a third party library is not a best practice,
      as we know from [1]. Let's wrap the msgpack symbols that need to
      be exported with the "tnt_" prefix.
      
      While working on the patch, it was decided to export the msgpack
      symbols that are used in "msgpuckffi.lua".
      In test shared libraries where the symbols "mp_***_{decimal,uuid}"
      are used, they are replaced to exported "tnt_mp_***_{decimal,uuid}",
      because in the case of linking with "libcore.a" the "libcore.a"
      needs to be rebuild with the "-fPIC" flag, that seems as overkill
      for tests.
      
      1. https://github.com/tarantool/memcached/issues/59
      
      Closes #5932
      592db3b0
  3. Sep 25, 2021
    • Alexander Turenko's avatar
      test: update test-run (-j -1 lies in exit code) · 9f208f0d
      Alexander Turenko authored
      Before this change `./test-run.py -j -1` always give zero exit code even
      when there were failed tests. It is the regression from
      2.6.0-104-g43482eedc.
      
      The `-j -1` is the test-run mode, when it does not execute any
      parallelization code: don't spawn worker processes and proceed with
      tests one-by-one from a single process. It was kept just in case, when
      the parallelization was implemented. AFAIS, it is barely used.
      
      Usual `./test-run.py` or `./test-run.py -j N` invocations are not
      affected. Tarantool's CI is not affected.
      
      See https://github.com/tarantool/test-run/pull/313 for details.
      Unverified
      9f208f0d
  4. Sep 23, 2021
    • Andrey Saranchin's avatar
      memtx: disable building index in background if primary index is hash · da20c985
      Andrey Saranchin authored
      If we insert a tuple in space with an index that is being built in background,
      new tuple will or will not be inserted into new index depending on the result of
      lexicographical comparison with tuple which was inserted into new index last.
      The problem is hash index is unordered, so background build will not work properly
      if primary key is HASH index.
      
      To avoid this, disable building index in background if primary index is hash.
      
      Closes #5977
      da20c985
  5. Sep 22, 2021
    • Vladimir Davydov's avatar
      test: disable vinyl/gh-6448-deferred-delete-in-dropped-space for release builds · e509054c
      Vladimir Davydov authored
      The test uses error injection.
      
      Follow-up 0428bbce ("vinyl: fix use of
      dropped space in deferred DELETE handler").
      e509054c
    • Vladimir Davydov's avatar
      vinyl: fix use of dropped space in deferred DELETE handler · 0428bbce
      Vladimir Davydov authored
      For deferred DELETE statements to be recovered after restart, we write
      them to a special 'blackhole' system space, _vinyl_deferred_delete,
      which doesn't store any data, but is logged in the WAL, as a normal
      space. In the on_replace trigger installed for this space, we insert
      deferred DELETE statements into the memory (L0) level of the LSM tree
      corresponding to the space for which the statement was generated. We
      also wait for L0 quota in the trigger. The problem is a space can be
      dropped while we are waiting for quota, in which case the trigger
      function will crash once it resumes execution.
      
      To fix this, let's wait for quota before we write the information about
      the deferred DELETE statement to the _vinyl_deferred_delete space and
      check if the LSM tree was dropped after yield. This way, everything will
      work as expected even if a new space is created with the same id,
      because we don't yield after checking quota.
      
      Closes #6448
      0428bbce
    • Vladimir Davydov's avatar
      vinyl: add regulator.blocked_writers stat · 165d24f5
      Vladimir Davydov authored
      Will come in handy for testing #6448.
      
      @TarantoolBot document
      Title: Document box.stat.vinyl().regulator.blocked_writers
      
      The new stat counter shows the number of fibers that are blocked waiting
      for Vinyl level0 memory quota.
      165d24f5
  6. Sep 17, 2021
    • Vladimir Davydov's avatar
      Drop serializer_opts · 125c13c8
      Vladimir Davydov authored
      The struct is empty.
      125c13c8
    • Vladimir Davydov's avatar
      lua/msgpack: drop serializer_opts::error_marshaling_enabled · ad3ac53c
      Vladimir Davydov authored
      Use a special luaL_serializer with encode_error_as_ext disabled.
      Default options are propagated to it via an update trigger.
      ad3ac53c
    • Vladimir Davydov's avatar
      session: store iproto_feautures instead of serializer_opts in meta · 2f02e8b6
      Vladimir Davydov authored
      This is a preparation for merging serializer_opts into luaL_serializer.
      2f02e8b6
    • Vladimir Davydov's avatar
      session: drop error_marshaling_enabled setting · 0cdf5f9b
      Vladimir Davydov authored
      It's not needed now, because error marshaling is enabled automatically
      if the connector supports it (IPROTO_FEATURE_ERROR_EXTENSION is set in
      IPROTO_ID features).
      
      Closes #6428
      
      @TarantoolBot document
      Title: Drop error_marshaling_enabled session setting
      
      box.session.setting.error_marshaling_enabled was used to enable encoding
      errors returned by CALL/EVAL in the extended format (as the MP_ERROR
      MsgPack extension). Now, the feature is enabled automatically if the
      connector supports it (sets IPROTO_FEATURE_ERROR_EXTENSION in IPROTO_ID
      features).
      0cdf5f9b
    • Vladimir Davydov's avatar
      iproto: add feature for enabling error extension · 342f601f
      Vladimir Davydov authored
      The new IPROTO protocol feature IPROTO_FEATURE_ERROR_EXTENSION enables
      encoding errors returned by CALL/EVAL commands as the MP_ERROR MsgPack
      extension. Note, the MP_ERROR extension can still be disabled globally
      by setting msgpack.cfg.encode_error_as_ext to false. If an IPROTO client
      doesn't set the feature bit, errors will be encoded as generic cdata
      objects (converted to strings by default).
      
      Needed for #6428
      
      @TarantoolBot document
      Title: Document IPROTO_FEATURE_ERROR_EXTENSION
      
      A new feature bit for the IPROTO_ID command was added:
      
      ```
      IPROTO_FEATURE_ERROR_EXTENSION = 2
      ```
      
      The protocol version was incremented - now it equals 2.
      
      If a network client sets this bit, errors returned by CALL/EVAL will be
      encoded as the MP_ERROR MsgPack extension (unless disabled globally by
      msgpack.cfg.encode_error_as_ext). If the bit is unset, errors will be
      encoded according to the serialization rules used for generic cdata
      objects (converted to strings by default).
      
      The built-in net.box connector sets this feature bit.
      
      The server sets this feature bit if it supports the MP_ERROR MsgPack
      extension so a net.box client can explicitly request the feature upon
      connecting to a server:
      
      ```lua
      net.box.connect(uri, {required_protocol_features = {'error_extension'}})
      ```
      342f601f
    • Vladimir Davydov's avatar
      lua/msgpack: enable encoding errors as msgpack extension · fa1652df
      Vladimir Davydov authored
      This patch adds a new msgpack.cfg: encode_error_as_ext. Setting it makes
      msgpack and msgpackffi modules encode errors as the MP_ERROR msgpack
      extension. If the flag is unset, msgpack.encode behavior depends on
      encode_load_metatables, encode_use_tostring, and encode_invalid_as_nil
      options, see luaL_convertfield(), while msgpackffi.encode() will always
      encode errors as strings. The latter needs to be fixed, but it's out of
      the scope of this work and tracked separately, see #4499.
      
      The new option is enabled by default.
      
      Interaction with box.session.settings.error_marshaling_enabled: errors
      are encoded as the MP_ERROR msgpack extension when returned via IPROTO
      iff both error_marshaling_enabled and encode_error_as_ext are set.
      
      Closes #6433
      
      @TarantoolBot document
      Title: Document msgpack.cfg.encode_error_as_ext
      
      The new option determines how error objects (see box.error.new) are
      encoded in the msgpack format:
       - If it's set, errors are encoded as the MP_ERROR msgpack extension.
         This is the default behavior.
       - If it's unset, the encoded format depends on other msgpack
         configuration options (encode_load_metatables, encode_use_tostring,
         encode_invalid_as_nil). With the otherwise default configuration,
         they are encoded as strings (see error.message).
      
      Functions affected by the default configuration (msgpack.cfg):
       - msgpack and msgpackffi modules
       - Storing errors in tuples and spaces (box.tuple.new)
       - Returning errors from IPROTO CALL/EVAL
      fa1652df
    • Vladimir Davydov's avatar
      mp_error: factor out common error encoding code · c31db631
      Vladimir Davydov authored
      error_to_mpstream and error_to_mpstream_noext have a lot in common.
      Factor it out into helper functions.
      c31db631
    • Vladimir Davydov's avatar
      mp_error: rename mp_sizeof_error to mp_sizeof_error_one · 427679aa
      Vladimir Davydov authored
      The function doesn't iterate over the stack of errors so it should have
      suffix '_one', like mp_encode_error_one.
      427679aa
    • Vladimir Davydov's avatar
      mp_error: change signature of mp_encode_error_one · 7e98d22a
      Vladimir Davydov authored
      It's customary for mp_encode_* functions to take a pointer to the buffer
      and return a pointer following the end of encoded data.
      mp_encode_error_one takes (char **) and advances it. Fix it to be
      consistent with other mp_encode_* functions.
      7e98d22a
    • Vladimir Davydov's avatar
      lua/call: enable extended errors for CALL_16 · f5403716
      Vladimir Davydov authored
      There's no reason not to enable extended errors for CALL_16.
      Enable the feature and add a test.
      
      Needed for #6433
      f5403716
    • Vladimir Davydov's avatar
      lua/msgpack: teach msgpackffi decode MP_ERROR · ab01c2fc
      Vladimir Davydov authored
      There's no way to encode an error yet so the test just hard-codes
      msgpack data. It will be fixed in the future, once we allow to encode
      errors with msgpack/msgpackffi.
      
      Needed for #6433
      ab01c2fc
    • Vladimir Davydov's avatar
      lua/msgpack: drop serializer_opts arg of luaL_tofield · b1ea2a6b
      Vladimir Davydov authored
      It's not used anymore.
      b1ea2a6b
    • Vladimir Davydov's avatar
      lua/msgpack: fix crash while encoding error extension · 6dde8898
      Vladimir Davydov authored
      Whether errors are encoded as a msgpack extension or not is determined
      by the serializer_opts::error_marshaling_enabled flag. Although an
      instance of serizlier_opts is passed to luamp_encode(), it doesn't
      propagate it to luamp_encode_extension_box(). The latter encodes an
      error as a msgpack extension if the error_marshaling_enabled flag is set
      in serializer_opts of the current session. This leads to a bug when
      luamp_encode() is called with error_marshaling_enabled unset while the
      current session has the flag set:
      
       1. luaL_tofield() sets field->type to MP_EXT and field->ext_type to
          MP_UNKNOWN_EXTENSION, because the error_marshaling_enabled flag is
          unset:
      
          https://github.com/tarantool/tarantool/blob/b0431cf8f47e9d081f6a402bc18edb1d6ad49847/src/lua/serializer.c#L548
      
       2. Basing on the ext_type, luamp_encode_r() skips the MP_ERROR
          swtich-case branch for the default branch and calls the
          luamp_encode_extension callback:
      
          https://github.com/tarantool/tarantool/blob/b0431cf8f47e9d081f6a402bc18edb1d6ad49847/src/lua/msgpack.c#L203
      
       3. The callback implementation (luamp_encode_extension_box()) encodes
          the error, because the error_marshaling_enabled flag is set in the
          current session settings, and returns MP_EXT:
      
          https://github.com/tarantool/tarantool/blob/b0431cf8f47e9d081f6a402bc18edb1d6ad49847/src/box/lua/init.c#L420
      
       4. luamp_encode_r() assumes that the callback didn't encode the
          extension, because it returned MP_EXT, and encodes it again as
          a string:
      
          https://github.com/tarantool/tarantool/blob/b0431cf8f47e9d081f6a402bc18edb1d6ad49847/src/lua/msgpack.c#L209
      
      This results in a broken msgpack content.
      
      To fix this bug, let's do the following:
       - luaL_tofield() now sets ext_type to MP_ERROR unconditionally,
         irrespective of serializer_opts::error_marshaling_enabled.
       - luamp_encode_r() invokes the luamp_encode_extension callback for
         a MP_ERROR field only if error_marshaling_enabled is set. If the flag
         is unset, it proceeds with converting the field to string.
       - luamp_encode_extension_box() doesn't check serializer_opts anymore.
         It doesn't need to, because it's called iff error_marshaling_enabled
         is set.
       - YAML and JSON encoders are patched to handle the MP_ERROR field type
         by appending error::errmsg to the output (they use luaL_tofield()
         internally to determine the field type so they have to handle
         MP_ERROR).
      
      This basically disables error encoding as msgpack extension
      everywhere except returning an error from a Lua CALL/EVAL, in
      particular:
       - when creating a tuple with box.tuple.new(),
       - when inserting an error into a space,
       - when encoding an error with the msgpack module.
      
      This is okay, because the functionality has always been broken anyway.
      We will introduce a separate msgpack encoder option to enable encoding
      errors as MP_ERROR msgpack extension.
      
      Looking at the code links above, one is likely to wonder why error
      encoding was implemented via the encode extension callback in the first
      place. The lua/msgpack module knows about the MP_ERROR extension and
      even partially handles it so it'd be only natural to call the error
      encoder function directly, as we do with decimals and uuids.
      Unfortunately, we can't do it, because the error encoder is (surprise!)
      a part of the box library. I filed a ticket to move it to the core lib,
      see #6432.
      
      Closes #6431
      6dde8898
    • Vladimir Davydov's avatar
      net.box: add IPROTO_ID support · 47a85f9e
      Vladimir Davydov authored
      Now net.box sends IPROTO_ID request on (re)connect to query features
      supported by the server and report its own features. The version and
      features reported by the server are checked against the new connection
      options:
      
       - required_protocol_version - min version (unsigned)
       - required_protocol_features - required features (array of strings)
      
      If the server version is older than specified or the server lacks
      certain features, the connection will fail.
      
      Features supported by the server are stored in the peer_protocol_version
      and peer_protocol_features fields of a connection.
      
      Closes #6253
      
      @TarantoolBot document
      Title: Document required_protocol_version/features net.box options
      
      Two new options can now be passed to net.box.connect():
      
       - required_protocol_version: min IPROTO protocol version that must be
         supported by the server. Type: unsigned integer.
       - required_protocol_features: array of IPROTO protocol features that
         must be supported by the server. Type: array of strings.
      
      If the server version is less than the specified or the server lacks
      certain features, the connection will fail with the corresponding error.
      
      Querying server features is implemented via the IPROTO_ID command.
      Currently, there are two features defined: streams and transactions.
      
      Irrespective of the options used, the actual version and features are
      reported via peer_protocol_version and peer_protocol_features fields of
      the connection. Example:
      
      ```
      tarantool> require('net.box').connect(3301, {
               > required_protocol_version = 1,
               > required_protocol_features = {'transactions'},
               > })
      ---
      - peer_protocol_version: 1
        peer_uuid: 7a8cfdbd-6bbc-4d10-99e5-cbbd06a2382f
        opts:
          required_protocol_version: 1
          required_protocol_features:
          - transactions
        peer_protocol_features:
          transactions: true
          streams: true
        schema_version: 80
        protocol: Binary
        state: active
        peer_version_id: 133632
        port: '3301'
      ...
      ```
      47a85f9e
    • Vladimir Davydov's avatar
      net.box: reuse code of remote_serialize in stream_serialize · 80db9be6
      Vladimir Davydov authored
      No functional changes, just get rid of some code duplication.
      80db9be6
    • Vladimir Davydov's avatar
      errinj: sort ERRINJ_LIST · 831a3f99
      Vladimir Davydov authored
      831a3f99
    • Vladimir Davydov's avatar
      iproto: introduce IPROTO_ID request · 0be1faf1
      Vladimir Davydov authored
      The new request can be used by a client to let the server know about
      supported IPROTO protocol features. The request body contains two
      fields: IPROTO protocol version and supported IPROTO protocol features.
      In reply to a IPROTO_ID request, the server sends its own protocol
      version and supported features.
      
      Currently, the actual protocol version is 1 and there are two features
      defined which are always set - streams and transactions.
      
      Part of #6253
      
      @TarantoolBot document
      Title: Document IPROTO_ID request
      
      The new request code is 73. It takes a map in the body with the
      following keys:
       - IPROTO_VERSION (0x54) - protocol version (unsigned).
       - IPROTO_FEATURES (0x55) - array of protocol feature ids (unsigned).
      
      A client (connector) can send this request to let the server know about
      the protocol version and features it supports. The server may enable or
      disable certain functionality basing on the features supported by the
      client. In reply to the request, the server sends an IPROTO_OK response,
      in the body of which it reports its own protocol version and features
      (the format of the response body is the same as the request body).
      The request doesn't need authentication to pass.
      
      Currently, the actual protocol version is 1 and there are two features
      defined:
       - IPROTO_FEATURE_STREAMS - streams support (IPROTO_STREAM_ID header
         key), id = 0.
       - IPROTO_FEATURE_TRANSACTIONS - transactions support (IPROTO_BEGIN,
         IPROTO_COMMIT, IPROTO_ROLLBACK commands), id = 1.
      0be1faf1
    • Vladimir Davydov's avatar
      iproto: add missing fields to iproto_key_strs · a8bb346a
      Vladimir Davydov authored
       - Add names for IPROTO_REPLICA_ANON, IPROTO_ID_FILTER, IPROTO_ERROR,
         and IPROTO_TERM.
       - Use "error_24" for IPROTO_ERROR_24, "error" for IPROTO_ERROR.
      a8bb346a
    • Vladimir Davydov's avatar
      bit: turn bitmap_size into macro · 30cc7da7
      Vladimir Davydov authored
      So that it can be used in a struct definition.
      
      Also, upper-case the name to conform to our coding conventions.
      30cc7da7
  7. Sep 16, 2021
  8. Sep 14, 2021
  9. Sep 10, 2021
    • Oleg Babin's avatar
      fiber: keep reference to userdata if fiber created once · b0431cf8
      Oleg Babin authored
      This patch reworks approach to fiber management in Lua. Before
      this patch each action that should return fiber led to new
      userdata creation that was quite slow and made GC suffer. This
      patch introduces new field in struct fiber to store a reference to
      userdata that was created once for a fiber. It allows speedup
      operations as fiber.self() and fiber.id().
      Simple benchmark shows that access to fiber storage is faster in
      two times, fiber.find() - 2-3 times and fiber.new/create functions
      don't have any changes.
      b0431cf8
    • Oleg Babin's avatar
      fiber: correctly initialize storage_ref value · e3b24fe2
      Oleg Babin authored
      Before this patch we used an assumption in lua fiber code that
      all valid lua refs are positive numbers. However there are
      special constants defined in lua header for such purpose LUA_NOREF
      and LUA_REFNIL [1]. This patch introduces special value in fiber
      module that is equal to LUA_REFNIL to be sure that this value will
      be correct in future static assert is added.
      
      Also this patch introduces several usages of this value - let's
      make fiber code more clearer and start to initialize ref values
      with LUA_NOREF value. Also it will be needed for future changes.
      
        [1] https://pgl.yoyo.org/luai/i/luaL_ref
      e3b24fe2
    • Oleg Babin's avatar
      fiber: pass struct fiber into lbox_pushfiber instead of id · fa30d9db
      Oleg Babin authored
      For future changes we will need the fiber object, not only its id.
      fa30d9db
    • Oleg Babin's avatar
      fiber: rename ref to storage_ref · 4d3201f3
      Oleg Babin authored
      Ref is a lua reference to fiber storage. This patch just renames
      storage.lua.ref to storage.lua.storage_ref to underline that
      it's not a reference to fiber itself and needed only for fiber
      storage.
      4d3201f3
Loading