export: wrap exported msgpack symbols
Exporting symbols of a third party library is not a best practice, as we know from [1]. Let's wrap the msgpack symbols that need to be exported with the "tnt_" prefix. While working on the patch, it was decided to export the msgpack symbols that are used in "msgpuckffi.lua". In test shared libraries where the symbols "mp_***_{decimal,uuid}" are used, they are replaced to exported "tnt_mp_***_{decimal,uuid}", because in the case of linking with "libcore.a" the "libcore.a" needs to be rebuild with the "-fPIC" flag, that seems as overkill for tests. 1. https://github.com/tarantool/memcached/issues/59 Closes #5932
Showing
- extra/exports 11 additions, 33 deletionsextra/exports
- src/CMakeLists.txt 1 addition, 0 deletionssrc/CMakeLists.txt
- src/lua/msgpackffi.lua 25 additions, 25 deletionssrc/lua/msgpackffi.lua
- src/lua/tnt_msgpuck.c 99 additions, 0 deletionssrc/lua/tnt_msgpuck.c
- src/lua/tnt_msgpuck.h 68 additions, 0 deletionssrc/lua/tnt_msgpuck.h
- static-build/test/static-build/exports.test.lua 11 additions, 7 deletionsstatic-build/test/static-build/exports.test.lua
- test/app-tap/CMakeLists.txt 1 addition, 0 deletionstest/app-tap/CMakeLists.txt
- test/box/CMakeLists.txt 7 additions, 0 deletionstest/box/CMakeLists.txt
- test/sql-tap/CMakeLists.txt 4 additions, 0 deletionstest/sql-tap/CMakeLists.txt
- test/sql-tap/decimal.c 2 additions, 1 deletiontest/sql-tap/decimal.c
- test/sql-tap/gh-6024-funcs-return-bin.c 3 additions, 2 deletionstest/sql-tap/gh-6024-funcs-return-bin.c
- test/sql-tap/sql_uuid.c 2 additions, 1 deletiontest/sql-tap/sql_uuid.c
Loading
Please register or sign in to comment