Skip to content
Snippets Groups Projects
  1. Oct 25, 2022
    • Serge Petrenko's avatar
      security: make os.getenv safe · dd7d46af
      Serge Petrenko authored
      Closes #7797
      
      NO_DOC=security fix
      NO_TEST=security fix
      dd7d46af
    • Serge Petrenko's avatar
      security: check size boundaries for getenv() returns · b86395ff
      Serge Petrenko authored
      getenv() return values cannot be trusted, because an attacker might set
      them. For instance, we shouldn't expect, that getenv() returns a value
      of some sane size.
      
      Another problem is that getenv() returns a pointer to one of
      `char **environ` members, which might change upon next setenv().
      
      Introduce a wrapper, getenv_safe(), which returns the value only when
      it fits in a buffer of a specified size, and copies the value onto the
      buffer. Use this wrapper everywhere in our code.
      
      Below's a slightly decorated output of `grep -rwn getenv ./src --include
      *.c --include *.h --include *.cc --include *.cpp --include *.hpp
      --exclude *.lua.c` as of 2022-10-14.
      `-` marks invalid occurences (comments, for example),
      `*` marks the places that are already guarded before this patch,
      `X` mars the places guarded in this patch, and
      `^` marks places fixed in the next commit:
      
      NO_WRAP
      ```
      * ./src/lib/core/coio_file.c:509:	const char *tmpdir = getenv("TMPDIR");
      X ./src/lib/core/errinj.c:75: const char *env_value = getenv(inj->name);
      - ./src/proc_title.c:202: * that might try to hang onto a getenv() result.)
      - ./src/proc_title.c:241:	* is mandatory to flush internal libc caches on getenv/setenv
      X ./src/systemd.c:54: sd_unix_path = getenv("NOTIFY_SOCKET");
      * ./src/box/module_cache.c:300: const char *tmpdir = getenv("TMPDIR");
      X ./src/box/sql/os_unix.c:1441: azDirs[0] = getenv("SQL_TMPDIR");
      X ./src/box/sql/os_unix.c:1446: azDirs[1] = getenv("TMPDIR");
      * ./src/box/lua/console.c:394: const char *envvar = getenv("TT_CONSOLE_HIDE_SHOW_PROMPT");
      ^ ./src/box/lua/console.lua:771: local home_dir = os.getenv('HOME')
      ^ ./src/box/lua/load_cfg.lua:1007: local raw_value = os.getenv(env_var_name)
      X ./src/lua/init.c:575: const char *path = getenv(envname);
      X ./src/lua/init.c:592: const char *home = getenv("HOME");
      * ./src/find_path.c:77: snprintf(buf, sizeof(buf) - 1, "%s", getenv("_"));
      ```
      NO_WRAP
      
      Part-of #7797
      
      NO_DOC=security
      b86395ff
  2. Oct 24, 2022
    • Mergen Imeev's avatar
      sql: fix another cursor invalidation · 5a38c5c9
      Mergen Imeev authored
      This patch fixes the issue described in issue #5310 when the tuple
      format has more fields than the space format. This solution is more
      general than the solution in 89057a21.
      
      Follow-up #5310
      Closes #4666
      
      NO_DOC=bugfix
      5a38c5c9
  3. Oct 21, 2022
    • Georgiy Lebedev's avatar
      build: use relative paths in diagnostics and debugging information · 256da010
      Georgiy Lebedev authored
      Since our diagnostics use the `__FILE__` macro, they provide absolute
      paths, which is kind of redundant and inconsistent: replace them with
      relative ones.
      
      As for debugging information, replacing absolute paths with relative ones
      also requires an extra command to tell the debugger where to find the
      source files, which is not convenient for developers: provide a new
      `DEV_BUILD` option (turned off by default), which replaces absolute paths
      with relative ones in debugging information if turned off.
      
      Strip the prefix map flags from compiler flags exported to tarantool via
      `src/trvia/config.h`.
      
      Closes #7808
      
      NO_DOC=<verbosity>
      NO_TEST=<verbosity>
      256da010
  4. Oct 20, 2022
    • Andrey Saranchin's avatar
      box: unify errors about mismatch of password and login during auth · 5c62f01b
      Andrey Saranchin authored
      If we raise different errors in case of entering an invalid password and
      entering the login of a non-existent user during authorization, it will
      open the door for an unauthorized person to enumerate users.
      So let's unify raised errors in the cases described above.
      
      Closes #tarantool/security#16
      
      NO_DOC=security fix
      5c62f01b
  5. Oct 19, 2022
    • Vladimir Davydov's avatar
      index: make index_read_view_iterator fixed size · 1aae12ac
      Vladimir Davydov authored
      This is a straightforward patch that makes the read view iterator struct
      fixed-size so that it can be allocated on stack. This is a pre-requisite
      for the raw C API for read views: the function that creates an iterator
      should allocate no memory.
      
      Closes #7813
      
      NO_DOC=refactoring
      NO_TEST=refactoring
      NO_CHANGELOG=refactoring
      1aae12ac
    • Timur Safin's avatar
      debugger: retrieve @builtin/%s.lua sources · e608a737
      Timur Safin authored
      Extend Tarantool kernel internal API with the call
      `tarantool.debug.getsources()` to allow to retrieve sources
      of a Tarantool `builtin/*` modules to show them in the
      debugger shell.
      
      Created simple luatest script for checking consistency
      of a values returned from `require 'tarantool'.debug.getsources()`
      and an ctual script file content we expected to receive.
      
      NO_DOC=see future commit
      NO_CHANGELOG=see future commit
      e608a737
    • Timur Safin's avatar
      debugger: added luadebug.lua · 3d8086f0
      Timur Safin authored
      Use 3rd-party module https://github.com/slembcke/debugger.lua
      as a basis for our debugger CLI shell, rename it to
      luadebug.lua to avoid collision with vscode and JetBrains
      debugger helper scripts.
      
      NO_DOC=yet
      NO_CHANGELOG=yet
      NO_TEST=yet
      3d8086f0
    • Mergen Imeev's avatar
      box: fix format of _vfunc · 707da125
      Mergen Imeev authored
      The _vfunc system space is the sysview for the _func system space.
      However, the _vfunc format is different from the _func format. This
      patch makes the _vfunc format the same as the _func format.
      
      Closes #7822
      
      NO_DOC=bugfix
      707da125
  6. Oct 18, 2022
    • Georgiy Lebedev's avatar
      uri: optimize allocation of parameters and their values dynamic arrays · 5cad0759
      Georgiy Lebedev authored
      Allocation of URI parameters and their values dynamic arrays is done
      inefficiently: they are reallocated each time a new parameter or parameter
      value is added — grow them exponentially instead.
      
      `struct uri_param` and `struct uri` are exposed in Lua via FFI
      (see src/lua/uri.lua): add warnings about the necessity of reflecting
      changes to them in `ffi.cdecl`.
      
      Closes #7155
      
      NO_DOC=optimization
      NO_TEST=optimization
      5cad0759
    • Timur Safin's avatar
      datetime: datetimes subtractions ignored timezone · 0daed8d5
      Timur Safin authored
      We used to ignore timezone difference (in `tzoffset`) for
      datetime subtraction operation:
      
      ```
      tarantool> datetime.new{tz='MSK'} - datetime.new{tz='UTC'}
      ---
      - +0 seconds
      ...
      
      tarantool> datetime.new{tz='MSK'}.timestamp -
                 datetime.new{tz='UTC'}.timestamp
      ---
      - -10800
      ...
      ```
      
      Now we accumulate tzoffset difference in the minute component
      of a resultant interval:
      
      ```
      tarantool> datetime.new{tz='MSK'} - datetime.new{tz='UTC'}
      ---
      - -180 minutes
      ...
      ```
      
      Closes #7698
      
      NO_DOC=bugfix
      0daed8d5
    • Timur Safin's avatar
      datetime: fix interval arithmetic for DST · 6ca07285
      Timur Safin authored
      We did not take into consideration the fact that
      as result of date/time arithmetic we could get
      in a different timezone, if DST boundary has been
      crossed during operation.
      
      ```
      tarantool> datetime.new{year=2008, month=1, day=1,
      			tz='Europe/Moscow'} +
      	   datetime.interval.new{month=6}
      ---
      - 2008-07-01T01:00:00 Europe/Moscow
      ...
      ```
      
      Now we resolve tzoffset at the end of operation if
      tzindex is not 0.
      
      Fixes #7700
      
      NO_DOC=bugfix
      6ca07285
    • Ilya Verbin's avatar
      box: forbid DDL operations until box.schema.upgrade · 38f88795
      Ilya Verbin authored
      Currently, in case of recovery from an old snapshot, Tarantool allows to
      perform DDL operations on an instance with non-upgraded schema.
      It leads to various unpredictable errors (because the DDL code assumes
      that the schema is already upgraded). This patch forbids the following
      operations unless the user has the most recent schema version:
      - box.schema.space.create
      - box.schema.space.drop
      - box.schema.space.alter
      - box.schema.index.create
      - box.schema.index.drop
      - box.schema.index.alter
      - box.schema.sequence.create
      - box.schema.sequence.drop
      - box.schema.sequence.alter
      - box.schema.func.create
      - box.schema.func.drop
      
      Closes #7149
      
      NO_DOC=bugfix
      38f88795
    • Ilya Verbin's avatar
      box: use dd_version_id instead of _schema.version in get_version · 3e6393d5
      Ilya Verbin authored
      By default a user might not have privileges to access the _schema space,
      that will cause an error during schema_needs_upgrade(), which calls
      get_version(). Fix this by using C variable dd_version_id, which is
      updated in the _schema.version replace trigger.
      
      There's a special case for upgrade() during bootstrap() - triggers are
      disabled during bootstrap, that's why dd_version_id is not being updated.
      Handle this by passing _initial_version=1.7.5 to the upgrade function.
      
      Part of #7149
      
      NO_DOC=internal
      NO_CHANGELOG=internal
      3e6393d5
  7. Oct 14, 2022
    • Mergen Imeev's avatar
      sql: fix assertion in JOIN using unsupported index · fd780129
      Mergen Imeev authored
      This patch fixed the assertion when JOIN uses index of unsupported type.
      
      Closes #5678
      
      NO_DOC=bugfix
      fd780129
    • Vladimir Davydov's avatar
      vinyl: implement transaction isolation levels · 588170a7
      Vladimir Davydov authored
      This commit adds support of transaction isolation levels introduced
      earlier for memtx mvcc by commit ec750af6 ("txm: introduce
      transaction isolation levels"). The isolation levels work exactly in
      the same way as in memtx:
      
       - Unless a transaction explicitly specifies the 'read-committed'
         isolation level, it'll skip prepared statements, even if they are
         visible from its read view. The background for this was implemented
         in the previous patches, which added the is_prepared_ok flag to
         cache and mem iterators.
      
       - If a transaction skips a prepared statement, which would otherwise be
         visible from its read view, it's sent to the most recent read view
         preceding the prepared statement LSN. Note, older prepared statements
         are still visible from this read view and can actually be selected if
         committed later.
      
       - A transaction using the 'best-effort' isolation level (default) is
         switched to 'read-committed' when it executes the first write
         statement.
      
      The implementation is tested by the existing memtx mvcc tests that were
      made multi-engine in the scope of this commit. However, we add one more
      test case - the one that checks that a 'best-effort' read view is
      properly updated in case there is more than one prepared transaction.
      Also, there are few tests that relied upon the old implementation and
      assumed that select from Vinyl may return unconfirmed tuples. We update
      those tests here as well.
      
      Closes #5522
      
      NO_DOC=already documented
      588170a7
    • Vladimir Davydov's avatar
      vinyl: allow to skip prepared statements in cache iterator · f4ffd191
      Vladimir Davydov authored
      To implement read-confirmed and best-effort isolation levels, we need
      to skip unconfirmed (aka prepared) statements in the cache iterator. To
      achieve that, we add a new flag is_prepared_ok. Unless the flag is set,
      the iterator will skip prepared statements even if they are visible from
      the iterator read view. Note, in contrast to the mem iterator, we don't
      need to keep track of the min skipped statement LSN, because the cache
      is just a view of the underlying levels so we'll find it out when we
      descend to the mem level.
      
      Needed for #5522
      
      NO_DOC=internal
      NO_CHANGELOG=internal
      f4ffd191
    • Vladimir Davydov's avatar
      vinyl: allow to skip prepared statements in mem iterator · 0986bd99
      Vladimir Davydov authored
      To implement read-confirmed and best-effort isolation levels, we need
      to skip unconfirmed (aka prepared) statements in the mem iterator. To
      achieve that, we add a new flag is_prepared_ok. Unless the flag is set,
      the iterator will skip prepared statements even if they are visible from
      the iterator read view. Upon skipping a statement, the iterator updates
      min_skipped_plsn if the LSN of the skipped statement is less. We'll use
      this LSN to update the transaction read view accordingly.
      
      Needed for #5522
      
      NO_DOC=internal
      NO_CHANGELOG=internal
      0986bd99
    • Vladimir Davydov's avatar
      vinyl: maintain list of all prepared transactions · 46e5a515
      Vladimir Davydov authored
      This commit replaces vy_tx_manager::last_prepared_tx with a list of all
      prepared transactions sorted by PSN. We need this list to find the
      newest prepared transaction that is older than a given PSN, which is
      required to switch to the most recent read view in the 'best-effort'
      isolation level when an unconfirmed (prepared) statement is skipped.
      
      Needed for #5522
      
      NO_DOC=internal
      NO_TEST=internal
      NO_CHANGELOG=internal
      46e5a515
    • Vladimir Davydov's avatar
      vinyl: add vy_stmt_is_prepared helper · e3c6f13c
      Vladimir Davydov authored
      Unconfirmed statements have lsn >= MAX_LEN. Let's add a helper function
      that would check this.
      
      Needed for #5522
      
      NO_DOC=refactoring
      NO_TEST=refactoring
      NO_CHANGELOG=refactoring
      e3c6f13c
    • Vladimir Davydov's avatar
      vinyl: create autocommit transaction for index.get · 74ab085c
      Vladimir Davydov authored
      If index.get is called outside a transaction, we use the global read
      view for it and set tx to NULL. This works fine for now, but may result
      in dirty reads in a single statement, because prepared but not yet
      committed to WAL statements are visible in the global read view. We are
      planning to fix it in the tx manager. Let's make index.get create a
      dummy transaction so once we fix it, index.get will always return
      committed statements.
      
      Note, index.pairs already creates a dummy transaction if called
      outside a transaction (see vinyl_index_create_iterator) so this patch
      makes behavior consistent across both read paths.
      
      Needed for #5522
      
      NO_DOC=refactoring
      NO_TEST=refactoring
      NO_CHANGELOG=refactoring
      74ab085c
    • Georgiy Lebedev's avatar
      core: remove workaround for backtracing with PAC on AARCH64 · 88e89d5f
      Georgiy Lebedev authored
      With libunwind/libunwind@f67ef28 we can now use `unw_backtrace` with
      PAC enabled on AARCH64 and remove the workaround with glibc's `backtrace`
      for this case.
      
      Closes #7285
      
      NO_CHANGELOG=refactoring
      NO_DOC=refactoring
      NO_TEST=refactoring
      88e89d5f
  8. Oct 13, 2022
    • Vladislav Shpilevoy's avatar
      replication: send raft terms in applier heartbeats · 54495510
      Vladislav Shpilevoy authored
      There was a bug that an instance could ack a transaction from an
      old Raft term thus allowing the old leader to CONFIRM it, even if
      that first instance knew there is a newer Raft term going on.
      
      As a result, the old leader could write CONFIRM even if there is
      already a new leader elected and the synchro quorum was > half.
      That led to split-brain, when bad txn reached the new leader, and
      PROMOTE reached the old leader.
      
      Split-brain here is totally unnecessary. If the quorum is correct,
      synchro timeout is infinite, and there is no async transactions,
      then split-brain shouldn't ever happen.
      
      The fix is as simple as attach the current Raft term number to
      applier heartbeats.
      
      In the testcase above if terms are attached, the old leader gets
      ACK + new term. That causes the old leader freeze even if the
      pending txn got quorum. The old leader can't CONFIRM nor ROLLBACK
      its pending txns until a new leader is elected.
      
      Freeze is guaranteed, because if a new leader was elected, then it
      had got votes from > half cluster. It means > half nodes have the
      new term. That in turn means the old leader during collecting ACKs
      for its "new" txn will get the new term number from at least one
      replica.
      
      When the new leader finished writing PROMOTE, it either confirms
      or rolls back the txn of the old leader (depending on whether it
      has reached the new leader before promotion). Neither result
      causes split brain. The rollback only causes a non-critical error
      on the old leader raised by the bad txn's commit attempt.
      
      There were some alternatives considered. One of the most promising
      ones was to make instances reject txns if they see these txns
      coming from an instance having an old Raft term. It would help in
      the test provided above. But wouldn't do in a more complicated
      test, when there is a third node which gets the bad transaction,
      then gets local term bumped, and then replicates to any other
      instance. Others would accept that bad txn, because the sender has
      a newer Raft term, even though the txn author is still in the old
      term. Tracking terms of txn author is not possible in too many
      cases so as to rely on that.
      
      Closes #7253
      
      @TarantoolBot document
      Title: New iproto field in applier -> relay ACKs
      The applier->relay channel (from replica back to master) is used
      only for sending ACKs. Replication data goes the other way
      (relay->applier).
      
      These ACKs had 2 fields: `IPROTO_VCLOCK (0x26)` and
      `IPROTO_VCLOCK_SYNC (0x5a)`.
      
      Now they have a new field: `IPROTO_TERM (0x53)`. It is a unsigned
      number containing `box.info.election.term` of the sender node
      (applier, replica).
      54495510
    • Vladislav Shpilevoy's avatar
      raft: factor new term processing function out · c368ed49
      Vladislav Shpilevoy authored
      New term handling from a remote instance is moved into a new
      function raft_process_term(). It is going to be used in a next
      commit to handle incoming bare terms, not full raft_msgs.
      
      Part of #7253
      
      NO_DOC=refactoring
      NO_CHANGELOG=refactoring
      NO_TEST=refactoring
      c368ed49
    • Vladislav Shpilevoy's avatar
      replication: introduce heartbeat request structs · 0a026e02
      Vladislav Shpilevoy authored
      The patch adds structs applier_heartbeat and relay_heartbeat.
      
      It is similar to the previous commit, which does the same for all
      the other replication requests, but these work not via struct
      replication_request.
      
      The heartbeats have their own codecs. The goal is to avoid the big
      expensive replication_request usage with a lot of optional fields.
      It makes sense, because the HBs are sent somewhat frequently.
      
      They also store members by values. But copying before encoding and
      decoding is avoided by storing the HB structs by values right
      inside applier and relay.
      
      The motivation is to simplify addition of a new field to
      applier_heartbeat in a next commit.
      
      Needed for #7253
      
      NO_DOC=refactoring
      NO_CHANGELOG=refactoring
      NO_TEST=refactoring
      0a026e02
    • Vladislav Shpilevoy's avatar
      relay: remove a few outdated comments · 36174b3e
      Vladislav Shpilevoy authored
      There were 3 comments which mentioned relay stream restart. It
      could happen when replicas ignored data from non-leaders. A newly
      elected leader had to re-send data, which others ignored, while
      the source wasn't a leader.
      
      Was removed in the commit 6336ea26
      ("refactoring: remove relay_restart_recovery as unneeded").
      
      This is fixed now, because otherwise some of these comments would
      need to be updated by a next commit in this series.
      
      In scope of #7253
      
      NO_DOC=refactoring
      NO_CHANGELOG=refactoring
      NO_TEST=refactoring
      36174b3e
    • Vladislav Shpilevoy's avatar
      replication: introduce structs for all requests · e0834564
      Vladislav Shpilevoy authored
      The patch adds `struct <name>_request` types for replication
      requests: join, subscribe, register. Only not for ack/heartbeat
      requests. They are covered separately in a next commit.
      
      The motivation is to make them independent. Previously a lot of
      codecs were calling xrow_encode/decode_subscribe() under the hood
      with tons of optional params.
      
      Now inside they all fallback to internal
      `struct replication_request`. The code duplication is reduced,
      because all encoding/decoding is handled by replication_request.
      Also alteration of any of the requests only requires to update
      that request itself and replication_request codec.
      
      Additionally, this is consistent with other requests having their
      own structs like synchro_request, raft_request, call_request, etc.
      
      Alongside the commit fixes xrow_decode_register(), which used to
      try to decode version_id, but the result wasn't used and the
      version_id wasn't encoded in xrow_encode_register() anyway.
      
      This work is done now, because soon replication acks will get a
      new field and it wouldn't be good to update all this codecs mess
      again just for that field.
      
      The downside is that the requests store their members by values.
      That requires to copy them before encoding. Not good for big
      fields like vclocks. OTOH the requests affected by this commit are
      sent very rarely, perf is not important at all.
      
      Needed for #7253
      
      NO_DOC=refactoring
      NO_CHANGELOG=refactoring
      NO_TEST=refactoring
      e0834564
    • Ilya Verbin's avatar
      box: forbid non-string types in key_def.new() · 5215f3f3
      Ilya Verbin authored
      Currently if a non-string type is passed to luaT_key_def_set_part,
      lua_tolstring returns null-pointer type_name, which is passed to
      a string formatting function in diag_set.
      
      Closes #5222
      
      NO_DOC=bugfix
      5215f3f3
    • Ilya Verbin's avatar
      box: strengthen field type check · 2dbaf9c2
      Ilya Verbin authored
      
      Don't accept an empty string or leading part of "str" or "num" as a
      valid field type.
      
      Closes #5940
      
      NO_DOC=Partial field types weren't documented
      
      Co-authored-by: default avatarAlexander Turenko <alexander.turenko@tarantool.org>
      2dbaf9c2
    • Aleksandr Lyapunov's avatar
      box: revoke access of guest to LUA function · 815788c8
      Aleksandr Lyapunov authored
      Since the function is actually an eval, by default there should
      be no execute access right in public role.
      
      Closes tarantool/security#14
      
      NO_DOC=bugfix
      815788c8
    • Mergen Imeev's avatar
      box: drop 'execute' field from uninitialized box · d960476d
      Mergen Imeev authored
      Prior to this patch, it was possible to call box.execute() before box
      was initialized, i.e. before calling box.cfg(). This, however, caused
      box.cfg() to be called automatically, which could be problematic as some
      parameters could not be changed after box.cfg() was called. After this
      patch, box.execute() will only be available when the box has been
      initialized.
      
      Closes #4726
      
      @TarantoolBot document
      Title: box.execute() now available only after initialization of box
      
      Previously, it was possible to call box.execute() before the box was
      configured, in which case the box was configured automatically, which
      could lead to problems with box parameters. Now box.execute() can only
      be called after the box has been properly configured.
      
      It is also forbidden to set language to SQL in a console with an
      unconfigured box.
      d960476d
  9. Oct 12, 2022
  10. Oct 11, 2022
    • Mergen Imeev's avatar
      sql: change rules used to determine NULLIF() type · 805cbaa7
      Mergen Imeev authored
      This patch introduces new rules to determine type of NULLIF() built-in
      function.
      
      Closes #6990
      
      @TarantoolBot document
      Title: New rules to determine type of result of NULLIF
      
      The type of the result of NULLIF() function now matches the type of the
      first argument.
      805cbaa7
    • Mergen Imeev's avatar
      sql: change rules used to determine CASE type · 90f64460
      Mergen Imeev authored
      This patch introduces new rules to determine type of CASE operation.
      
      Part of #6990
      
      @TarantoolBot document
      Title: New rules to determine type of result of CASE
      
      New rules are applied to determine the type of the CASE operation. If
      all values are NULL with no type, or if a bind variable exists among
      the possible results, then the type of CASE is ANY. Otherwise, all NULL
      values with no type are ignored, and the type of CASE is determined
      using the following rules:
      1) if all values of the same type, then type of CASE is this type;
      2) otherwise, if any of the possible results is of one of the
      incomparable types, then the type of CASE is ANY;
      3) otherwise, if any of the possible results is of one of the
      non-numeric types, then the type of CASE is SCALAR;
      4) otherwise, if any of the possible results is of type NUMBER, then the
      type of CASE is NUMBER;
      5) otherwise, if any of the possible results is of type DECIMAL, then
      the type of CASE is DECIMAL;
      6) otherwise, if any of the possible results is of type DOUBLE, then the
      type of CASE is DOUBLE;
      7) otherwise the type of CASE is INTEGER.
      90f64460
  11. Oct 06, 2022
    • Serge Petrenko's avatar
      replication: make ER_READONLY non-retriable for applier · 09c18907
      Serge Petrenko authored
      The commit c1c77782 ("replication: fix bootstrap failing with
      ER_READONLY") made applier retry connection infinitely upon receiving a
      ER_READONLY error on join. At the time of writing that commit, this was
      the only way to make join retriable. Because there were no retries in
      scope of bootstrap_from_master. The join either succeeded or failed.
      
      Later on, bootstrap_from_master was made retriable in commit
      f2ad1dee ("replication: retry join automatically"). Now when
      bootstrap_from_master fails, replica reconnects to all the remote nodes,
      thus updating their ballots, chooses a new (probably different from the
      previous approach) bootstrap leader, and retries booting from it.
      
      The second approach is more preferable, and here's why. Imagine
      bootstrapping a cluster of 3 nodes, A, B and C in a full-mesh topology.
      B and C connect to all the remote peers almost instantly, and both
      independently decide that B will be the bootstrap leader (it means it
      has the smallest uuid among A, B, C).
      
      At the same time, A can't connect to C. B bootstraps the cluster, and
      joins C. After C is joined, A finally connects to C. Now A can choose a
      bootstrap leader. It has an old B's ballot (smallest uuid, but not yet
      booted) and C's ballot (already booted). This is because C's ballot is
      received after cluster bootstrap, and B's ballot was received earlier
      than that. So A believes C is a better bootstrap leader, and tries to
      boot from it.
      
      A will fail joining to C, because at the same time C tries to sync with
      everyone, including A, and thus stays read-only. Since A retries joining
      to the same instance over and over again, this situation makes the A and
      C stuck forever.
      
      Let's retry ER_READONLY on another level: instead of trying to join to
      the same bootstrap leader over and over, try to choose a new bootstrap
      leader and boot from it.
      
      In the situation described above, this means that A would try to join to
      C once, fail due to ER_READONLY, re-fetch new ballots from everyone and
      choose B as a join master (now it has smallest uuid and is booted).
      
      The issue was discovered due to linearizable_test.lua hanging
      occasionally with the following output:
      NO_WRAP
       No output during 40 seconds. Will abort after 320 seconds without output. List of workers not reporting the status:
      - 059_replication-luatest [replication-luatest/linearizable_test.lua, None] at /tmp/t/059_replication-luatest/linearizable.result:0
      [059] replication-luatest/linearizable_test.lua                       [ fail ]
      [059] Test failed! Output from reject file /tmp/t/rejects/replication-luatest/linearizable.reject:
      [059] TAP version 13
      [059] 1..6
      [059] # Started on Thu Sep 29 10:30:45 2022
      [059] # Starting group: linearizable-read
      [059] not ok 1	linearizable-read.test_wait_others
      [059] #   ....11.0~entrypoint.531.dev/test/luatest_helpers/server.lua:104: Waiting for "readiness" on server server_1-q7berSRY4Q_E (PID 53608) timed out
      [059] #   stack traceback:
      [059] #   	....11.0~entrypoint.531.dev/test/luatest_helpers/server.lua:104: in function 'wait_for_readiness'
      [059] #   	...11.0~entrypoint.531.dev/test/luatest_helpers/cluster.lua:92: in function 'start'
      [059] #   	...t.531.dev/test/replication-luatest/linearizable_test.lua:50: in function <...t.531.dev/test/replication-luatest/linearizable_test.lua:20>
      [059] #   	...
      [059] #   	[C]: in function 'xpcall'
      NO_WRAP
      
      Part-of #7737
      
      NO_DOC=bugfix
      09c18907
    • Mergen Imeev's avatar
      sql: fix assertion during INDEXED BY · 22c65f96
      Mergen Imeev authored
      This patch fixed the assertion when using INDEXED BY with an index that
      is at least the third in space.
      
      Closes #5976
      
      NO_DOC=bugfix
      22c65f96
    • Mergen Imeev's avatar
      sql: fix cursor invalidation · 89057a21
      Mergen Imeev authored
      If the length of the tuple is greater than the number of fields in the
      format, it is possible that the cursor in the VDBE will be overridden
      with zeros.
      
      Closes #5310
      
      NO_DOC=bugfix
      89057a21
  12. Oct 05, 2022
  13. Oct 04, 2022
    • Georgiy Lebedev's avatar
      memtx: deprecate HASH index 'GT' iterator type · 302d91cf
      Georgiy Lebedev authored
      For reasons described in #7231 HASH index 'GT' iterator type is deprecated:
      print a warning exactly once about the deprecation.
      
      Closes #7231
      
      @TarantoolBot document
      Title: memtx HASH index 'GT' iterator deprecation
      
      memtx HASH index 'GT' iterator is deprecated since Tarantool 2.11
      (tarantool/tarantool#7231) and will removed in a future release of
      Tarantool: the user will get a warning when using it.
      302d91cf
  14. Sep 30, 2022
    • Vladimir Davydov's avatar
      read_view: don't create tuple format when read view is opened · 8dcefeb2
      Vladimir Davydov authored
      It's incorrect to create a tuple format when a read view is created,
      because the tuple format registry isn't MT-safe so accessing a tuple
      format created in the main thread from another thread by id (for
      tuple_format(tuple)) may not work as expected. To address this issue,
      we'll introduce a thread-local tuple format-registry. As a preparation
      for this, let's create the tuple format when a read view is activated
      by the thread that's going to use it (see the EE repository) while on
      read view creation we now create only a field definition array necessary
      to construct the format.
      
      Needed for https://github.com/tarantool/tarantool-ee/issues/247
      
      NO_DOC=refactoring
      NO_TEST=refactoring
      NO_CHANGELOG=refactoring
      8dcefeb2
Loading