Skip to content
Snippets Groups Projects
  1. Oct 30, 2018
    • Serge Petrenko's avatar
      box: autogrant CREATE,ALTER,DROP to users with READ+WRITE · 269e36d8
      Serge Petrenko authored
      This patch adds an upgrade script to grant CREATE, ALTER, DROP
      privileges to users which have READ+WRITE on respective objects.
      This is needed after removing 1.7 compatibility mode for privileges.
      
      Closes #3539
      269e36d8
    • Serge Petrenko's avatar
      box: remove compatibility mode for privileges · 3e7d3070
      Serge Petrenko authored
      Before version 1.7.7 there were no CREATE or ALTER privileges.
      READ+WRITE permitted object creation and altering.
      In 1.10 CREATE and ALTER privileges were introduced together with a
      compatibility mode in access_check_ddl() which assumed user had CREATE
      and ALTER if it had READ and WRITE on a respective object.
      Now its time for us to remove this compatibility mode.
      
      Part of #3539
      3e7d3070
  2. Oct 26, 2018
    • Kirill Yukhin's avatar
      sql: check read access while executing SQL query · e5834e43
      Kirill Yukhin authored
      Since SQL front-end is not using box API,
      no checkes for read access are performed by VDBE engine.
      Add check to IteratorOpen op-code to make sure that read
      privilege exists for given space.
      Note, that there's is no need to perform DML/DDL checkes as
      they're performed by Tarantool's core.
      
      @TarantoolBot document
      Title: Document behaviour of SQL in presence of
      read access restrictions. Need to clarify, that
      if there's no read access to the space, then not
      only SELECT statements will fail, but also those DML
      which implies reading from spaces indirectly, e.g.:
        UPDATE t1 SET a=2 WHERE b=3;
      
      Closes #2362
      e5834e43
    • Kirill Yukhin's avatar
      sql: use space_by_name in SQL · 5b7cc294
      Kirill Yukhin authored
      Since hash, which maps space name to space pointer was introduced in
      previous patch, use it in SQL front-end as it is heavily needed.
      
      @locker: removed a couple of useless assertions and variable renames
      5b7cc294
    • Kirill Yukhin's avatar
      schema: add space name cache · 030d28f5
      Kirill Yukhin authored
      Since SQL is heavily using name -> space mapping, introduce (instead of
      scanning _space space) dedicated cache, which maps space name to space
      pointer.
      
      @locker: code cleanup
      030d28f5
    • Vladimir Davydov's avatar
      alter: install space commit/rollback triggers before preparing sql view · d792fd26
      Vladimir Davydov authored
      sql_compile_view() may fail, in which case the space will never be
      deleted from (in case of space creation) or inserted back into (in case
      of space drop) the space cache, because commit/rollback triggers, which
      are supposed to do the job, are only installed after preparing a view.
      Fix this by installing triggers before sql_compile_view().
      
      No need to write a test as without this commit sql/view test will
      crash after applying the next commit (the one that introduces space
      name cache).
      
      Fixes commit dc358cb0 ("sql: rework VIEW internals").
      d792fd26
    • Vladimir Davydov's avatar
      Merge branch '1.10-features' into 2.1 · 9975ed06
      Vladimir Davydov authored
      9975ed06
    • Vladimir Davydov's avatar
      Merge branch '1.10' into 1.10-features · 9dcc7849
      Vladimir Davydov authored
      9dcc7849
    • Georgy Kirichenko's avatar
      lua: fix tuple cdata collecting · 022a3c50
      Georgy Kirichenko authored
      In some cases luajit does not collect cdata objects which were
      transformed with ffi.cast as tuple_bless does. In consequence, internal
      table with gc callback overflows and then lua crashes. There might be an
      internal luajit issue because it fires only for jitted code. But assigning
      a gc callback before transformation fixes the problem.
      
      Closes #3751
      022a3c50
    • Vladimir Davydov's avatar
      vinyl: do not account bloom filters to runtime quota · e4338cc5
      Vladimir Davydov authored
      Back when bloom filters were introduced, neither box.info.memory() nor
      box.stat.vinyl().memory didn't exist so bloom filters were accounted to
      box.runtime.info().used for lack of a better place. Now, there's no
      point to account them there. In fact, it's confusing, because bloom
      filters are allocated with malloc(), not from the runtime arena, so
      let's drop it.
      e4338cc5
    • Vladimir Davydov's avatar
      vinyl: fix memory leak in slice stream · 0066457c
      Vladimir Davydov authored
      If a tuple read from a run by a slice stream happens to be out of the
      slice bounds, it will never be freed. Fix it.
      
      The leak was introduced by commit c174c985 ("vinyl: implement new
      simple write iterator").
      0066457c
    • AKhatskevich's avatar
      sql: fix fk set null clause · 9c6c4483
      AKhatskevich authored
      After changing behavior of the `IS` operator (#b3a3ddb5),
      `SET NULL` was rewritten to use `EQ` instead. Which doesn't respect
      NULLs.
      
      This commit fixes the null related behavior by emitting logical
      constructions equivalent for this case to old `IS`.
      The new expression works differently than old `IS` for nulls, however
      the difference doesn't change anything, because matched rows are then
      searched in a child table with `EQ` expression which do not match nulls.
      Before:
      `oldval` old_is `newval`
      Now:
      `oldval` is_null or (`newval` is_not_null and `oldval` eq `newval`)
      
      Closes #3645
      9c6c4483
  3. Oct 25, 2018
  4. Oct 24, 2018
    • Vladimir Davydov's avatar
      xlog: turn use_coio argument of xdir_collect_garbage to flags · a198e273
      Vladimir Davydov authored
      So that we can add more flags.
      a198e273
    • Vladimir Davydov's avatar
      vinyl: account disk statements of each type · b2f85642
      Vladimir Davydov authored
      This patch adds a new entry to per index statistics reported by
      index.stat():
      
        disk.statement
          inserts
          replaces
          deletes
          upserts
      
      It shows the number of statements of each type stored in run files.
      The new statistics are persisted in index files. We will need this
      information so that we can force major compaction when there are too
      many DELETE statements accumulated in run files.
      
      Needed for #3225
      b2f85642
    • Vladimir Davydov's avatar
      vinyl: remove useless local var from vy_range_update_compact_priority · 0a158a4d
      Vladimir Davydov authored
      Local variable total_size equals total_stmt_count.bytes_compressed so we
      don't really need it.
      0a158a4d
    • Vladimir Davydov's avatar
      tuple: zap tuple_extra · e65ba254
      Vladimir Davydov authored
      tuple_extra() allows to store arbitrary metadata inside tuples.
      To use it, one should set extra_size when creating a tuple_format.
      It was introduced for storing UPSERT counter or column mask inside
      vinyl statements. Turned out that it wasn't really needed as UPSERT
      counter can be stored on lsregion while column mask doesn't need to
      be stored at all.
      
      Actually, the whole idea of tuple_extra() is rather crooked: why
      would we need it if we can inherit struct tuple instead, as we do
      in case of memtx_tuple and vy_stmt? Accessing an inherited struct
      is much more convenient than using tuple_extra().
      
      So this patch gets rid of tuple_extra(). To do that, it partially
      reverts the following commits:
      
      6c0842e0 vinyl: refactor vy_stmt_alloc()
      74ff46d8 vinyl: add special format for tuples with column mask
      11eb7816 Add extra size to tuple_format->field_map_size
      e65ba254
    • Vladimir Davydov's avatar
      tuple: zap tuple_format_dup · 9b8c3949
      Vladimir Davydov authored
      This function was only used for creating a format for tuples with column
      mask in vinyl. Not needed anymore and can be removed.
      
      Anyway, it doesn't make much sense to duplciate a tuple format, because
      it can be referenced instead. Besides, once JSON indexes are introcued,
      duplicating a tuple format will be really painful. One more reason to
      drop it now.
      9b8c3949
    • Vladimir Davydov's avatar
      vinyl: zap vy_stmt_column_mask and mem_format_with_colmask · 08afd57f
      Vladimir Davydov authored
      Finally, these atrocities are not used anywhere and can be removed.
      08afd57f
    • Vladimir Davydov's avatar
      vinyl: explicitly pass column mask to vy_check_is_unique · dae21083
      Vladimir Davydov authored
      This patch is a preparation for removing vy_stmt_column_mask.
      dae21083
    • Vladimir Davydov's avatar
      vinyl: explicitly pass column mask to vy_tx_set · 3a0ab1e1
      Vladimir Davydov authored
      This patch is a preparation for removing vy_stmt_column_mask.
      3a0ab1e1
Loading