Skip to content
Snippets Groups Projects
  1. Feb 22, 2022
  2. Feb 21, 2022
    • Oleg Babin's avatar
      tap: inherit strict mode in subtests · 676582c4
      Oleg Babin authored
      Previous behaviour was quite illogical and unexpected. If user
      once defined strict mode at start of tests it's expected that all
      subtests also will have strict mode. However before this patch it
      wasn't so. And wasn't clear at start why enabled strict mode
      didn't work.
      After this patch subtests strict mode will be the same as for
      parent. This behaviour wasn't tested anyhow and wasn't documented.
      
      Follow-up #4125
      
      @TarantoolBot document
      Title: clarify 'strict' behaviour in tap tests
      Defined for root tap object strict mode will be the same for all
      subtests.
      
      Example:
      ```lua
      t = require('tap').test('123')
      t.strict = true
      
      t:is_deeply({a = box.NULL}, {}) -- false
      
      t:test('subtest', function(t)
          t:is_deeply({a = box.NULL}, {}) -- also false
      end)
      ```
      676582c4
    • Oleg Babin's avatar
      lua: fix table.equals result when booleans compared · 840a45c4
      Oleg Babin authored
      Before this patch comparison of two `false` values produced
      incorrect result. That because nil and false are consieded in the
      same way by if operator. This patch fixes an issue and introduces
      corresponding tests.
      
      Closes #6386
      
      NO_DOC=bugfix
      840a45c4
  3. Feb 18, 2022
    • Timur Safin's avatar
      test: TAP compatible unit/datetime.c · d99e50ff
      Timur Safin authored
      * Enabled UNIT_TAP_COMPATIBLE mode in datetime.c
      * Got rid of unnecessary datetime.result
      
      Followup to #5000, #6731, #6796
      NO_DOC=internal
      NO_CHANGELOG=internal
      d99e50ff
    • Timur Safin's avatar
      test: TAP compatible mode in unit.h · dd3f586b
      Timur Safin authored
      TAP (Test Anything Protocol) output must indicate that
      this is TAP13 in the first line. See specification [1].
      
      [1] https://testanything.org/tap-version-13-specification.html
      
      
      
      Introducing in unit.h UNIT_TAP_COMPATIBLE define to activate TAP-compliant
      mode, which may be used by single test to generate TAP output, and get rid
      of result file.
      
      So one could enable new mode this way
      
        /* New test. */
        #define UNIT_TAP_COMPATIBLE 1
        #include <unit.h>
      
      While omitting of this define would still use older (incompatible) mode.
      
        /* Old test. */
        #include <unit.h>
      
      Co-authored-by: default avatarSergey Bronnikov <sergeyb@tarantool.org>
      
      Followup to #5000, #6731, #6796
      NO_DOC=internal
      NO_CHANGELOG=internal
      dd3f586b
  4. Feb 17, 2022
    • Yan Shtunder's avatar
      Add mp_encode_str0() into msgpuck.h · 99d6b8d0
      Yan Shtunder authored
      Msgpuck is a submodule for tarantool and is needed while packaging.
      Moved function of mp_encode_str0() from mp_error.cc into a common
      place is msgpuck.h.
      
      Needed for packaging workflow in tarantool/tarantool:
      tarantool/tarantool#6260
      
      NO_DOC=no visible changes
      NO_CHANGELOG=no visible changes
      99d6b8d0
    • Yaroslav Lobankov's avatar
      luatest: eliminate luatest_helpers.lua · c3253d89
      Yaroslav Lobankov authored
      The luatest_helpers.lua module confuses developers because luatest
      itself has the helpers.lua module as well. It is unclear which one
      should be used and when because it is hard to remember what stuff
      provides each of them.
      
      Actually, luatest_helpers.lua has functions that can be safely moved to
      more proper places (luatest_helpers/server.lua & instances/default.lua).
      
      The `get_vclock` function logically belongs to server stuff, so it was
      moved to server.lua and slightly changed (`eval` call was replaced by
      `exec`).
      
      The `wait_vclock` function logically belongs to server stuff as well, so
      it was moved to server.lua without changes.
      
      The `instance_uri` function logically belongs to server stuff as well,
      so it was moved to server.lua and slightly changed (it was renamed into
      `build_instance_uri` and redundant `instance_id` param was dropped).
      
      The `default_cfg`, `env_cfg`, `box_cfg` functions logically belongs to
      instance stuff, so they were moved to default.lua without changes.
      
      Thus, the luatest_helpers.lua module was dropped and tests using this
      module were updated.
      
      Closes tarantool/luatest#192
      
      NO_DOC=testing stuff
      NO_CHANGELOG=testing stuff
      c3253d89
    • Yaroslav Lobankov's avatar
      luatest: eliminate luatest_helpers/asserts.lua · dbcb2d53
      Yaroslav Lobankov authored
      The luatest_helpers/asserts.lua module confuses developers because
      luatest itself has the asserts.lua module as well. It is unclear which
      one should be used and when because it is hard to remember what stuff
      provides each of them.
      
      Actually, luatest_helpers/asserts.lua has functions that are not really
      about asserting and can be safely moved to more proper places like the
      luatest_helpers/server.lua and luatest_helpers/cluster.lua modules.
      
      The `assert_server_follow_upstream` function logically belongs to server
      stuff, so it was moved to server.lua and slightly changed (renamed into
      `assert_follows_upstream` and `eval` calls were replaced by `exec`).
      
      The `wait_fullmesh` function logically belongs to cluster stuff, so it
      was moved to cluster.lua and slightly changed (now it accepts one param
      that can include wait timeout and delay, otherwise, defaults applied).
      
      Thus, the luatest_helpers/asserts.lua module was dropped and tests using
      this module were updated.
      
      Part of tarantool/luatest#192
      
      NO_DOC=testing stuff
      NO_CHANGELOG=testing stuff
      dbcb2d53
    • Yaroslav Lobankov's avatar
      test: remove checksums from suite.ini config files · fc177b33
      Yaroslav Lobankov authored
      We have recently dropped 'checksum' machinery in test-run
      (tarantool/test-run#321) and now there is no need to keep
      checksums in suite.ini config files. So removing them.
      
      Closes tarantool/tarantool-qa#152
      fc177b33
    • Igor Munkin's avatar
      luajit: bump new version · bc1deaff
      Igor Munkin authored
      * test: adapt tests checking loading bytecode files
      * test: adapt disabled tests from PUC-Rio
      * test: adapt tests checking traceback in tail call
      * test: adapt test checking global environment
      
      Closes #5687
      Closes #5691
      Closes #5703
      Closes #5713
      Part of #5870
      
      NO_DOC=LuaJIT submodule bump
      NO_CHANGELOG=no visible changes
      bc1deaff
    • Yaroslav Lobankov's avatar
      test-run: drop 'checksum' machinery · a70797f1
      Yaroslav Lobankov authored
      Bump test-run to new version with the following improvements:
      
        - drop 'checksum' machinery (tarantool/test-run#316)
        - rerun fragile tests only with status == 'fail'
      
      NO_DOC=testing stuff
      NO_CHANGELOG=testing stuff
      a70797f1
    • Alexander Turenko's avatar
      sql: fix assert when compare a tuple with a key · 330100bf
      Alexander Turenko authored
      The function of the question (`tarantoolsqlIdxKeyCompare()`) compares a
      tuple with a key. It extracts necessary fields from the tuple and runs
      the compare function, which is basically `memcmp()` of two buffers (for
      `varbinary` values -- numeric comparisons are different).
      
      In the Debug build the function also re-verifies the result using a
      separate comparison code. And here we compare two `memcmp()` return
      values.
      
      We shouldn't do it directly, because `memcmp()` only guarantees sign of
      the result. Please, consider the linked issue for details.
      
      NO_DOC=only debug build is affected
      NO_CHANGELOG=only debug build is affected
      NO_TEST=hard to create a stable reproducer
      
      Fixes #6849
      330100bf
  5. Feb 15, 2022
    • Vladislav Shpilevoy's avatar
      test: cover local broadcast of leader resign event · e7595b6e
      Vladislav Shpilevoy authored
      The broadcast doesn't need to go into the network, but
      it will be needed locally for a built-in event. So
      called "box.election".
      
      Part of #6260
      
      NO_DOC=no visible changes
      NO_CHANGELOG=no visible changes
      e7595b6e
    • Sergey Ostanevich's avatar
      raft: broadcast for voter received leader resign · eaa526f5
      Sergey Ostanevich authored
      In case a leader steps down - e.g. switching to a 'voter' - it will send
      appropriate message. This message being received by a follower
      will not trigger a broadcast, if follower is a 'voter'.
      
      NO_DOC=no visible changes
      NO_CHANGELOG=no visible changes
      eaa526f5
    • Vladimir Davydov's avatar
      tools: gen-release-notes: python 2 fix · 0b272285
      Vladimir Davydov authored
       1. There's a non-ASCII character in a comment (’). Replase it with a
          plain comma ('). Fixes commit
          19be79e6 ("tools: gen-release-notes:
          adapt for enterprise").
       2. In Python 2 subprocess.Popen() doesn't support the 'with' clause.
          Do not use the 'with' clause. Fixes commit
          5715f194 ("tools: gen-release-notes:
          factor out popen helper")
      
      As a result CI fails. I wonder why it passed on the PR...
      
      Follow-up #6855
      
      NO_DOC=tools
      NO_CHANGELOG=tools
      0b272285
    • Vladimir Davydov's avatar
      tools: gen-release-notes: adapt for enterprise · 19be79e6
      Vladimir Davydov authored
      We're going to reuse the existing tools/gen-release-notes script for
      generation of Enterprise Edition (EE) changelogs. To do that, we need to
      
       1. Add 'enterprise' to the head of the sections list. The new section
          will be used by EE changelog entries. We want them to go before
          open-source changelog entries.
       2. Gather changelog entries from the 'changelog/unreleased' directory
          of the superproject directory. EE uses the open-source repository as
          its submodule.
      
      NO_DOC=tools
      NO_CHANGELOG=tools
      19be79e6
    • Vladimir Davydov's avatar
      tools: gen-release-notes: pass dir to changelog_entries · 606f06c0
      Vladimir Davydov authored
      So that we can gather changelog entries from more than one directory.
      
      NO_DOC=tools
      NO_CHANGELOG=tools
      606f06c0
    • Vladimir Davydov's avatar
      tools: gen-release-notes: factor out popen helper · 5715f194
      Vladimir Davydov authored
      We will use it for running other commands.
      
      NO_DOC=tools
      NO_CHANGELOG=tools
      5715f194
    • Vladimir Davydov's avatar
      tools: gen-release-notes: drop entries_dir_relative · 8e2123b3
      Vladimir Davydov authored
      Trivial refactoring that replaces source_dir and entries_dir_relative
      changelog_entries_sorted() arguments with entries_dir. Needed to make
      the following work easier.
      
      NO_DOC=tools
      NO_CHANGELOG=tools
      8e2123b3
  6. Feb 14, 2022
    • Yaroslav Lobankov's avatar
      test-run: improve luatest test fail reporting · e4f9d040
      Yaroslav Lobankov authored
      - Improve reporting from failed luatest tests (tarantool/test-run#319)
      - Update luatest to 0.5.7 (tarantool/test-run#322)
      e4f9d040
    • Mergen Imeev's avatar
      sql: introduce FINALIZE for custom aggregate · 8db0ce9f
      Mergen Imeev authored
      This patch introduces a way to create a FINALIZER for user-defined
      aggregate functions.
      
      Closes #2579
      
      @TarantoolBot document
      Title: User-defined aggregate functions
      
      User-defined aggregate functions are now available. To create a
      user-defined aggregate function, the 'aggregate' option should be set to
      'group'.  The function must have at least one argument. The last
      argument is always the result of the function in the previous step, or
      NULL if it is the first step. The last argument will be added
      automatically.
      
      Example:
      ```
      box.schema.func.create("F1", {language = "Lua",
          body = [[
              function(x, state)
                  if state == nil then
                      state = {sum = 0, count = 0}
                  end
                  state.sum = state.sum + x
                  state.count = state.count + 1
                  return state
              end
          ]],
          param_list = {"integer", "map"},
          returns = "map",
          aggregate = "group",
          exports = {"SQL"},
      })
      
      box.execute('CREATE TABLE t (i INT PRIMARY KEY);')
      box.execute('INSERT INTO t VALUES(1), (2), (3), (4), (5);')
      box.execute('SELECT f1(i) FROM t;')
      ```
      
      The result will be:
      ```
      tarantool> box.execute([[select f1(i) from t;]])
      ---
      - metadata:
        - name: COLUMN_1
          type: map
        rows:
        - [{'sum': 15, 'count': 5}]
      ...
      ```
      
      To create a finalizer for a function, another function should be
      created. This function should follow the following rules:
      1) its name should be '<function name>_finalize';
      2) it must take exactly one argument;
      3) it must be a non-aggregate function.
      
      If an aggregate function has a finalizer, the result of the aggregate
      function will be determined by the finalizer.
      
      Example:
      ```
      box.schema.func.create("F1_finalize", {
          language = "Lua",
          body = [[
              function(state)
                  if state == nil then
                      return 0
                  end
                  return state.sum / state.count
              end
          ]],
          param_list = {"map"},
          returns = "number",
          exports = {'LUA', 'SQL'},
      })
      box.execute('SELECT f1(i) FROM t;')
      ```
      
      The result will be:
      ```
      tarantool> box.execute([[select f1(i) from t;]])
      ---
      - metadata:
        - name: COLUMN_1
          type: number
        rows:
        - [3]
      ...
      ```
      8db0ce9f
    • Mergen Imeev's avatar
      sql: introduce custom aggregate functions · 62667d54
      Mergen Imeev authored
      This patch introduces user-defined aggregate functions in SQL.
      
      Part of #2579
      62667d54
    • Mergen Imeev's avatar
      0181265e
    • Mergen Imeev's avatar
      sql: fix COUNT() optimization conditions · 46cfad3b
      Mergen Imeev authored
      This patch fixes the conditions under which COUNT() is optimized. At
      some point, the conditions were broken, but since there was no other
      aggregate function requiring zero arguments, this problem did not change
      the behavior.
      
      Needed for #2579
      46cfad3b
  7. Feb 11, 2022
    • Igor Munkin's avatar
      luajit: bump new version · 17f08c82
      Igor Munkin authored
      * gdb: add mmudata value to lj-gc output
      * gdb: unwind Lua stack top part
      Unverified
      17f08c82
    • Oleg Babin's avatar
      netbox: allow to disable schema fetch · 58625f3a
      Oleg Babin authored
      Before this patch each connection reload server schema if it
      changed. However in some cases it's actually redundant e.g. user
      performs only call and eval operations. This patch introduces
      "fetch_schema" option (true by default to keep backward
      compatibility) that allows to ignore schema changes on the server.
      As result remote spaces are unavailable and on_schema_reload
      trigger doesn't work.
      
      @TarantoolBot document
      Title: Document fetch_schema netbox option
      
      Currently user could specify "fetch_schema" flag in netbox
      connection to control schema fetching from remote instance.
      In case if this option is false remote spaces will be unavailable
      and on_schema_reload trigger won't work.
      
      ```
      c = netbox.connect(uri, {fetch_schema = false})
      c.space -- always will be nil
      c:on_schema_reload(function() end) -- never will be triggered
      ```
      
      Closes #4789
      58625f3a
  8. Feb 10, 2022
    • Vladislav Shpilevoy's avatar
      raft: do not rely on just ev_is_active for timers · 3a1c7b78
      Vladislav Shpilevoy authored
      When timer has 0 timeout and 0 repeat, during timers preparation
      libev makes them inactive right away but puts into the array of
      pending events.
      
      Therefore to check if a timer is really active (will be executed
      in the future) need to look both at ev_is_active() and
      ev_is_pending().
      
      It could happen only during split-vote, because all the other
      places use election_timeout + random shift, while split vote uses
      just random shift - it can be 0.
      
      The patch makes raft do that for all timer checks. Also to make
      the testing reliable and not depend on random the shift factor now
      is configurable. For the test it is set to 0.
      
      Closes #6847
      
      NO_DOC=Bugfix
      NO_CHANGELOG=Bug was not released
      3a1c7b78
  9. Feb 09, 2022
    • Vladimir Davydov's avatar
      iostream: add assertion to catch concurrent access · dd1a510e
      Vladimir Davydov authored
      Although it should be fine to use a plain iostream concurrently from
      different threads, this wouldn't work for more complex streams, e.g.
      SSL. Let's add an assertion to catch this.
      
      NO_DOC=debugging
      NO_CHANGELOG=debugging
      dd1a510e
    • Vladimir Davydov's avatar
      applier: move writer fiber to applier thread · f7659e83
      Vladimir Davydov authored
      iostream must not be used concurrently by different threads.
      It works for plain streams, but not for SSL streams.
      
      NO_DOC=enterprise bug fix
      NO_CHANGELOG=enterprise bug fix
      f7659e83
    • Vladimir Davydov's avatar
      applier: move applier_thread struct to header · 3d5545d0
      Vladimir Davydov authored
      The next commit will need to access it from applier_signal_ack, which is
      defined upper. We could move applier_thread upper in the C file, but I
      don't see any point to hide this struct: it brings no new dependencies.
      Let's keep all applier structs together in the header file - it makes
      the code easier to follow.
      
      NO_DOC=refactoring
      NO_CHANGELOG=refactoring
      3d5545d0
    • Vladimir Davydov's avatar
      applier: clear triggers before detaching from thread · f6e78c15
      Vladimir Davydov authored
      Currently, it works either way, but once we move the writer fiber to the
      applier thread, it'll be crucial that no ACK can be signalled after the
      applier is detached.
      
      NO_DOC=refactoring
      NO_CHANGELOG=refactoring
      f6e78c15
    • Vladimir Davydov's avatar
      applier: check sync directly (not from writer) · ee214bf2
      Vladimir Davydov authored
      We check if it's time to switch the applier to the FOLLOW state from
      applier writer, because we might need to call on_state triggers, which
      may yield. The fact is FOLLOW triggers never yield so this isn't
      necessary. Let's move applier_check_sync calls out of applier writer.
      
      This is a step towards moving the applier fiber from the main to the
      applier thread, which is required to properly handle SSL connections.
      
      NO_DOC=refactoring
      NO_CHANGELOG=refactoring
      ee214bf2
    • Vladimir Davydov's avatar
      applier: remove useless state check from writer · 198766db
      Vladimir Davydov authored
      Applier writer fiber is started after JOIN so the only possible states
      are READY, SYNC, and error states. It's fine to try to write on error -
      the operation will be silently ignored (due to EPIPE check below).
      
      This is a step towards moving the applier fiber from the main to the
      applier thread, which is required to properly handle SSL connections.
      
      NO_DOC=refactoring
      NO_CHANGELOG=refactoring
      198766db
    • Vladimir Davydov's avatar
      applier: set proper name for reader fiber · 5cf27023
      Vladimir Davydov authored
      Just like we do for other applier fibers. It's useful for debugging.
      Note, we used proper names before commit
      dacbf708 ("Introduce applier thread").
      
      NO_DOC=minor change in logging
      NO_CHANGELOG=minor change in logging
      5cf27023
    • Vladimir Davydov's avatar
      applier: rename applier->reader to applier->fiber · ff592b25
      Vladimir Davydov authored
      To avoid confusion with applier->thread.reader, which actually does
      reading.
      
      NO_DOC=refactoring
      NO_CHANGELOG=refactoring
      ff592b25
  10. Feb 08, 2022
    • Yaroslav Lobankov's avatar
      test: fix flaky 'test_ignore_with_force_recovery' · 3f86cd04
      Yaroslav Lobankov authored
      From time to time we can see failures of one of `box-luatest` tests.
      It's `gh_6794_recover_nonmatching_xlogs.test_ignore_with_force_recovery`
      test:
      
          [021] box-luatest/gh_6794_recover_nonmatching_xlogs_>
          [021] not ok 2 box-luatest.gh_6794_recover_nonmatching_xlogs.test_ignore_with_force_recovery #
          [021] Rejected result file: /tmp/tnt/rejects/box-luatest/gh_6794_recover_nonmatching_xlogs.reject
          [021] [ fail ]
      
      More detailed failure log:
      
          not ok 2	box-luatest.gh_6794_recover_nonmatching_xlogs.test_ignore_with_force_recovery
          #   .../tarantool/test/luatest_helpers/server.lua:99: Waiting for "readiness" on server master-UCg6PXluSqYt (PID 85920) timed out
          #   stack traceback:
          #   	.../tarantool/test/luatest_helpers/server.lua:99: in function 'wait_for_readiness'
          #   	.../tarantool/test/luatest_helpers/server.lua:146: in function 'start'
          #   	...t/box-luatest/gh_6794_recover_nonmatching_xlogs_test.lua:32: in function 'box-luatest.gh_6794_recover_nonmatching_xlogs.test_ignore_with_force_recovery'
          #   	...
          #   	[C]: in function 'xpcall'
      
      If we take a look at the log of a tarantool server that is used for
      testing, we will see the failure reason:
      
          2022-02-04 21:06:12.063 [85920] main/103/default.lua evio.c:240 E> SocketError: unlink, called on fd 27, aka unix/:(socket), peer of unix/:(socket): Address already in use
          2022-02-04 21:06:12.063 [85920] main/103/default.lua F> can't initialize storage: unlink, called on fd 27, aka unix/:(socket), peer of unix/:(socket): Address already in use
      
      Both tests from the gh_6794_recover_nonmatching_xlogs_test.lua file used
      the same alias (master) for the tarantool server, hence in both tests
      the tarantool server used a socket with the same name (master.iproto).
      So we had a race here: if the socket from the previous test was released
      in time, our test succeeded, otherwise, failed.
      
      To fix the issue it was decided to create tarantool servers with
      different aliases. This gives us sockets with different names, hence no
      socket intersection.
      
      Closes tarantool/tarantool-qa#151
      
      NO_CHANGELOG=test stuff
      NO_DOC=testing stuff
      3f86cd04
    • Yaroslav Lobankov's avatar
      Migrate update_optimize.test.lua to luatest · 1b0bd504
      Yaroslav Lobankov authored
      All tests from the update_optimize.test.lua file were fully migrated
      to the luatest framework. The old test files were deleted.
      
      Closes #6556
      
      NO_CHANGELOG=testing stuff
      NO_DOC=testing stuff
      1b0bd504
    • Georgiy Lebedev's avatar
      core: refactor `get_proc_name` · adecbca8
      Georgiy Lebedev authored
      
      `get_proc_name` code is clogged with procedure cache management logic:
      refactor this logic out.
      
      Needed for #4002
      
      NO_DOC=refactoring
      NO_CHANGELOG=refactoring
      
      Co-authored-by: default avatarEgor Elchinov <elchinov.es@gmail.com>
      Co-authored-by: default avatarGeorgiy Lebedev <g.lebedev@tarantool.org>
      adecbca8
  11. Feb 07, 2022
    • Serge Petrenko's avatar
      relay: send heartbeats while reading a WAL · ee6de025
      Serge Petrenko authored
      As soon as replica subscribes, relay starts scanning the first requested
      WAL file to find the position from which to start replication. While the
      scan is in progress, relay never sends heartbeats to the replica, so a
      really long scan can make the replica timeout before relay finally finds
      the point to replicate from.
      
      Two similar problems were already addressed in
      30ad4a55 ("relay: yield explicitly every N sent rows") and
      17289440 ("recovery: make it yield when positioning in a WAL")
      
      These patches do not fix the issue completely for relay: even though now
      it yields while scanning a WAL, it doesn't send heartbeats anyway.
      
      Fix the issue by not only yielding, but sending heartbeats as well while
      WAL scan is in progress.
      
      Follow-up #5979
      Closes #6706
      ee6de025
    • Serge Petrenko's avatar
      relay: remove unused row_count parameter · d1425b83
      Serge Petrenko authored
      Sent rows were counted explicitly before the patch
      17289440 ("recovery: make it yield when positioning in a WAL").
      Now all the row count details are hidden inside the xstream.
      
      Remove the redundant field.
      
      Follow-up #5979
      d1425b83
Loading