luatest: eliminate luatest_helpers.lua
The luatest_helpers.lua module confuses developers because luatest itself has the helpers.lua module as well. It is unclear which one should be used and when because it is hard to remember what stuff provides each of them. Actually, luatest_helpers.lua has functions that can be safely moved to more proper places (luatest_helpers/server.lua & instances/default.lua). The `get_vclock` function logically belongs to server stuff, so it was moved to server.lua and slightly changed (`eval` call was replaced by `exec`). The `wait_vclock` function logically belongs to server stuff as well, so it was moved to server.lua without changes. The `instance_uri` function logically belongs to server stuff as well, so it was moved to server.lua and slightly changed (it was renamed into `build_instance_uri` and redundant `instance_id` param was dropped). The `default_cfg`, `env_cfg`, `box_cfg` functions logically belongs to instance stuff, so they were moved to default.lua without changes. Thus, the luatest_helpers.lua module was dropped and tests using this module were updated. Closes tarantool/luatest#192 NO_DOC=testing stuff NO_CHANGELOG=testing stuff
Showing
- test/box-luatest/gh_6199_schema_priv_resolve_existence_check_test.lua 1 addition, 7 deletions...test/gh_6199_schema_priv_resolve_existence_check_test.lua
- test/box-luatest/gh_6310_grant_rw_access_on__session_settings_space_to_public_role_test.lua 2 additions, 13 deletions...access_on__session_settings_space_to_public_role_test.lua
- test/instances/default.lua 36 additions, 10 deletionstest/instances/default.lua
- test/luatest_helpers.lua 0 additions, 72 deletionstest/luatest_helpers.lua
- test/luatest_helpers/server.lua 38 additions, 5 deletionstest/luatest_helpers/server.lua
- test/replication-luatest/election_split_vote_test.lua 3 additions, 3 deletionstest/replication-luatest/election_split_vote_test.lua
- test/replication-luatest/gh_4669_applier_reconnect_test.lua 3 additions, 3 deletionstest/replication-luatest/gh_4669_applier_reconnect_test.lua
- test/replication-luatest/gh_5418_qsync_with_anon_test.lua 5 additions, 5 deletionstest/replication-luatest/gh_5418_qsync_with_anon_test.lua
- test/replication-luatest/gh_5568_read_only_reason_test.lua 4 additions, 4 deletionstest/replication-luatest/gh_5568_read_only_reason_test.lua
- test/replication-luatest/gh_6123_truncate_temp_space_test.lua 6 additions, 6 deletions.../replication-luatest/gh_6123_truncate_temp_space_test.lua
- test/replication-luatest/no_quorum_test.lua 4 additions, 4 deletionstest/replication-luatest/no_quorum_test.lua
- test/replication-luatest/quorum_master_test.lua 4 additions, 4 deletionstest/replication-luatest/quorum_master_test.lua
- test/replication-luatest/quorum_misc_test.lua 8 additions, 8 deletionstest/replication-luatest/quorum_misc_test.lua
- test/replication-luatest/quorum_orphan_test.lua 4 additions, 4 deletionstest/replication-luatest/quorum_orphan_test.lua
- test/vinyl-luatest/gh_6568_replica_initial_join_removal_of_compacted_run_files_test.lua 2 additions, 13 deletions...lica_initial_join_removal_of_compacted_run_files_test.lua
Loading