Skip to content
Snippets Groups Projects
  1. Dec 09, 2024
    • Arseniy Volynets's avatar
      fix(ci): compile error for centos/altlinux · 6da5be5e
      Arseniy Volynets authored and Dmitry Ivanov's avatar Dmitry Ivanov committed
      Previous commit caused CI `pack` job
      to fail on some linux distros. This
      commit fixes the warnings from compiler.
      
      NO_DOC=picodata internal patch
      NO_CHANGELOG=picodata internal patch
      NO_TEST=picodata internal patch
      6da5be5e
    • Arseniy Volynets's avatar
      feat: add limit for max executed vdbe opcodes · 032e2659
      Arseniy Volynets authored and Dmitry Ivanov's avatar Dmitry Ivanov committed
      - Add a configurable non-negative
      session parameter "sql_vdbe_max_steps"
      -- max number of opcodes that Vdbe
      is allowed to execute for sql query.
      
      - Default value can be specified in box.cfg.
      If not set via box.cfg, default value
      is 45000. Value 0 means that no
      checks for number of executed Vdbe
      opcodes will be made.
      
      - Add the third argument to box.execute
      function, that allows to specify options
      for query execution. The only option
      supported: sql_vdbe_max_steps. Usage
      example:
      
      ```
      box.execute([[select * from t]], {}, {{sql_vdbe_max_steps = 1000}})
      ```
      
      part of picodata/picodata/sbroad!461
      
      NO_DOC=picodata internal patch
      NO_CHANGELOG=picodata internal patch
      032e2659
    • Maksim Kaitmazian's avatar
      feat: implement md5 authentication · 30038100
      Maksim Kaitmazian authored and Dmitry Ivanov's avatar Dmitry Ivanov committed
      It prevents password sniffing and avoids storing passwords on the
      server in plain text but provides no protection if an attacker
      manages to steal the password hash from the server.
      
      Usage example:
      ```lua
      -- Enable the md5 authentication method for all new users.
      box.cfg({auth_type = 'md5'})
      
      -- Reset existing user passwords to use the md5 authentication method.
      box.schema.user.passwd('alice', 'topsecret')
      
      -- Authenticate using the md5 authentication method via net.box.
      conn = require('net.box').connect(uri, {
          user = 'alice',
          password = 'topsecret',
          -- Specifying the authentication method isn't strictly necessary:
          -- by default the client will use the method set in the remote
      	-- server config (box.cfg.auth_type)
          auth_type = 'md5',
      })
      ```
      
      part of picodata/picodata/sbroad!377
      
      @TarantoolBot document
      Title: md5 authentication method
      
      See the commit message.
      30038100
    • Maksim Kaitmazian's avatar
      feat: add user name argument to `auth_method` api · e749fbf1
      Maksim Kaitmazian authored and Dmitry Ivanov's avatar Dmitry Ivanov committed
      User name is usually used as a salt for user password in order to
      avoid password repeating.
      For instance, postgres md5 authentication stores passwords as
      md5("password", "user"), so that the same passwords are represented by
      different hashes.
      
      part of picodata/picodata/sbroad!377
      
      @TarantoolBot document
      Title: Document updated `box.schema.user.password` declaration.
      
      Since auth methods can use user name for hashing, user name is
      added to argument list of `box.schema.user.password`.
      
      NO_TEST=there are no methods that use user name
      e749fbf1
    • godzie44's avatar
      fix: use-after-free in `cbus_endpoint_delete` · 5b2fb5dd
      godzie44 authored and Dmitry Ivanov's avatar Dmitry Ivanov committed
      Calling a `TRASH` macro after calling the `free`
      function dereferences the pointer to the already
      freed memory.
      
      NO_DOC=picodata internal patch
      NO_CHANGELOG=picodata internal patch
      NO_TEST=picodata internal patch
      5b2fb5dd
    • Gleb Kashkin's avatar
      console: fix :endswith() err in tntctl connection · 71d87e97
      Gleb Kashkin authored and Dmitry Ivanov's avatar Dmitry Ivanov committed
      There used to be a rare error when failed to connect via tarantoolctl to
      listening cartridge console. It was caused by unclear
      console.local_print() contract. Starting from gh-7031 fix, the function
      assumed string-only arguments, while in some cases cdata error was
      passed.
      
      Now console.local_print() prints all non-string arguments as is, without
      modifying potential local_eos.
      
      Closes #8374
      
      NO_DOC=bugfix
      NO_TEST=very hard to test
      71d87e97
    • Denis Smirnov's avatar
      fix: tuple hash calculation tests · b8e801cb
      Denis Smirnov authored and Dmitry Ivanov's avatar Dmitry Ivanov committed
      Tuple hash calculation tests for the C API were incorrect. Thanks
      to the full pipeline with DEBUG build we detected the problem and
      fixed it.
      
      NO_DOC=picodata internal patch
      NO_CHANGELOG=picodata internal patch
      b8e801cb
    • Denis Smirnov's avatar
      feat: expose tuple hash calculation method · e1ce65e8
      Denis Smirnov authored and Dmitry Ivanov's avatar Dmitry Ivanov committed
      Picodata supports cluster-wide SQL and needs some predictable
      method to calculate tuple hashes for the bucket ids. Method
      should be available for Lua, C and Rust users. It was decided
      to expose a murmur3 hash calculation method of the key_def module.
      
      NO_DOC=picodata internal patch
      NO_CHANGELOG=picodata internal patch
      e1ce65e8
    • godzie44's avatar
      cbus: introduce lcpipe - light cpipe · d653d088
      godzie44 authored and Dmitry Ivanov's avatar Dmitry Ivanov committed
      Introduced a new type of cbus pipe - lcpipe. The current pipe in the
      cbus - cpipe, has a number of limitations, first of all - the cpipe
      cannot be used from the 3rd party threads, cpipe only works as a channel
      between two cords. That why lcpipe is needed. Its main responsibility -
      create channel between any thread and tarantool cord.
      
      Internally lcpipe is a cpipe, but:
      - on flush triggers removed, cause triggers use thread-local mem-pool,
      this is not possible on a third party thread
      - producer event loop removed, cause there is no libev event loop in
      third party thread
      
      Also, lcpipe interface is exported to the outside world.
      
      NO_DOC=core feature
      d653d088
    • Дмитрий Кольцов's avatar
      build(CMakeLists.txt): disable feedback daemon by default · 7900c396
      Дмитрий Кольцов authored and Dmitry Ivanov's avatar Dmitry Ivanov committed
      NO_DOC=disable feedback
      NO_TEST=disable feedback
      7900c396
    • Дмитрий Кольцов's avatar
      fix(schema version): fix some types that were not updated to 64 bit · f0b9104f
      Дмитрий Кольцов authored and Dmitry Ivanov's avatar Dmitry Ivanov committed
      NO_DOC=core feature
      NO_TEST=no Lua API
      NO_CHANGELOG=bugfix
      f0b9104f
    • Дмитрий Кольцов's avatar
      feat(json): add option to encode decimals as string · a85eebb6
      Дмитрий Кольцов authored and Dmitry Ivanov's avatar Dmitry Ivanov committed
      Due to inconsistency of Tarantool type casting while using strict
      data types as "double" or "unsigned" it is needed
      to use "number" data type in a whole bunch of cases.
      However "number" may contain "decimal" that will be serialized into
      string by JSON builtin module.
      
      This commit adds "encode_decimal_as_number" parameter to json.cfg{}.
      That forces to encode `decimal` as JSON number to force type
      consistency in JSON output.
      Use with catious - most of JSON parsers assume that number is restricted
      to float64.
      
      NO_DOC=we do not host doc
      a85eebb6
    • Denis Smirnov's avatar
      sql: fix string dequoting · 5ace8287
      Denis Smirnov authored and Dmitry Ivanov's avatar Dmitry Ivanov committed
      
      Previously,
      
      select "t1"."a" from (select "a" from "t") as "t1";
      
      returned a result column name `t1` instead of `t1.a` because of
      incorrect work of a dequoting function. The reason was that
      previously sqlDequote() function finished its work when found the
      first closing quote.
      
      Old logic worked for simple selects where the column name doesn't
      contain an explicit scan name ("a" -> a).
      But for the sub-queries results sqlDequote() finished its work right
      after the scan name ("t1"."a" -> t1). Now the function continues its
      deqouting till it gets the null terminator at the end of the string.
      
      Closes #7063
      
      NO_DOC=don't change any public API, only a bug fix
      
      Co-authored-by: default avatarMergen Imeev <imeevma@gmail.com>
      5ace8287
    • Denis Smirnov's avatar
      sql: recompile expired prepared statements · de6e983a
      Denis Smirnov authored and Dmitry Ivanov's avatar Dmitry Ivanov committed
      Actually there is no reason to throw an error and make a user
      manually recreate prepared statement when it expires. A much more
      user friendly way is to recreate it under hood when statement's
      schema version differs from the box one.
      
      NO_DOC=refactoring
      NO_TEST=refactoring
      NO_CHANGELOG=refactoring
      de6e983a
    • Denis Smirnov's avatar
      fix: default result parameter type · 6aefda71
      Denis Smirnov authored and Dmitry Ivanov's avatar Dmitry Ivanov committed
      Problem description.
      
      When we prepare a statement with parameters in the result columns
      (for example box.prepare('select ?')) Tarantool has no information
      about the type of the output column and set it to default boolean.
      Then, on the execution phase, the type would be recalculated during
      the parameter binding.
      
      Tarantool expects that there is no way for parameter to appear in the
      result tuple other than exactly be mentioned in the final projection.
      But it is incorrect - we can easily propagate parameter from the inner
      part of the join. For example
      
      box.prepare([[select COLUMN_1 from t1 join (values (?)) as t2 on true]])
      
      In this case column COLUMN_1 in the final projection is not a
      parameter, but a "reference" to it and its type depends on the
      parameter from the inner part of the join. But as Tarantool
      recalculates only binded parameters in the result projection,
      it doesn't change the default boolean metadata type of the COLUMN_1
      and the query fails on comparison with the actual type of the tuple.
      
      Solution.
      As we don't want to patch Vdbe to make COLUMN_1 refer inner parameter,
      it was decided to make a simple workaround: change the default
      column type from BOOLEAN to ANY for parameters. It fixes the
      comparison with the actual tuple type (we do not fail), but in some
      cases get ANY column in the results where we would like to have
      explicitly defined type. Also NULL parameters would also have ANY
      type, though Tarantool prefers to have BOOLEAN in this case.
      
      Closes https://github.com/tarantool/tarantool/issues/7283
      
      NO_DOC=bug fix
      6aefda71
    • godzie44's avatar
      sql: add sql_execute_prepared_ext function, same as sql_execute_prepared but... · 4db44efa
      godzie44 authored and Dmitry Ivanov's avatar Dmitry Ivanov committed
      sql: add sql_execute_prepared_ext function, same as sql_execute_prepared but without `region` parameter
      closes #2
      
      NO_DOC=minor
      NO_TEST=minor
      4db44efa
    • godzie44's avatar
      compatibility with tarantool-module: · 4305fee1
      godzie44 authored and Dmitry Ivanov's avatar Dmitry Ivanov committed
      - add box_tuple_data_offset function (return offset of the messagePack encoded data from the beginning of the tuple)
      - add more export functions
      
      closes #1
      
      NO_DOC=build
      NO_TEST=build
      4305fee1
    • Alexey Protsenko's avatar
      build(gitlab): setup all CI · c69c9724
      Alexey Protsenko authored and Dmitry Ivanov's avatar Dmitry Ivanov committed
      Add to .gitlab.ci.yml test_linux, test_debian_docker_luacheck, coverage
      from .travis.mk. Also sign package on build
      Add checkpatch linter.
      Add docker image build. Image copies original tarantool/tarantool from
      Dockerhub
      
      NO_DOC=ci change
      NO_TEST=ci change
      NO_CHANGELOG=ci change
      c69c9724
  2. Nov 22, 2024
  3. Nov 21, 2024
    • Andrey Saranchin's avatar
      sql: do not use raw index for count · 1b12f241
      Andrey Saranchin authored
      Currently, we use raw index for count operation instead of
      `box_index_count`. As a result, we skip a check if current transaction
      can continue and we don't begin transaction in engine if needed. So, if
      count statement is the first in a transaction, it won't be tracked by
      MVCC since it wasn't notified about the transaction. The commit fixes
      the mistake. Also, the commit adds a check if count was successful and
      covers it with a test.
      
      In order to backport the commit to 2.11, space name was wrapped with
      quotes since it is in lower case and addressing such spaces with SQL
      without quotes is Tarantool 3.0 feature. Another unsupported feature is
      prohibition of data access in transactional triggers - it was used in a
      test case so it was rewritten.
      
      Closes #10825
      
      NO_DOC=bugfix
      
      (cherry picked from commit 0656a9231149663a0f13c4be7466d4776ccb0e66)
      1b12f241
  4. Nov 12, 2024
    • Vladimir Davydov's avatar
      test: reduce dump count in vinyl-luatest/select_consistency_test · a2cc2b00
      Vladimir Davydov authored
      The test expects at least 10 dumps to be created in 60 seconds. It
      usually works but sometimes, when the host is heavy loaded, Vinyl
      doesn't produce enough dumps in time and fails the test. On CI the test
      usually fails with 7-9 dumps. To avoid flaky failures, let's reduce the
      expected dump count down to 5.
      
      Closes #10752
      
      NO_DOC=test fix
      NO_CHANGELOG=test fix
      
      (cherry picked from commit 5325abd3441ecb4b589799c32ec181d88724b8a8)
      a2cc2b00
    • Vladimir Davydov's avatar
      vinyl: fix duplicate multikey stmt accounting with deferred deletes · 26a3c8cf
      Vladimir Davydov authored
      `vy_mem_insert()` and `vy_mem_insert_upsert()` increment the row count
      statistic of `vy_mem` only if no statement is replaced, which is
      correct, while `vy_lsm_commit()` increments the row count of `vy_lsm`
      unconditionally. As a result, `vy_lsm` may report a non-zero statement
      count (via `index.stat()` or `index.len()`) after a dump. This may
      happen only with a non-unique multikey index, when the statement has
      duplicates in the indexed array, and only if the `deferred_deletes`
      option is enabled, because otherwise we drop duplicates when we form
      the transaction write set, see `vy_tx_set()`. With `deferred_deletes`,
      we may create a `txv` for each multikey entry at the time when we
      prepare to commit the transaction, see `vy_tx_handle_deferred_delete()`.
      
      Another problem is that `vy_mem_rollback_stmt()` always decrements
      the row count, even if it didn't find the rolled back statement in
      the tree. As a result, if the transaction with duplicate multikey
      entries is rolled back on WAL error, we'll decrement the row count
      of `vy_mem` more times than necessary.
      
      To fix this issue, let's make the `vy_mem` methods update the in-memory
      statistic of `vy_lsm`. This way they should always stay in-sync. Also,
      we make `vy_mem_rollback_stmt()` skip updating the statistics in case
      the rolled back statement isn't present in the tree.
      
      This issue results in `vinyl-luatest/select_consistency_test.lua`
      flakiness when checking `index.len()` after compaction. Let's make
      the test more thorough and also check that `index.len()` equals
      `index.count()`.
      
      Closes #10751
      Part of #10752
      
      NO_DOC=bug fix
      
      (cherry picked from commit e8810c555d4e6ba56e6c798e04216aa11efb5304)
      26a3c8cf
  5. Nov 07, 2024
    • Nikita Zheleztsov's avatar
      upgrade: fix upgrading from schema 1.6.9 · 4e4d4bc1
      Nikita Zheleztsov authored
      This commit fixes some cases of upgrading schema from 1.6.9:
      
      1. Fix updating empty password for users. In 1.6 credentials were array
         in _user, in 1.7.5 they became map.
      
      2. Automatically update the format of user spaces. Format of system
         spaces have been properly fixed during upgrade to 1.7.5. However,
         commit 519bc82e ("Parse and validate space formats") introduced
         strict checking of format field in 1.7.6. So, the format of user
         spaces should be also fixed.
      
      Back in 1.6 days, it was allowed to write anything in space format.
      This commit only fixes valid uses of format:
          {name = 'a', type = 'number'}
          {'a', type = 'number'}
          {'a', 'num'}
          {'a'}
      
      Invalid use of format (e.g. {{}}, or {{5, 'number'}} will cause error
      anyway. User has to fix the format on old version and only after that
      start a new one.
      
      This commit also introduces the test, which checks, that we can
      properly upgrade from 1.6.9 to the latest versions, at least in basic
      cases.
      
      Closes #10180
      
      NO_DOC=bugfix
      
      (cherry picked from commit f69e2ae488b3620e31f1a599d8fb78a66917dbfd)
      4e4d4bc1
  6. Nov 01, 2024
    • Vladimir Davydov's avatar
      test: bump test-run to new version · 28158090
      Vladimir Davydov authored
      Bump test-run to new version with the following improvements:
      
      - Fix a typo [1]
      - Follow-up fix for parsing non-utf8 chars (part 2) [2]
      - Bump luatest to 1.0.1-33-g7dc5cb7 [3]
      
      [1] tarantool/test-run@5d9630b
      [2] tarantool/test-run@7acc532
      [3] tarantool/test-run@dc2382c
      
      NO_DOC=test
      NO_TEST=test
      NO_CHANGELOG=test
      
      (cherry picked from commit 0afc7e0b8a57678c589a2e9de6785d99f17e30eb)
      28158090
    • Andrey Saranchin's avatar
      memtx: fix use-after-free on background index build · a4456c10
      Andrey Saranchin authored
      When building an index in background, we create on_rollback triggers for
      tuples inserted concurrently. The problem here is on_rollback trigger
      has independent from `index` and `memtx_ddl_state` lifetime - it can be
      called after the index was build (and `memtx_ddl_state` is destroyed)
      and even after the index was altered. So, in order to avoid
      use-after-free in on_rollback trigger, let's drop all on_rollback
      triggers when the DDL is over. It's OK because all owners of triggers
      are already prepared, hence, in WAL or replication queue (since we
      build indexes in background only without MVCC so the transactions cannot
      yield), so if they are rolled back, the same will happen to the DDL.
      
      In order to delete on_rollback triggers, we should collect them into a
      list in `memtx_ddl_state`. On the other hand, when the DML statement is
      over (committed or rolled back), we should delete its trigger from the
      list to prevent use-after-free. That's why the commit adds the on_commit
      trigger to background build process.
      
      Closes #10620
      
      NO_DOC=bugfix
      
      (cherry picked from commit d8d82dba4c884c3a7ad825bd3452d35627c7dbf4)
      a4456c10
    • Yaroslav Lobankov's avatar
      test: use `justrun` module from luatest · f0bcd78b
      Yaroslav Lobankov authored
      NO_DOC=test
      NO_TEST=test
      NO_CHANGELOG=test
      
      (cherry picked from commit 90d197ded13d49dfc405ff80bbd183b2e260dc56)
      f0bcd78b
    • Yaroslav Lobankov's avatar
      test: use `treegen` module from luatest · e8b0dcf6
      Yaroslav Lobankov authored
      Also, adapt tests and helpers in accordance with the module interface.
      
      NO_DOC=test
      NO_TEST=test
      NO_CHANGELOG=test
      
      (cherry picked from commit bd27df009c403e89c003d5b66763c0f0bbf08440)
      e8b0dcf6
    • Yaroslav Lobankov's avatar
      test: bump test-run to new version · 3badd27f
      Yaroslav Lobankov authored
      Bump test-run to new version with the following improvements:
      
      - ignore local lsn in wait_cluster_vclock [1]
      - Bump luatest to 1.0.1-20-ga978383 [2]
      - Bump luatest to 1.0.1-22-g39da6d2 [3]
      
      [1] tarantool/test-run@f23b535
      [2] tarantool/test-run@274e4f3
      [3] tarantool/test-run@d04c595
      
      NO_DOC=test
      NO_TEST=test
      NO_CHANGELOG=test
      
      (cherry picked from commit beba449a5f04e02fb77ca676663b1836e0490c3d)
      3badd27f
    • Serge Petrenko's avatar
      test: bump test-run to new version · 64bbd9e2
      Serge Petrenko authored
      Bump test-run to new version with the following improvements:
      
      - Follow-up fix for parsing non-utf8 chars [1]
      
      [1] tarantool/test-run@52d3e4f
      
      NO_CHANGELOG=test
      NO_TEST=test
      NO_DOC=test
      
      (cherry picked from commit e01c20edc31b65e020ac57e3f62a7427b6e27d53)
      64bbd9e2
    • Serge Petrenko's avatar
      test: fix several more tests after the luatest bump · 9dfd78d8
      Serge Petrenko authored
      The test gh_10088 was committed in parallel with the luatest bump and
      thus slipped from the post-bump tests fixup in commit cfd4bf46
      ("test: adapt tests to the new luatest version"). Fix it now.
      
      Also tests gh_6539 and gh_7231 queried `box.cfg.log` wrongly, but this
      didn't make them fail, they just stopped testing what they were supposed
      to. Fix them as well
      
      NO_CHANGELOG=test
      NO_TEST=test
      NO_DOC=test
      
      (cherry picked from commit 2a18de391895d8ec7a39e3d3dcee659fe79f7bc9)
      9dfd78d8
    • Oleg Chaplashkin's avatar
      test: adapt tests to the new luatest version · 3d80ea0e
      Oleg Chaplashkin authored
      With the new version of Luatest you have to be careful with the server
      log file. We used to get it very simply:
      
          box.cfg.log
      
      Now it is more correct to use the following approach:
      
          rawget(_G, 'box_cfg_log_file') or box.cfg.log
      
      Closes tarantool/test-run#439
      
      NO_DOC=test
      NO_TEST=test
      NO_CHANGELOG=test
      
      (cherry picked from commit cfd4bf46)
      3d80ea0e
    • Nikita Zheleztsov's avatar
      test: bump test-run to new version · 098397e3
      Nikita Zheleztsov authored
      Bump test-run to new version with the following improvements:
      
      - luatest: fix ability to run a test several times [1]
      - Enable luatest logging [2]
      - tap13: fix parsing non-utf8 chars [3]
      
      [1] tarantool/test-run@240cdea
      [2] tarantool/test-run@b8b60b4
      [3] tarantool/test-run@7290540
      
      NO_DOC=test
      NO_TEST=test
      NO_CHANGELOG=test
      
      (cherry picked from commit 59ba2131)
      098397e3
  7. Oct 31, 2024
    • Andrey Saranchin's avatar
      luafun: bump submodule · 58f3e1df
      Andrey Saranchin authored
      The commit bumps luafun to the new version with a bunch of bugfixes:
      * Now `chain` works correctly with iterators without `param`.
      * Now `drop_while` supports stateful iterators.
      * The module is populated with missing `maximum_by` alias of `max_by`.
      * Now `nth` and `length` work correctly with other luafun iterators.
      
      Since our index iterators are stateful (can return different values
      with the same `state` passed), the old `drop_while` implementation
      didn't work well with them - it was skipping an extra element.
      The bump resolves this issue.
      
      Note that there are still methods that don't work correctly with
      `index:pairs` - `cycle`, `head` and `is_null`.
      
      Closes #6403
      
      NO_DOC=bugfix
      
      (cherry picked from commit ec758869f8364624efaff58bdd4ebc7c133ede0a)
      58f3e1df
  8. Oct 30, 2024
    • Sergey Bronnikov's avatar
      cmake: fix build with GCC's UBSan · e13c7ed2
      Sergey Bronnikov authored
      GNU GCC compiler has UndefinedBehaviour sanitizer support since
      4.9.0 [1], but it was unsupported in tarantool's build. The patch
      fixes a build by GNU GCC with enabled UBSan.
      
      1. https://gcc.gnu.org/gcc-4.9/changes.html
      
      NO_CHANGELOG=build
      NO_DOC=build
      NO_TEST=build
      
      (cherry picked from commit 511e0f50e4b817d576ef4001611fba718ef1bdae)
      e13c7ed2
    • Sergey Bronnikov's avatar
      cmake: enable UBSan check signed-integer-overflow · 2f28137b
      Sergey Bronnikov authored
      The patch enable UBsan check signed-integer-overflow that was
      disabled globally in commit 5115d9f3
      ("cmake: split UB sanitations into separate flags.") and disable
      it for a several functions inline.
      
      See also #10703
      See also #10704
      Closes #10228
      
      NO_CHANGELOG=codehealth
      NO_DOC=codehealth
      NO_TEST=codehealth
      
      (cherry picked from commit 60ba7fb4c0038d9d17387f7ce9755eb587ea1da4)
      2f28137b
    • Sergey Bronnikov's avatar
      cmake: enable UBsan checks · 31b7fd60
      Sergey Bronnikov authored
      The following UBSan checks have been enabled back:
      
      - vptr
      - implicit-signed-integer-truncation
      - implicit-integer-sign-change
      - nullability-arg
      - nullability-assign
      - nullability-return
      - returns-nonnull-attribute
      
      These checks doesn't trigger errors anymore and no sense to keep
      them disabled.
      
      Part of #10228
      Related to #10741
      Related to #10740
      
      NO_CHANGELOG=codehealth
      NO_DOC=codehealth
      NO_TEST=codehealth
      
      (cherry picked from commit e65b63df7f5a8a628cd9a9bbc6a1bdecec8c9959)
      31b7fd60
    • Sergey Bronnikov's avatar
      cmake: replace UBsan flags whitelist by blacklist · f3d27729
      Sergey Bronnikov authored
      The commit 366cb668 ("cmake: add option ENABLE_UB_SANITIZER")
      added UndefinedBehaviour sanitizer support with the whitelist of
      checks (all checks are disabled and a several checks are
      enabled). The patch replaces the whitelist by blacklist (all
      checks are enabled and a several checks are disabled).
      
      Part of #10228
      Related to #10742
      
      NO_CHANGELOG=codehealth
      NO_DOC=codehealth
      NO_TEST=codehealth
      
      (cherry picked from commit 2125a4304844669884bfa887657fd20f15504a5a)
      f3d27729
  9. Oct 28, 2024
    • Andrey Saranchin's avatar
      memtx: clarify tuples against given index in memtx_tx_snapshot_cleaner · c5b11266
      Andrey Saranchin authored
      Currently, we create `memtx_tx_snapshot_cleaner` for each index in read
      view. However, we somewhy clarify all tuples against primary index in
      all cleaners. As a result, secondary indexes work incorrectly in read
      view when MVCC is enabled, we may even get a tuple with one key, but
      a tuple with another key will be returned because it is clarified
      against primary index and repsects its order - that's wrong because
      all indexes have its own orders. Let's clarify tuples against given
      index to fix this mistake.
      
      Community Edition is not affected at all since it uses read view only
      for making a snapshot - we use only primary indexes there.
      
      Part of tarantool/tarantool-ee#939
      
      NO_TEST=in EE
      NO_CHANGELOG=in EE
      NO_DOC=bugfix
      
      (cherry picked from commit 835fadd)
      c5b11266
  10. Oct 23, 2024
    • Nikolay Shirokovskiy's avatar
      box: build fix · 312dbf07
      Nikolay Shirokovskiy authored
      I got compile error for release build on gcc 14.2.1 20240910 version.
      
      ```
      In function ‘char* mp_store_double(char*, double)’,
          inlined from ‘char* mp_encode_double(char*, double)’ at /home/shiny/dev/tarantool-ee/tarantool/src/lib/msgpuck/msgpuck.h:2409:24,
          inlined from ‘uint32_t tuple_hash_field(uint32_t*, uint32_t*, const char**, field_type, coll*)’ at /home/shiny/dev/tarantool-ee/tarantool/src/box/tuple_hash.cc:317:46:
      /home/shiny/dev/tarantool-ee/tarantool/src/lib/msgpuck/msgpuck.h:340:16: error: ‘value’ may be used uninitialized [-Werror=maybe-uninitialized]
        340 |         cast.d = val;
            |         ~~~~~~~^~~~~
      /home/shiny/dev/tarantool-ee/tarantool/src/box/tuple_hash.cc: In function ‘uint32_t tuple_hash_field(uint32_t*, uint32_t*, const char**, field_type, coll*)’:
      /home/shiny/dev/tarantool-ee/tarantool/src/box/tuple_hash.cc:311:24: note: ‘value’ was declared here
        311 |                 double value;
            |
      ```
      
      NO_TEST=build fix
      NO_CHANGELOG=build fix
      NO_DOC=build fix
      
      (cherry picked from commit 1129c758d0e3bd86eec89e5229eac3f99155d8ac)
      312dbf07
  11. Oct 18, 2024
    • Sergey Kaplun's avatar
      luajit: bump new version · 4019956f
      Sergey Kaplun authored
      * Fix typo.
      * OSX/iOS: Always generate 64 bit non-FAT Mach-O object files.
      * test: don't run JIT-based LuaJIT tests without JIT
      * test: actualize <LuaJIT-tests/README.md>
      * test: enable <misc/alias_alloc.lua> LuaJIT test
      * test: refactor <alias_alloc.lua> LuaJIT test
      * test: refactor <lang/coroutine.lua> LuaJIT test
      * test: remove <misc/coro_yield.lua> LuaJIT test
      * test: enable <misc/debug_gc.lua> LuaJIT test
      * test: enable <misc/dualnum.lua> LuaJIT test
      * test: refactor <lang/dualnum.lua> LuaJIT test
      * test: remove <misc/fori_coerce.lua> LuaJIT test
      * test: remove <misc/fori_dir.lua> LuaJIT test
      * test: remove <misc/gc_rechain.lua> LuaJIT test
      * test: enable <misc/gc_trace.lua> LuaJIT test
      * test: refactor <trace/gc.lua> LuaJIT test
      * test: enable <misc/gcstep.lua> LuaJIT test
      * test: enable <misc/hook_active.lua> LuaJIT test
      * test: enable <misc/hook_line.lua> LuaJIT test
      * test: enable <misc/hook_norecord.lua> LuaJIT test
      * test: enable <misc/hook_record.lua> LuaJIT test
      * test: enable <misc/hook_top.lua> LuaJIT test
      * test: enable <misc/jit_flush.lua> LuaJIT test
      * test: remove <misc/loop_unroll.lua> LuaJIT test
      * test: enable <misc/parse_comp.lua> LuaJIT test
      * test: enable <misc/parse_esc.lua> LuaJIT test
      * test: enable <misc/parse_misc.lua> LuaJIT test
      * test: enable <misc/phi_conv.lua> LuaJIT test
      * test: refactor <trace/phi/conv.lua> LuaJIT test
      * test: enable <misc/recurse_deep.lua> LuaJIT test
      * test: remove <misc/recurse_tail.lua> LuaJIT test
      * test: enable <misc/stack_gc.lua> LuaJIT test
      * test: refactor <lang/gc_stack.lua> LuaJIT test
      * test: enable <misc/stack_purge.lua> LuaJIT test
      * test: refactor <trace/stack_purge.lua> LuaJIT test
      * test: enable <misc/stackov.lua> LuaJIT test
      * test: enable <misc/stackovc.lua> LuaJIT test
      * test: enable <misc/tcall_base.lua> LuaJIT test
      * test: refactor <trace/tcall_base.lua> LuaJIT test
      * test: enable <misc/tcall_loop.lua> LuaJIT test
      * test: enable <misc/tonumber_scan.lua> LuaJIT test
      * test: remove <misc/uclo.lua> LuaJIT test
      * test: enable <misc/unordered_jit.lua> LuaJIT test
      * test: enable <misc/wbarrier.lua> LuaJIT test
      * test: enable <misc/wbarrier_jit.lua> LuaJIT test
      * test: enable <misc/wbarrier_obar.lua> LuaJIT test
      * test: update <LuaJIT-tests/README.md>
      * test: off JIT for routines in <lang/stackov.lua>
      * Limit number of string format elements to compile.
      * Clear stack after print_jit_status() in CLI.
      * FFI: Workaround for platform dlerror() returning NULL.
      * test: move profilers tests to subdirectory
      * test: rename <arm64-ccall-fp-convention.test.lua>
      * cmake: introduce AppendTestEnvVar macro
      * test: shrink LUA_PATH environment variable
      * test: shrink LUA_CPATH and {DY}LD_LIBRARY_PATH
      * test: skip flaky tests with enabled table bump
      * test: set LD_PRELOAD only when necessary
      * test: fix misclib-getmetrics-lapi.test.lua
      * FFI: Fix __tostring metamethod access to enum cdata value.
      * Fix limit check in narrow_conv_backprop().
      * FFI: Drop finalizer table rehash after GC cycle.
      * Drop unused function wrapper.
      * FFI: Fix various issues in recff_cdata_arith.
      * Add missing coercion when recording select(string, ...)
      * Fix stack allocation after on-trace stack check.
      * Restore state when recording __concat metamethod throws an error.
      * Fix bit op coercion in DUALNUM builds.
      * FFI: Fix 64 bit shift fold rules.
      * Limit CSE for IR_CARG to fix loop optimizations.
      
      Closes #10290
      Closes #10199
      Closes #9898
      Part of #9398
      
      NO_DOC=LuaJIT submodule bump
      NO_TEST=LuaJIT submodule bump
      4019956f
Loading