- Sep 28, 2023
-
-
Pavel Balaev authored
luarocks version updated to version 3.9.2 Closes #6597 NO_DOC=The engine has been updated, the functionality has not changed NO_TEST=see NO_DOC
-
Oleg Babin authored
Before this patch if one called `vinyl`, `sql`, `gc` and `memory` functions from box.info() instance crashed. It's interesting that `replication_anon` functions worked ok. This patch fixes that crashes. Closes #9173 NO_DOC=bugfix
-
Alexander Turenko authored
Part of https://github.com/tarantool/tarantool-ee/issues/564 NO_DOC=The documentation request is to be added as part of Tarantool Enterprise Edition patchset. NO_CHANGELOG=see NO_DOC NO_TEST=To be tested in Tarantool Enterprise Edition.
-
Alexander Turenko authored
This message doesn't give any useful information for `tarantool --failover` run, because it always starts background fibers for monitoring purposes. Let's suppress the message in the case. Part of https://github.com/tarantool/tarantool-ee/issues/564 NO_DOC=It is a small visual improvement, there is nothing to document here. NO_CHANGELOG=It is part of Tarantool Enterprise Edition feature. NO_TEST=Doesn't worth it.
-
Alexander Turenko authored
The option enables a built-in failover coordinator script, which reads a configuration from a file (pointed by --config option) or from etcd, connects to all the instances, polls them for their status and performs automatic actions to ensure that there is an active leader in each replicaset (if possible). The failover coordinator code is part of Tarantool Enterprise Edition. Part of https://github.com/tarantool/tarantool-ee/issues/564 NO_DOC=The documentation request is to be added as part of Tarantool Enterprise Edition patchset. NO_CHANGELOG=see NO_DOC NO_TEST=To be tested in Tarantool Enterprise Edition.
-
Alexander Turenko authored
It allows to reuse the code that collects the cluster configuration without checks against particular instance name. Part of https://github.com/tarantool/tarantool-ee/issues/564 NO_DOC=refactoring NO_CHANGELOG=see NO_DOC NO_TEST=see NO_DOC
-
Alexander Turenko authored
I want to use it outside of the configdata code. It seems appropriate to expose it from the instance config schema, because it is a general purpose transformation of instance config data. Part of https://github.com/tarantool/tarantool-ee/issues/564 NO_DOC=refactoring NO_CHANGELOG=see NO_DOC NO_TEST=see NO_DOC
-
Serge Petrenko authored
Our split-brain detection machinery relies among other things on all nodes tracking the synchro queue confirmed lsn. This tracking was only added together with the split-brain detection. Only the synchro queue owner tracked the confirmed lsn before. This means that after an upgrade all the replicas remember the latest confirmed lsn as 0, and any PROMOTE/DEMOTE request from the queue owner is treated as a split brain. Let's fix this and only enable split-brain detection on the replica set once the schema version is updated. Thanks to the synchro queue freeze on restart, this can only happen after a new PROMOTE or DEMOTE entry is written by one of the nodes, and thus the correct confirmed lsn is propagated with this PROMOTE/DEMOTE to all the cluster members. Closes #8996 NO_DOC=bugfix
-
- Sep 27, 2023
-
-
Mergen Imeev authored
This patch introduces a new CLI option: --force-recovery. Closes #8876 @TarantoolBot document Title: --force-recovery CLI option The --force-recovery CLI option is another way to set the box.cfg{} force_recovery option. The priority of this option is higher than the priority of the TT_FORCE_RECOVERY environment variable, but less than the priority of explicitly setting the box.cfg{} force_recovery option.
-
Igor Munkin authored
* test: fix fix-mips64-spare-side-exit-patching * test: fix `fillmcode()` generator helper * MIPS: Fix "bad FP FLOAD" assertion. * Handle table unsinking in the presence of IRFL_TAB_NOMM. * Fix handling of instable types in TNEW/TDUP load forwarding. * Fix frame for more types of on-trace error messages. * Fix frame for on-trace out-of-memory error. * Fix predict_next() in parser (again). * Always exit after machine code page protection change fails. Closes #562 Part of #8825 NO_DOC=LuaJIT submodule bump NO_TEST=LuaJIT submodule bump
-
- Sep 26, 2023
-
-
Vladimir Davydov authored
Allocations from fiber region and heap should never fail so it's okay to use xmalloc for them. This fixes the following coverity report complaining about unchecked region_alloc result: https://scan7.scan.coverity.com/reports.htm#v39198/p13437/fileInstanceId=149497639&defectInstanceId=19021351&mergedDefectId=1525560 NO_DOC=refactoring NO_TEST=refactoring NO_CHANGELOG=refactoring
-
Vladimir Davydov authored
The goal of this patch is to make the xlog writer API less confusing. It does the following changes: - Rename xlog_rename to xlog_materialize. The function strips the .inprogress suffix from an xlog file name. Usually it's called after the xlog was sealed (by writing the EOF marker) and closed but it may also be called before xlog_close in case the xlog file is going to be appended to (used in WAL). - Make xlog_sync private. It's called by xlog_close so there's no point in calling it manually. Make xlog_close fail if it fails to sync the file. - Make xlog_close flush the buffer so that the caller doesn't need to call xlog_flush manually before closing an xlog file. - Drop the reuse_fd argument of xlog_close. Instead, introduce a new function xlog_close_reuse_fd that works exactly like xlog_close except it doesn't close the fd and returns it in the out argument. - Introduce xlog_discard. It's supposed to be called on an incomplete xlog file to close its fd and unlink it. Rework all the places where we write xlog files in accordance with the new API. Note about memtx snapshot writer: use xlog_materialize and xlog_discard instead of coio_rename and coio_unlink. The new API (especially the xlog_discard helper) facilitates introduction of thorough (secure) file deletion because it significantly reduces the number of places in the code where xlog files are deleted. Needed for tarantool/tarantool-ee#540 NO_DOC=refactoring NO_TEST=refactoring NO_CHANGELOG=refactoring
-
- Sep 22, 2023
-
-
Alexander Turenko authored
The goal of the script is to assist with removing changelog entries that are already included into a release of another development branch. For example, if a bug fix is released as part of 2.11.3, there is no reason to highlight that it is fixed in 3.0.0. It is better to describe changes comparing to the latest present 2.11 release. The script was initially written for personal use and there are obvious points for improvements. However, it seems that it already simplifies some tasks, so I'm going to share it as is and improve later. I'll leave the relevant issue open. Part of #9135 NO_DOC=The commit adds a development tool and doesn't touch anything in tarantool itself. NO_CHANGELOG=see NO_DOC NO_TEST=see NO_DOC
-
Nikolay Shirokovskiy authored
Proposed ASAN implementation of region allocator does not support double reservation for the sake of simplicity. Every reservation is supposed to be followed by one or more allocations. This restiction does not work well with mpstream currently. The issue is mpstream_init/mpstream_reserve do reservation of size 0. For example In case of region slab of min order is reserved (a chunk of memory of page size currently). If the first data we want to write to mpstream is larger then the reservation done then we make reservation again. Let's get rid of this reservation at the beginning as it is suboptimal behaviour. Moreover let's get rid of mpstream_reset as mpstream_init is lightweight and we can create a new mpstream instead of reusing exiting. Also while we at it avoid allocation of 0 size in mpstream_flush as it is done in mpstream_reserve_slow (see 3.0.0-alpha3-19-g8159347d0 "misc: avoid allocations of size 0 for region" for details). NO_TEST=internal NO_CHANGELOG=internal NO_DOC=internal
-
- Sep 21, 2023
-
-
Sergey Vorontsov authored
Download the readline and libiconv archives from the backup storage to avoid network issues with accessing https://ftp.gnu.org in the future. NO_DOC=build NO_TEST=build NO_CHANGELOG=build
-
Nikolay Shirokovskiy authored
Regular region implementation supports allocations of size 0 with no extra efforts. It returns a non-NULL pointer in this case. However in case of ASAN friendly implementation it will require a special care for this case. Instead let's avaid allocations if size 0 for region. Also use xregion_ macros for allocations. Our current policy is to panic on OOM on runtime allocations. Part of tarantool/tarantool#7327 NO_TEST=internal NO_CHANGELOG=internal NO_DOC=internal
-
Vladimir Davydov authored
When a replica is restarted, it doesn't immediately switch to the 'follow' state. First it needs to sync. Let's wait for the 'follow' state a bit to fix the following failure: NO_WRAP [039] replication-luatest/gh_9049_schema_downgrade_t> [ fail ] [039] Test failed! Output from reject file /tmp/t/rejects/replication-luatest/gh_9049_schema_downgrade.reject: [039] Tarantool version is 3.0.0-alpha3-18-g6892907bad9d [039] TAP version 13 [039] 1..1 [039] # Started on Thu Sep 21 13:55:09 2023 [039] # Starting group: replication-luatest.gh_9049_schema_downgrade [039] not ok 1 replication-luatest.gh_9049_schema_downgrade.test_schema_downgrade [039] # ...st/replication-luatest/gh_9049_schema_downgrade_test.lua:33: expected: "follow" [039] # actual: "sync" [039] # stack traceback: [039] # ...st/replication-luatest/gh_9049_schema_downgrade_test.lua:31: in function 'replication-luatest.gh_9049_schema_downgrade.test_schema_downgrade' [039] # ... [039] # [C]: in function 'xpcall' [039] # artifacts: [039] # replica -> /tmp/t/039_replication-luatest/artifacts/replica-AgoXGWUXxvnc [039] # master -> /tmp/t/039_replication-luatest/artifacts/master-ZUTtyXyAX9YF [039] # Ran 1 tests in 1.768 seconds, 0 succeeded, 1 failed NO_WRAP Fixes commit 71de4b2c ("box: fix schema downgrade replication"). NO_DOC=test fix NO_CHANGELOG=test fix
-
- Sep 20, 2023
-
-
Vladimir Davydov authored
The new option is backed by `box.cfg.auth_retries`. It is available only in Enterprise Edition builds. Needed for tarantool/tarantool-ee#541 NO_DOC=will be added to Enterprise Edition NO_CHANGELOG=will be added to Enterprise Edition
-
- Sep 19, 2023
-
-
Vladimir Davydov authored
Required to suppress the ASAN leak detector. Closes #9158 NO_DOC=ASAN NO_TEST=ASAN NO_CHANGELOG=ASAN
-
- Sep 18, 2023
-
-
Gleb Kashkin authored
Before this patch credentials applier used to just skip if Tarantool was in Read Only mode. Now it starts a fiber that waits for instance to be switched to Read Write mode and then applies in the background. Part of #8967 NO_DOC=documentation request will be filed manually for the whole credentials
-
Vladimir Davydov authored
We decided not to merge entries from Tarantool CE changelog to Tarantool EE changelog. Instead we now add a link to CE release notes to EE release notes. Update the script accordingly. NO_DOC=tools NO_TEST=tools NO_CHANGELOG=tools
-
Ilya Verbin authored
If MP_ERROR map contains two MP_ERROR_STACK keys, then the second call to `error_set_prev(effect, cur)' will crash, because `effect' is NULL, but `err == NULL' is false, because it is assigned on the first iteration. This patch raises an error if more than one MP_ERROR_STACK key is present. NO_DOC=bugfix Closes #9136
-
Magomed Kostoev authored
Wraps multistatement DDL functions into begin/commit block if no transaction is active. The functions are: - `box.schema.space.drop` - `box.schema.index.create` - `box.schema.index.drop` - `box.schema.index.alter` - `box.schema.sequence.drop` - `box.schema.func.drop` - `box.schema.user.create` - `box.schema.user.drop` - `box.schema.role.drop` Added tests for atomicity of each transactioned function except the `box.schema.role.drop`, which is implicitly tested with the `box.schema.user.drop` test, and the `box.schema.index.drop`, which is impossible to test in this flavor without using error injection. Updated the tests modified in tarantool/tarantool#8947, because the space drop is atomic now. Closes #4348 NO_DOC=bugfix
-
Magomed Kostoev authored
Sequences can only be attached to integer fields of a space. The corresponding check is done in both schema.lua and alter.cc. The problem is that in order to make the index alter transactional, we have to perform the `_index` space tuple replace before the existed sequence is unattached from the space (because the index alter may be yielding). And the check existing in the alter.cc won't allow us to do that in some cases. Since the check already exists in `box.schema.index.alter`, it's decided to drop it from the `_index` `on_replace` trigger. The downside of the solution is that uncareful manual altering the index can silently put the space into an inconsistent condition: the next insert into the space can either fail or silently succeed whereas it's not supposed operation for the space. Example: ```lua box.cfg{} s = box.schema.space.create('s') pk = s:create_index('pk', {parts = {{1, 'unsigned'}}, sequence = true}) -- Manual altering the index without dropping the sequence. box.space._index:update({s.id, pk.id}, {{'=', 6, {{0, 'string'}}}}) -- This will fail: passed integer (from sequence) in string field. s:insert({box.NULL}) -- Manual altering the index without dropping the sequence again. box.space._index:update({s.id, pk.id}, {{'=', 6, {{0, 'scalar'}}}}) -- This will succeed: passed integer (from sequence) in scalar field. -- Though it shouldn't have been done at all: one should not pass -- NULL in the field which is indexed by the primary key. s:insert({box.NULL}) ``` NO_DOC=no visible changes NO_TEST=no visible changes NO_CHANGELOG=no visible changes
-
Magomed Kostoev authored
Before this commit disable of functional index caused index rebuild which does not allow the box.schema.space.drop function to be atomic. Since effectively the disabled functional index rebuild is a no-op, the "rebuild" step was omitted and effective changes are applied instead. NO_TEST=no functional changes NO_DOC=no functional changes NO_CHANGELOG=no functional changes
-
- Sep 15, 2023
-
-
Yaroslav Lobankov authored
This patch is intended to resolve the following issue that appears while calling `cmake` for submodules from time to time: fatal: No tags can describe '<sha>'. Try --always, or create some tags. This happens because the `actions/checkout` GitHub action fetches the repository with the `--unshallow` option, but it doesn't do the same for submodules. So this leads to the error above while using `git describe` for submodules. This is fixed by converting a shallow submodule to a complete one. NO_DOC=ci NO_TEST=circuit NO_CHANGELOG=ci
-
- Sep 14, 2023
-
-
Sergey Bronnikov authored
The patch updates curl module to the version 8.3.0 [1] and updates a CMake module for building curl library. Changes in CMake module: - Option `CURL_STATICLIB` is gone and replaced with `BUILD_STATIC_LIBS`. - Option `CURL_USE_GNUTLS` was added and disabled by default. - NSS library support was removed and option `CURL_USE_NSS` has been removed as well. - Option `CMAKE_UNITY_BUILD` was added and disabled by default. - Option `CURL_DISABLE_FORM_API` was added and disabled by default. It is in fact depends on `CURL_DISABLE_MIME`, but anyway disabled explicitly. Changelog: https://curl.se/changes.html#8_3_0 1. https://github.com/curl/curl/releases/tag/curl-8_3_0 NO_DOC=libcurl submodule bump NO_TEST=libcurl submodule bump Fixes #9086
-
- Sep 13, 2023
-
-
Andrey Saranchin authored
The commit populates submodule session with an event for each public trigger - they will be used for user-defined triggers. Old triggers are not removed because they are used for internal purposes - audit from EE uses them, for instance. Also, the commit introduces a test for all triggers that use old API. It checks only session triggers now - all the other triggers will be included there after they will be moved to the trigger registry. In order to have an opportunity to move user-defined triggers to trigger registry, the commit introduces helper luaT_event_reset_trigger that supports two different ways to set triggers - key-value API and positional API. The first one is a new API that allows to set or delete trigger only by name. The second API is implemented for the sake of backward compatibility - it mimics behavior of function lbox_trigger_reset, which was used to modify triggers, but sets the triggers to event from trigger registry instead of separate trigger list. Also, positional API allows to pass a name as the third argument - in this case the function will set or delete trigger by passed name - the first argument is a new trigger (or nil, if the function is called to delete a trigger), the second argument will be ignored in this case. The new helper supports not only functions - any callable object can be used as a trigger. Part of #6484 Part of #8657 NO_CHANGELOG=later NO_DOC=later
-
Andrey Saranchin authored
Sql fuzzer uses box module depending on event subsystem, which was not initialized by mistake. It didn't cause any problems because box does not use events yet, but it will use them when triggers will be moved to the trigger registry, so let's initialize event in sql fuzzer. Part of #8657 NO_CHANGELOG=test NO_DOC=test
-
Andrey Saranchin authored
Boolean type is required by box.session.on_auth triggers. Part of #8657 NO_CHANGELOG=internal NO_DOC=internal
-
Vladimir Davydov authored
With this patch, mp_check sets diag with detailed information about the MsgPack decoding error. The diag includes the error reason, which is appended to the error message, and the data offset, which is stored in an error payload field. Possible error reasons are: truncated input, junk after input, illegal code, invalid extension. In case of truncated input, the error also includes the trunc_count payload field, which is set to the number of missing MsgPack values. Failing to decode a MsgPack extension adds two payload fields, ext_type and ext_len, and also an error cause, which is set by the extension decoder. For all extensions except the error extension, the error cause is just "cannot unpack FOO". For the error extension, it includes a detailed cause pointing to the error in the MsgPack data stored in the extension. Currently, the mp_check error is reported only by the Lua msgapck decoder while other mp_check users (e.g. xrow decoder) override it. We may improve on this in future. Examples: tarantool> require('msgpack').decode('\x94\xc0') --- - error: Invalid MsgPack - truncated input ... tarantool> box.error.last():unpack() --- - offset: 2 code: 20 base_type: ClientError type: ClientError trunc_count: 3 message: Invalid MsgPack - truncated input trace: - file: ./src/box/msgpack.c line: 151 ... tarantool> require('msgpack').decode(string.char( > 130, 39, 170, 114, 101, 116, 117, 114, 110, 32, 46, > 46, 46, 33, 145, 199, 74, 3, 129, 0, 145, 134, > 0, 171, 67, 108, 105, 101, 110, 116, 69, 114, 114, > 111, 114, 1, 170, 99, 111, 110, 102, 105, 103, 46, > 108, 117, 97, 2, 211, 0, 0, 0, 0, 0, 0, > 0, 201, 3, 173, 85, 110, 107, 110, 111, 119, 110, > 32, 101, 114, 114, 111, 114, 4, 211, 0, 0, 0, > 0, 0, 0, 0, 0, 5, 211, 0, 0, 0, 0, > 0, 0, 0, 0)) --- - error: Invalid MsgPack - invalid extension ... tarantool> box.error.last():unpack() --- - code: 20 base_type: ClientError prev: Invalid MsgPack - cannot unpack error message: Invalid MsgPack - invalid extension ext_len: 74 ext_type: 3 trace: - file: ./src/box/msgpack.c line: 161 type: ClientError offset: 18 ... tarantool> box.error.last().prev:unpack() --- - code: 20 base_type: ClientError type: ClientError prev: Invalid MsgPack - MP_ERROR_LINE value must be MP_UINT message: Invalid MsgPack - cannot unpack error trace: - file: ./src/box/msgpack.c line: 126 ... tarantool> box.error.last().prev.prev:unpack() --- - offset: 30 code: 20 base_type: ClientError type: ClientError message: Invalid MsgPack - MP_ERROR_LINE value must be MP_UINT trace: - file: ./src/box/mp_error.cc line: 350 ... Closes #7968 NO_DOC=error reporting improvement
-
Vladimir Davydov authored
Just use xmalloc for allocating exception objects. NO_DOC=refactoring NO_TEST=refactoring NO_CHANGELOG=refactoring
-
Vladimir Davydov authored
This update pulls the following commit: * Introduce mp_check_exact helper function Needed for #7968 NO_DOC=internal NO_CHANGELOG=internal NO_TEST=submodule update
-
- Sep 12, 2023
-
-
Sergey Bronnikov authored
The patch adds a fuzzing test for IPROTO decoding function xrow_decode_error(). Follows up #8921 Follows up #9098 NO_DOC=testing NO_CHANGELOG=testing
-
Kirill Yukhin authored
NO_DOC=no code changes NO_TEST=no code changes NO_CHANGELOG=no code changes
-
Vladimir Davydov authored
Some downgrade operations are performed with disabled system space triggers because they were prohibited recently (creation of SQL built-in functions) or never allowed (dropping a system space). This works fine on the instance running downgrade but apparently fails on replicas. To fix this issue, let's disable the checks the operations that prevent downgrade in the following scenarios: - in the fiber that is currently running a schema upgrade or downgrade; - in the applier fiber so that it can replicate changes done by upgrade or downgrade on the master; - during recovery so that DDL records written to the WAL can be replayed. We already have all the necessary infrastructure in-place - we use it for allowing DDL operations with an old schema for upgrade. Closes #9049 NO_DOC=bug fix
-
Pavel Semyonov authored
Remove issues released in 2.11.1 from master (3.0.0-alpha3) NO_CHANGELOG=changelog NO_DOC=changelog NO_TEST=changelog
-
- Sep 11, 2023
-
-
Ilya Verbin authored
If `strlen(name)` is 1, `value_size` is 1, and `extra` is 0, then 15 bytes are allocated for `struct error_field` in error_payload_prepare(). However, the size of this structure is 16 because of the padding for the alignment. Thus TRASH() in error_payload_destroy() writes 1 byte beyond the structure. Closes #9098 NO_DOC=bugfix
-
- Sep 08, 2023
-
-
Sergey Bronnikov authored
The patch adds a fuzzing test for IPROTO decoding function xrow_header_decode(). NO_DOC=testing NO_CHANGELOG=testing
-
Mergen Imeev authored
This patch introduces initial support for roles. Dependencies are not currently supported for roles. Part of #9078 @TarantoolBot document Title: Roles Two new options have been added: "roles" and "roles_cfg". The first one is an array and the second one is a map. Each of these can be defined per instance, replica set, group, and globally. As with almost all other options, with the exception of those defined as 'map', the 'roles' option for the lower scope will replace the roles for the higher scope. Value roles_cfg however defined as "map", so it will be merged. The "roles" option defines the roles for each instance. A role is a program that runs when a configuration is loaded or reloaded. If a role is defined more than once on an instance, it will still only be run once. Three functions must be defined in the role: validate(), apply() and stop(). Each of these functions should throw an error if it occurs. The "roles_cfg" option specifies the configuration for each role. In this option, the role name is the key and the role configuration is the value. On each run, all roles will be loaded (if necessary) in the order in which they were specified; the configuration for each role will then be validated using the corresponding validate() function in the same order; and then they will all be run with apply() function in the same order. If some roles have been removed from the instance, they will be stopped in reverse order using the stop() function. Example of a role structure: ``` local M = {} -- Validates configuration of the role. -- -- Called on initial configuration apply at startup and on -- configuration reload if the role is enabled for the given instance. -- -- The cfg argument may have arbitrary user provided value, -- including nil. -- -- Must raise an error if the validation fail. function M.validate(cfg) -- <...> end -- Applies the given configuration of the role. -- -- Called on initial configuration apply at startup and on -- configuration reload if the role is enabled for the given instance. -- -- The cfg argument may have arbitrary user provided value, -- including nil. -- -- Must raise an error if the given configuration can't be applied. function M.apply(cfg) -- <...> end -- Stops the role. -- -- Called on configuration reload if the role was enabled before -- and removed now from the list of roles of the given instance. -- -- Should cancel all background fibers and clean up hold -- resources. -- -- Must raise an error if this action can't be performed. function M.stop() -- <...> end return M ```
-