- Jun 07, 2018
-
-
Alexander Turenko authored
-
Alexander Turenko authored
* added --verbose to show output of successful TAP13 test (#73) * allow to call create_cluster(), drop_cluster() multiple times (#83) * support configurations (*.cfg files) in core = app tests * added return_listen_uri = <boolean> option for create_cluster() * save and print at fail tarantool log for core = app tests (#87)
-
Vladimir Davydov authored
This patch implements space_vtab::build_index callback for vinyl spaces. Now instead of returning an error in case the space is not empty, the callback will actually try to build a new index. The build procedure consists of four steps: 1. Prepare the LSM tree for building. This implies writing a special record to vylog, VY_LOG_PREPARE_LSM, and adding the new index to the vinyl scheduler so that it can be dumped during build. We need to log the new LSM tree so that we can keep track of run files created for it during build and remove them if build procedure fails. 2. Inserting tuples stored in the space into the new LSM tree. Since there may concurrent DML requests, we install a trigger to forward them to the new index. 3. Dumping the index to disk so that we don't have to rebuild it after recovery. 4. Committing the new LSM tree in vylog (VY_LOG_CREATE_LSM). Steps 1-3 are done from the space_vtab::build_index callback while step 4 is done after WAL write, from index_vtab::commit_create. While step 3 is being performed, new DML requests may be executed for the altered space. Those requests will be reflected in the new index thanks to the on_replace trigger, however they won't be recovered during WAL recovery as they will appear in WAL before the ALTER record that created the index. To recover them, we replay all statements stored in the primary key's memory level when replaying the ALTER record during WAL recovery. Closes #1653
-
Vladimir Davydov authored
Currently, we assume that no two runs of the same range intersect by LSN. This holds, because LSNs grow strictly monotonically, and no transaction may be split between two runs (as we pin each affected vy_mem until the transaction is complete). We ensure this with an assertion in vy_task_dump_complete. However, tuples inserted during index build will have arbitrary (not monotonically growing) LSNs. This is OK as for each particular key, two statements will still have different LSNs, but this may break the assertion in vy_task_dump_complete in case dump occurs while build is in progress. To avoid that, let's relax this limitation and assume that a dumped run may intersect by LSN with runs dumped before. Moreover, let's assume that it may have max LSN less than the max LSN stored on disk so that we should update vy_lsm::dump_lsn only if the dumped run has newer data. Needed for #1653
-
Konstantin Osipov authored
-
Vladimir Davydov authored
The fact that we may yield after we added a new slice created by dump, but before we removed the dumped in-memory index from the LSM tree complicates read iterator logic, as it has to detect such a case and filter out sources that contain duplicates. This logic relies on the fact that no two slices of the same range intersect by LSN. For the sake of ALTER we have to relax this limitation, as statements inserted during index build can have arbitrary (not monotonically growing) LSNs, so the no-LSN-intersection property won't be fulfilled for whole slices, only for individual keys. Since there shouldn't be more than 1000 ranges in the same LSM tree, yielding doesn't make much sense as iteration over the whole range tree should be pretty fast. Besides, dump isn't done frequently. That said, let's remove yielding altogether. Needed for #1653
-
Alexander Turenko authored
It is necessary for build on Ubuntu Bionic. Debian bugreport: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=881481 Debhelper commit: https://github.com/Debian/debhelper/commit/740c628a1e571acded7e2aac5d6e7058e61da37f
-
lifemaker authored
-
Vladimir Davydov authored
We need to check unique constraint when building a new index. So let's factor out this helper function and pass space_name, index_name, and read view to it explicitly (because index_name_by_id isn't going to work for an index that is under construction and there's no tx when we are building a new index). Suggested by @Gerold103. Needed for #1653
-
Vladislav Shpilevoy authored
It is quite simple - just use stdout file descriptor as the destination for push messages. It is needed to make remote and local console be similar.
-
- Jun 06, 2018
-
-
Vladislav Shpilevoy authored
box.session.push allows to send some intermediate results in the scope of main request with no finalizing it. Messages can be sent over text and binary protocol. This patch allows to send text pushes. Text push is a YAML document tagged with '!push!' handle and 'tag:tarantool.io/push,2018' prefix. YAML tags is a standard way to define a type of the document. Console received push message just prints it to the stdout (or sends to a next console, if it is remote console too). Part of #2677
-
Konstantin Osipov authored
malloc() or getsockname() may reset the errno. Let's ensure we preserve errno when setting the diagnostics.
-
Vladimir Davydov authored
For the sake of recovery, we keep all vy_lsm_recovery_info objects in vy_recovery::index_id_hash, which maps space_id/index_id to the latest index incarnation. We build this hash while loading records from vylog, which is rather difficult for understanding, because an LSM tree may have a counterpart created by incomplete ALTER (see ->prepared) so we have to link and unlink those objects very carefully. Let's simplify the procedure by postponing hash building until we have loaded all records.
-
Vladimir Davydov authored
vy_mem_commit_stmt() expects statements to be committed in the order of increasing LSN. Although this condition holds now, it won't once we start using this function for building indexes. So let's remove this limitation. Needed for #1653
-
Konstantin Osipov authored
-
Vladimir Davydov authored
Since commit 1e1c1fdb ("vinyl: make read iterator always return newest tuple version") vinyl read iterator guarantees that any tuple it returns is the newest version in the iterator read view. However, if we don't bump mem version after assigning LSN to a mem statement, a read iterator using committed_read_view might not see it and return a stale tuple. Currently, there's no code that relies on this iterator feature, but we will need it for building new indexes. Without this patch, build (introduced later in the series) might return inconsistent results. Needed for #1653
-
Vladimir Davydov authored
Currently, we write new indexes to vylog only after successful WAL write (see vinyl_index_commit_create). This is incompatible with space ALTER - the problem is during ALTER vinyl may need to create new run files, which we need to track in order not to leave garbage if ALTER fails or tarantool exits before ALTER is complete. So this patch splits index creation in two stages, prepare and commit. The 'commit' stage is represented by existing VY_LOG_CREATE_LSM record, which is written from index_vtab::commit_create callback, just like before. For the 'prepare' stage we introduce a new record type, VY_LOG_REPARE_LSM, written from index_vtab::add_primary_key and index_vtab::build_index callbacks, i.e. before WAL write. For now, we don't write anything to prepared, but uncommitted indexes (this will be done later), but we do add prepared indexes to the scheduler so that they can be dumped and compacted. If ALTER fails, we drop prepared indexes in index_vtab::abort_create callback. Prepared but uncommitted indexes are ignored by backup and replication and cleaned up from vylog on restart. Note, we have to rework vinyl/errinj_vylog test in this patch, because index creation (and hence space truncation) commands now fail on vylog error, i.e. a situation when the same index is dropped and recreated multiple times in xlog without having corresponding records in vylog is now impossible. Also, space truncation is not linearizable for vinyl anymore as it may yield before WAL write, while trying to prepare an index in vylog. This is OK - we never promised it is. Remove the corresponding test case. Needed for #1653
-
- Jun 04, 2018
-
-
Vladimir Davydov authored
Vinyl worker threads can consume all disk bandwidth while performing dump or compaction, thus stalling DML requests, which also need some disk bandwidth for WAL. Memtx has a similar problem - it needs to write snapshot files. In case of memtx, we cope with this problem by limiting the write rate with box.cfg.snap_io_rate_limit option. Let's reuse this option for limiting vinyl dump/compaction rate. Closes #3220
-
Vladimir Davydov authored
fiber_sleep() works only if the current thread was created with cord_costart(). Since vinyl worker threads don't need fibers, they are created with cord_start() and hence can't use fiber_sleep(). So to be able to limit rate of vinyl dump/compaction, we have to use ev_sleep() instead of fiber_sleep() in xlog. This is fine by other xlog writers, because they don't use fibers either, neither they should as xlogs are written without coio. Needed for #3220
-
- Jun 02, 2018
-
-
Konstantin Osipov authored
-
Konstantin Osipov authored
-
Konstantin Osipov authored
-
Konstantin Osipov authored
-
Konstantin Osipov authored
-
Konstantin Osipov authored
-
Konstantin Osipov authored
Move SocketError to exception.[h,cc]
-
Konstantin Osipov authored
-
Konstantin Osipov authored
Fix a compiler warning with clang 6
-
- Jun 01, 2018
-
-
Vladimir Davydov authored
Even though we store last box.cfg.checkpoint_count checkpoints, we can only restore to the last one, because the backup API only allows to backup the last checkpoint. This patch adds an optional argument to box.backup.start() which specifies the index of the checkpoint to backup. If it is omitted or is 0, box.backup.start() will return files corresponding to the last checkpoint. If it is 1, it will back the previous checkpoint, and so on. Closes #3410
-
Vladimir Davydov authored
Follow-up #2634 Closes #3439
-
Konstantin Osipov authored
-
Vladimir Davydov authored
index.info() is about statistics so let's rename it to index.stat(). Since index.info() is not documented, we don't need to leave the old alias. Follow-up #3277
-
Vladimir Davydov authored
All global statistics are meant to be in box.stat module so let's move box.info.vinyl to box.stat.vinyl, but leave the old alias - we will remove it in 2.0. Patch all tests to use the new alias. Closes #3277
-
Konstantin Osipov authored
-
Vladimir Davydov authored
The callback invoked upon compaction completion uses checkpoint_last() to determine whether compacted runs may be deleted: if the max LSN stored in a compacted run (run->dump_lsn) is greater than the LSN of the last checkpoint (gc_lsn) then the run doesn't belong to the last checkpoint and hence is safe to delete, see commit 35db70fa ("vinyl: remove runs not referenced by any checkpoint immediately"). The problem is checkpoint_last() isn't synced with vylog rotation - it returns the signature of the last successfully created memtx snapshot and is updated in memtx_engine_commit_checkpoint() after vylog is rotated. If a compaction task completes after vylog is rotated but before snap file is renamed, it will assume that compacted runs do not belong to the last checkpoint, although they do (as they have been appended to the rotated vylog), and delete them. To eliminate this race, let's use vylog signature instead of snap signature in vy_task_compact_complete(). Closes #3437
-
Vladimir Davydov authored
Information about garbage collection internal state is quite useful when it comes to answering the question why my xlog files are not removed so let's move it from box.inernal.gc.info() to box.info.gc().
-
Konstantin Osipov authored
-
Konstantin Osipov authored
Prepare port_lua for reuse in box.session.push() Ensure port_lua_dump* can be used with an unprepared Lua stack by moving the push of encoder from box_lua_call() to port_lua_dump(). Use tarantool_L as a temporary lua stack to run the encoder. Remove encode_ctx and reuse the port state to pass parameters to the encoder.
-
- May 31, 2018
-
-
Vladislav Shpilevoy authored
In #2677 a port must be able to dump both msgpack into obuf for binary box.session.push(), and text with no obuf for text box.session.push.
-
Vladislav Shpilevoy authored
box.session.push implementation depends on session type - console session must send YAML tagged text, binary session must send MessagePack via another thread, other sessions must return error. Add virtual table to a session with 'push', 'fd' and 'sync' functions. The same virtual table together with struct session meta can be used to use memory of struct session more effectively. Before the patch session stored sync and fd as attributes, but: * fd was duplicated for iproto, which already has fd in connection; * sync is used only by iproto, and just occupies 8 byte in other sessions; * after the #2677 session additionaly must be able to store iproto connection pointer. Struct session meta uses C union to store either iproto, or console, or another meta, but not all of them together. Part of #2677
-