- Aug 07, 2018
-
-
Nikita Pettik authored
This patch introduces new system space to persist foreign keys constraints. Format of the space: _fk_constraint (space id = 358) [<constraint name> STR, <parent id> UINT, <child id> UINT, <is deferred> BOOL, <match> STR, <on delete action> STR, <on update action> STR, <child cols> ARRAY<UINT>, <parent cols> ARRAY<UINT>] FK constraint is local to space, so every pair <FK name, child id> is unique (and it is PK in _fk_constraint space). After insertion into this space, new instance describing FK constraint is created. FK constraints are held in data-dictionary as two lists (for child and parent constraints) in struct space. There is a list of FK restrictions: - At the time of FK creation parent and child spaces must exist; - VIEWs can't be involved into FK processing; - Child space must be empty; - Types of referencing and referenced fields must be comparable; - Collations of referencing and referenced fields must match; - Referenced fields must compose unique index; - Referenced fields can not contain duplicates. Until space (child) features FK constraints it isn't allowed to be dropped. Implicitly referenced index also can't be dropped (and that is why parent space can't be dropped). But :drop() method of child space firstly deletes all FK constraint (the same as SQL triggers, indexes etc) and then removes entry from _space. Part of #3271 Review fixes
-
Nikita Pettik authored
Originally, SQLite allows to create table with foreign keys constraint which refers to yet not created parent table. For instance: CREATE TABLE child(id INT PRIMARY KEY REFERENCES parent); CREATE TABLE parent(id INT PRIMARY KEY); This patch bans such ability since it contradicts SQL ANSI. Moreover, SQLite allows to drop parent table if deletion of all rows wouldn't result in FK constraint violations. This feature has been removed since in such situation child table would become inconsistent. Finally, within current patch ability to create FK constraints on VIEWs is banned as well. Part of #3271
-
Kirill Yukhin authored
-
Kirill Yukhin authored
-
Vladimir Davydov authored
It is dangerous to call box.cfg() concurrently from different fibers. For example, replication configuration uses static variables and yields so calling it concurrently can result in a crash. To make sure it never happens, let's protect box.cfg() with a lock. Closes #3606
-
- Aug 03, 2018
-
-
Alexander Turenko authored
The test case has execution time around 25 seconds on vinyl (while around 5 seconds on memtx) on a slow laptop with HDD. On a modern laptop with SSD it is ~8 seconds for vinyl and ~2-3 seconds for memtx. Both measurement were performed with parallel run of many instances of the test. Also enabled ability to run a sql-tap test w/o test-run. It was broken since b09f5964. Fixes #3590.
-
Kirill Yukhin authored
-
Kirill Yukhin authored
-
Alexander Turenko authored
Fixes #3489.
-
- Aug 02, 2018
-
-
Alexander Turenko authored
-
Alexander Turenko authored
-
Alexander Turenko authored
* support expected fail of non-default server * fix format_process function: prevent crash on some machines (#92) * print whole reject file when a test failed (#102)
-
Kirill Yukhin authored
-
Nikita Pettik authored
Originally, SQLite doesn't allow to use binding parameters in trigger's body. triggerE test checks only this taboo. However, binding mechanism is not properly implemented now, so this test seems to be useless and can be removed.
-
Georgy Kirichenko authored
There is a different error message while gitlab ci running Fixes #3602
-
Eugine Blikh authored
No more `include/yaml.h` and `lib/libyaml_static.a` installs. closes gh-3547
-
Kirill Shcherbatov authored
As space deletion in 2.0 require lookup _trigger space we have grant read from it for actual user. Closes #3595.
-
Nikita Pettik authored
Now we operate only on one database, so prefixes like 'first_db.table1' are not applieble to our SQL implementation (at least now).
-
Kirill Yukhin authored
-
Mergen Imeev authored
This patch allow to use option "--language" with "tarantoolctl enter" command. Also default value for language were added in default configuration file. Language is either SQL or Lua. Closes #2385. @TarantoolBot document Title: Language selection for tarantoolctl "enter". User can select either Lua or SQL when he uses tarantoolctl "enter" command. It can be done using "--language=<language>" syntax. Default language is set in tarantoolctl config file. Usage: tarantoolctl enter <app_name> --language=SQL tarantoolctl enter <app_name> --language=Lua
-
- Aug 01, 2018
-
-
Vladimir Davydov authored
Add txn_is_first_statement() function, which returns true if this is the first statement of the transaction. The function is supposed to be used from on_replace trigger to detect transaction boundaries. Needed for #2129
-
Vladimir Davydov authored
vy_task::status stores the return code of the ->execute method. There are only two codes in use: 0 - success and -1 - failure. So let's chage this to a boolean flag.
-
Vladimir Davydov authored
This flag is set iff worker_pool != NULL hence it is pointless.
-
Vladimir Davydov authored
We need cbus for forwarding deferred DELETE statements generated in a worker thread during primary index compaction to the tx thread where they can be inserted into secondary indexes. Since pthread mutex/cond and cbus are incompatible by their nature, let's rework communication channel between the tx and worker threads using cbus. Needed for #2129
-
Vladimir Davydov authored
I'm planning to add some new members and remove some old members from those structs. For this to play nicely, let's do some renames: vy_scheduler::workers_available => idle_worker_count vy_scheduler::input_queue => pending_tasks vy_scheduler::output_queue => processed_tasks vy_task::link => in_pending, in_processed
-
Vladimir Davydov authored
Currently, we don't really need it, but once we switch communication channel between the scheduler and workers from pthread mutex/cond to cbus (needed for #2129), tasks won't be completed on behalf of the scheduler fiber and hence we will need a back pointer from vy_task to vy_scheduler. Needed for #2129
-
Vladimir Davydov authored
This is a prerequisite for switching scheduler-worker communication from pthread mutex/cond to cbus, which in turn is needed to generate and send deferred DELETEs from workers back to tx (#2129). After this patch, pending tasks will be leaked on shutdown. This is OK, as we leak a lot of objects on shutdown anyway. The proper way of fixing this leak would be to rework shutdown without atexit() so that we can use cbus till the very end. Needed for #2129
-
Vladimir Davydov authored
Currently, both vy_read_iterator_next() and vy_point_lookup() add the returned tuple to the tuple cache. As a result, we store partial tuples in a secondary index tuple cache although we could store full tuples (we have to retrieve them anyway when reading a secondary index). This means wasting memory. Besides, when the #2129 gets implemented, there will be tuples in a secondary index that have to be skipped as they have been overwritten in the primary index. Caching them would be inefficient and error prone. So let's call vy_cache_add() from the upper level and add only full tuples to the cache. Closes #3478 Needed for #2129
-
- Jul 31, 2018
-
-
Vladimir Davydov authored
For the sake of further patches, let's do some refactoring: - Rename vy_check_is_unique to vy_check_is_unique_primary and use it only for checking the unique constraint of primary indexes. Also, make it return immediately if the primary index doesn't need uniqueness check, like vy_check_is_unique_secondary does. - Open-code uniqueness check in vy_check_is_unique_secondary instead of using vy_check_is_unique. - Reduce indentation level of vy_check_is_unique_secondary by inverting the if statement.
-
Vladimir Davydov authored
vy_delete_impl helper is only used once in vy_delete and it is rather small so inlining it definitely won't hurt. On the contrary, it will consolidate DELETE logic in one place, making the code easier to follow.
-
Vladimir Davydov authored
There's no point in separating REPLACE path between the cases when the space has secondary indexes and when it only has the primary index, because they are quite similar. Let's fold vy_replace_one and vy_replace_impl into vy_replace to remove code duplication.
-
Vladimir Davydov authored
Currently, we don't always need a full tuple. Sometimes (e.g. for checking uniqueness constraint), a partial tuple read from a secondary index is enough. So we have vy_lsm_get() which reads a partial tuple from an index. However, once the optimization described in #2129 is implemented, it might happen that a tuple read from a secondary index was overwritten or deleted in the primary index, but DELETE statement hasn't been propagated to the secondary index yet, i.e. we will have to read the primary index anyway, even if we don't need a full tuple. That said, let us: - Make vy_lsm_get() always fetch a full tuple, even for secondary indexes, and rename it to vy_get(). - Rewrite vy_lsm_full_by_key() as a wrapper around vy_get() and rename it to vy_get_by_raw_key(). - Introduce vy_get_by_secondary_tuple() which gets a full tuple given a tuple read from a secondary index. For now, it's basically a call to vy_point_lookup(), but it'll become a bit more complex once #2129 is implemented. - Prepare vy_get() for the fact that a tuple read from a secondary index may be absent in the primary index, in which case it should try the next matching one. Needed for #2129
-
Vladimir Davydov authored
Since vy_point_lookup() now guarantees that it returns the newest tuple version, we can remove the code that squashes UPSERTs from vy_squash_process().
-
Vladimir Davydov authored
Currently, vy_point_lookup(), in contrast to vy_read_iterator, doesn't rescan the memory level after reading disk, so if the caller doesn't track the key before calling this function, the caller won't be sent to a read view in case the key gets updated during yield and hence will be returned a stale tuple. This is OK now, because we always track the key before calling vy_point_lookup(), either in the primary or in a secondary index. However, for #2129 we need it to always return the latest tuple version, no matter if the key is tracked or not. The point is in the scope of #2129 we won't write DELETE statements to secondary indexes corresponding to a tuple replaced in the primary index. Instead after reading a tuple from a secondary index we will check whether it matches the tuple corresponding to it in the primary index: if it is not, it means that the tuple read from the secondary index was overwritten and should be skipped. E.g. suppose we have the primary index over the first field and a secondary index over the second field and the following statements in the space: REPLACE{1, 10} REPLACE{1, 20} Then reading {10} from the secondary index will return REPLACE{1, 10}, but lookup of {1} in the primary index will return REPLACE{1, 20} which doesn't match REPLACE{1, 10} read from the secondary index hence the latter was overwritten and should be skipped. The problem is in the example above we don't want to track key {1} in the primary index before lookup, because we don't actually read its value. So for the check to work correctly, we need the point lookup to guarantee that the returned tuple is always the newest one. It's fairly easy to do - we just need to rescan the memory level after yielding on disk if its version changed. Needed for #2129
-
Konstantin Nazarov authored
The subcommands are used to create binary rock distributions. In context of #3525
-
Kirill Yukhin authored
This pragma is dead and produces nothing else but segfault. Along w/ this pragma, remove now dead opcodes which set/read schema_version and all related routines. Also, improve opcode generation script. Part of #3541
-
Kirill Shcherbatov authored
Some sql requests are complex and could contain R/W with multiple spaces. As we have no ability to make such changes transactionaly, we have to disallow such requests. Since now iterators in SQL start transaction so we cant prevent such vicious and dangerous things. Closes #3551
-
Kirill Yukhin authored
-
Mergen Imeev authored
SQL functions UPPER and LOWER now works with COLLATE as they should according to ANSI Standart. Closes #3052.
-
- Jul 30, 2018
-
-
Vladimir Davydov authored
If vy_log_bootstrap() finds a vylog file in the vinyl directory, it assumes it has to be rebootstrapped and calls vy_log_rebootstrap(). The latter scans the old vylog file to find the max vinyl object id, from which it will start numbering objects created during rebootstrap to avoid conflicts with old objects, then it writes VY_LOG_REBOOTSTRAP record to the old vylog to denote the beginning of a rebootstrap section. After that initial join proceeds as usual, writing information about new objects to the old vylog file after VY_LOG_REBOOTSTRAP marker. Upon successful rebootstrap completion, checkpoint, which is always called right after bootstrap, rotates the old vylog and marks all objects created before the VY_LOG_REBOOTSTRAP marker as dropped in the new vylog. The old objects will be purged by the garbage collector as usual. In case rebootstrap fails and checkpoint never happens, local recovery writes VY_LOG_ABORT_REBOOTSTRAP record to the vylog. This marker indicates that the rebootstrap attempt failed and all objects created during rebootstrap should be discarded. They will be purged by the garbage collector on checkpoint. Thus even if rebootstrap fails, it is possible to recover the database to the state that existed right before a failed rebootstrap attempt. Closes #461
-