Skip to content
Snippets Groups Projects
  1. Jun 01, 2020
    • Kirill Yukhin's avatar
      Allow to set directory for copying DSO before load · 366b2de7
      Kirill Yukhin authored
      Make it possible to set temporary directory where
      module will be copied before load.
      
      @TarantoolBot document
      Title: Justify module (re-)loading semantics
      
      It is now possible to set directory where temporary
      copies of modules to be loaded will be created.
      It is done by setting $(TMPDIR) variable. It
      will be "/tmp" if variable was not set.
      
      Follow up #4945
      366b2de7
    • Kirill Yukhin's avatar
      Copy DSO module before load instead of symlink-ing · 4dd421fb
      Kirill Yukhin authored
      Tarantool module reload mechanism allows to reload a module even
      if there're functions running. It is implemented by refcounting
      each invocation of module's routines.
      If reload is called, then refcounter is checked:
       - If it is 0, then no routines are in flight and module is
         reloaded by simple pair of dlclose()/dlopen().
       - If it is non-zero, then there're routines in flight. To allow
         to load multiple versions of modules it is loaded not from the
         DSO specified. Symlink to tempdir is created and dlopen() is
         invoked against it (w/RTLD_LOCAL flag to avoid conflicts).
      
      This trick was implemented in order to fool a dynamic linker: one
      cannot invoke dlopen() against same file, so let's pretend
      there're to independent DSOs.
      
      The problem is that dynamic linker is smart enough. It tracks not
      filenames, but i-nodes. Moreover it is smart enough to do stat -L
      against DSO to follow symlinks! [1][2] So, any attempts to create
      a symlinks to fool dynamic linker fail and instead of doing actual
      load it just increments internal refcounter in map w/
      corresponding inode, which in turn leads to not-reloading.
      
      This wasn't caught by test since old module was always unlinked
      before new one is copied in place.
      
      The patch always copies DSO instead of creating a symlink. Also
      it fixes the test so in SEGFAULTs without the change.
      
      Closes #4945
      
      [1] - https://sourceware.org/git/?p=glibc.git;a=blob;f=elf/dl-load\
      .c;h=a5318f9c8d1d42745a254479cf6bb1cd2acd516f;hb=58557c229319a3b8d\
      2eefdb62e7df95089eabe37#l898
      
      [2] - https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/pos\
      ix/dl-fileid.h;hb=58557c229319a3b8d2eefdb62e7df95089eabe37#l33
      4dd421fb
  2. May 29, 2020
    • Alexander V. Tikhonov's avatar
      travis-ci: disable OSX testing · 943b507a
      Alexander V. Tikhonov authored
      OSX testing completely implemented on local MAC hosts with OSX 14
      and 15 versions. So no more need to test and support issues with
      testing OSX with 14 version on travis-ci.
      
      Part of #4893
      943b507a
  3. May 28, 2020
    • Vladislav Shpilevoy's avatar
      test: stop linking msgpuck lib with test modules · e8c72d4f
      Vladislav Shpilevoy authored
      Test modules are shared libraries. They link with Tarantool at
      runtime and resolve missing symbols then. However in case they
      already contain some of the same symbols used by tarantool, that
      leads to a conflict in ASAN build. Nothing serious, there are
      strict rules how a linker should behave in this case, but there
      is still a warning. This is how it looked (the text is shortened):
      
          ==25624==ERROR: AddressSanitizer: odr-violation (0x000001123b60):
            [1] size=1024 'mp_type_hint' /builds/nZUxDh2c/0/tarantool/tarantool/src/lib/msgpuck/hints.c:39:20
            [2] size=1024 'mp_type_hint' /builds/nZUxDh2c/0/tarantool/tarantool/src/lib/msgpuck/hints.c:39:20
          These globals were registered at these points:
            [1]:
              #0 0x478b8e in __asan_register_globals (/builds/nZUxDh2c/0/tarantool/tarantool/src/tarantool+0x478b8e)
              #1 0x7ff7a9bc9d0b in asan.module_ctor (/tmp/tntz2FLhA/function1.so+0x6d0b)
      
            [2]:
              #0 0x478b8e in __asan_register_globals (/builds/nZUxDh2c/0/tarantool/tarantool/src/tarantool+0x478b8e)
              #1 0xab990b in asan.module_ctor (/builds/nZUxDh2c/0/tarantool/tarantool/src/tarantool+0xab990b)
      
      The symbol mp_type_hint is defined both in tarantool executable,
      and in function1.so dynamic library. This is because both build
      with msgpuck static library.
      
      However the modules don't need to be built with msgpuck. They can
      link with it at runtime from tarantool executable.
      
      This patch removes msgpuck from test dynamic modules, and exports
      all msgpuck non-inlined symbols explicitly, so they couldn't be
      removed by the linker in future.
      
      Follow-up #2971
      Follow-up #5001
      Closes #5023
      e8c72d4f
    • Oleg Piskunov's avatar
      gitlab-ci: parallelize perf testing · f262b64f
      Oleg Piskunov authored
      - Adding 2 servers (sh1, sh2) for performance testing.
      - Rebalance performance testing between servers:
        - sh1 (tag: docker_sh1_perf) used for benches:
          nosqlbench_hash, nosqlbench_tree
        - sh2 (tag: docker_sh2_perf) used for benches:
          ycsb_hash, ycsb_tree, cbench
        - sh3 (tag: docker_sh3_perf) used for benches:
          sysbench, tpcc
        - sh9 (tag: docker_perf_ssd) used for benches:
          linkbench_ssd
      - Changing gitlab-ci tag for performance docker images
        from 'perf' to 'deploy'.
      
      Closes #4868
      f262b64f
    • Oleg Piskunov's avatar
      gitlab-ci: cleanup temporary perf images · 47dbbf5f
      Oleg Piskunov authored
      Each temporary docker perf image is about 5 GB
      and we don’t have space to keep them localy on servers.
      
      - add cleanup after perf docker
        image preparation (perf_bootstrap job).
      - cleanup perf docker images on execution hosts
        after perf testing (cleanup stage).
      
      Closes #5003
      47dbbf5f
    • Alexander V. Tikhonov's avatar
      test: set unix sockets for iproto at core = app · 513e13eb
      Alexander V. Tikhonov authored
      Set hard-coded unix sockets for iproto connections at core = app.
      Added its option in *-tap/suites.ini files and fixed test for it.
      Fix helped to handle the problem with 'Address already in use' error.
      Check the previous commit that set the use of sockets:
      
      60f84cbf ('test: use unix sockets for iproto connections')
      
      Test sql-tap/gh-4077-iproto-execute-no-bind.test.lua removed from
      fragiled list.
      
      Closes #4459
      513e13eb
    • Vladislav Shpilevoy's avatar
      fk: fix wrong sizeof() in fk_constraint_def_sizeof() · d1647590
      Vladislav Shpilevoy authored
      The function returns a number of bytes needed to store
      an fk_constraint_def object with its name and links.
      However it used sizeof(struct fk_constraint) instead
      of sizeof(struct fk_constraint_def) to calculate
      base object size. This worked only because
      fk_constraint is bigger than fk_constraint_def.
      d1647590
    • Cyrill Gorcunov's avatar
      core/say: drop redundant declarations · df4c69ec
      Cyrill Gorcunov authored
      
      Part-of #689
      
      Signed-off-by: default avatarCyrill Gorcunov <gorcunov@gmail.com>
      df4c69ec
    • Cyrill Gorcunov's avatar
      core/say: drop vsay declaration · 6e567fac
      Cyrill Gorcunov authored
      
      The implementation has been removed in
      commit ef2c171d
      
      Part-of #689
      
      Signed-off-by: default avatarCyrill Gorcunov <gorcunov@gmail.com>
      6e567fac
  4. May 27, 2020
    • Vladislav Shpilevoy's avatar
      build: link bit library to vclock library · 74ac4263
      Vladislav Shpilevoy authored
      Vclock depends on bit library, but wasn't linked to it.
      74ac4263
    • Nikita Pettik's avatar
      vinyl: unthrottle scheduler on manual checkpoint · 7305fe5a
      Nikita Pettik authored
      Before this patch box.snapshot() bails out immediately if it sees
      that the scheduler is throttled due to errors. For instance:
      
      box.error.injection.set('ERRINJ_VY_RUN_WRITE', true)
      snapshot() -- fails due to ERRINJ_VY_RUN_WRITE
      box.error.injection.set('ERRINJ_VY_RUN_WRITE', false)
      snapshot() -- still fails despite the fact that injected error is unset
      
      As a result, one has to wait up to a minute to make a snapshot. The
      reason why throttling was introduced was to avoid flooding the log
      in case of repeating disk errors.
      What is more, to deal with schedule throttling in tests, we had to
      introduce a new error injection (ERRINJ_VY_SCHED_TIMEOUT). It reduces
      time duration during which the scheduler remains throttled, which is
      ugly and race prone.  So, let's unthrottle scheduler when checkpoint
      process is launched via manual box.snapshot() invocation.
      
      Closes #3519
      7305fe5a
    • Nikita Pettik's avatar
      engine: add is_scheduled arg to engine->begin_checkpoint · 00c582f0
      Nikita Pettik authored
      In some cases it may turn out to be useful to know whether checkpoint
      process was launched manually (explicitly calling box.snapshot()) or
      automatically via checkpoint daemon. In particular, to unthrottle vinyl
      scheduler when it comes for manual checkpoints. So let's extend engine's
      vtab method begin_checkpoint() with corresponding argument.
      
      Needed for #3519
      00c582f0
    • Nikita Pettik's avatar
      vinyl: fix assert in vy_tx_write() · f6cb9289
      Nikita Pettik authored
      Assert in vy_tx_write() validates that upsert applied on the top of
      cached statement is always replace. In fact, it is not always so. If
      vy_apply_upsert() fails due to the fact that PK is modified, it returns
      old statement (i.e. statement which upsert is applied on). In this
      regard, if tuple cache contains insert and invalid upsert is executed,
      vy_apply_upsert() will return insert. As a result, assert will fire.
      Let's fix it and take into account that vy_apply_upsert() is able to
      return inserts as well.
      
      Closes #5005
      f6cb9289
  5. May 25, 2020
    • Vladislav Shpilevoy's avatar
      vinyl: add missing diag_set in space creation · 2cf4450f
      Vladislav Shpilevoy authored
      vinyl_engine_create_space() didn't set an error in the
      diagnostics area when region_alloc() failed. This
      could lead to a crash, although was almost impossible
      to happen.
      2cf4450f
    • Vladislav Shpilevoy's avatar
      build: turn off LTO for exports.c · 36927e54
      Vladislav Shpilevoy authored
      There were lots of errors of kind:
      
      /builds/M4RrgQZ3/0/tarantool/tarantool/src/exports.h:395:1: error: variable ‘uuid_nil’ redeclared as function
        EXPORT(uuid_nil)
        ^
       /builds/M4RrgQZ3/0/tarantool/tarantool/src/lib/uuid/tt_uuid.c:39:22: note: previously declared here
        const struct tt_uuid uuid_nil;
      
      when LTO was enabled. That happened because exports.c file, to
      take symbol addresses, declared lots of functions and variables
      from all the code base as
      
          extern void <symbol>(void);
      
      This is crazy, but it worked for normal builds. Because symbol is
      symbol. The compilers couldn't find conflicting declarations,
      because they never met in one compilation unit.
      
      However the lie was revealed by linker with LTO enabled. It could
      see, that actual symbol definitions didn't match their exports in
      exports.c. It could live with mismatching function-function or
      variable-variable cases, but couldn't withstand function-variable
      mismatches. When a symbol was declared as a variable in one place
      and as a function in another.
      
      This was the case for variables:
      - uuid_nil
      - tarantool_lua_ibuf
      - log_pid
      - log_format
      - crc32_calc
      - _say
      - log_level
      
      The errors were false positive, because the symbols were never
      used for anything except taking their addresses. To calm the
      linker down exports.c now does not participate in LTO.
      
      Closes #5001
      36927e54
  6. May 22, 2020
  7. May 21, 2020
  8. May 20, 2020
    • Alexander Turenko's avatar
      test: update test-run · b7b9a59f
      Alexander Turenko authored
      Support 'use_unix_sockets_iproto' suite.ini option in 'core = app' test
      suites. It'll allow to workaround TCP port choosing race (see more in
      [1]) by using Unix sockets instead of TCP ones: we did the same for
      'core = tarantool' test suites in [2].
      
      [1]: https://github.com/tarantool/test-run/issues/141
      [2]: 60f84cbf ('test: use unix sockets
           for iproto connections')
      
      Part of #4459.
      Unverified
      b7b9a59f
    • Nikita Pettik's avatar
      vinyl: fix comment to vy_read_iterator_cmp_stmt() · 4a98a9bb
      Nikita Pettik authored
      vy_read_iterator_cmp_stmt() uses tuple_compare_with_key() under the hood
      which follows next convention:
      (a) it returns 0 if key_fields of tuple equal to given key;
      (b) < 0 if key_fields less than given key;
      (c) > 0 otherwise.
      However, comment to vy_read_iterator_cmp_stmt() says that:
      (a) it returns -1 if first statement precedes second one;
      (b) 0 if they at the same position;
      (c) +1 if first statement supersedes second one.
      so, since there's no "normalization" of return code from
      tuple_compare_with_key() it would be correct to say that
      vy_read_iterator_cmp_stmt() returns:
      (a) it returns arbitrary integer value < 0 if first statement precedes
      second one;
      (b) 0 if they at the same position;
      (c) arbitrary integer value > 0 if first statement supersedes second one.
      4a98a9bb
    • Kirill Yukhin's avatar
      small: bump new version · bb7c3d16
      Kirill Yukhin authored
      Add MAP_STACK to mmap() flags.
      bb7c3d16
    • Alexander V. Tikhonov's avatar
      test: add more tests to packaging testing · d48406d5
      Alexander V. Tikhonov authored
      Changed number of tests to packaging testing jobs from
      suites: "unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/",
      to all suites except 'replication/' suite which has special
      issue for it's enabling:
        https://github.com/tarantool/tarantool/issues/4798
      Also added testing to the all available packing jobs except
      'CentOS 6'.
      
      Removed test-run option that run testing inline to be
      able to run it in parallel. Also changed 'test-run' to
      'make test-force' command.
      
      Closes #4599
      d48406d5
    • Alexander V. Tikhonov's avatar
      test: return tests to packaging testing · f5880666
      Alexander V. Tikhonov authored
      Found that issues #1227 and #1322 were closed, returned
      the tests blocked by it into the testing.
      
      Part of #4599
      f5880666
    • Alexander V. Tikhonov's avatar
      build: fix rpm packages build on Fedora 32 · b304a78d
      Alexander V. Tikhonov authored
      Tarantool packages build scenario at rpm/tarantool.spec
      installs Python packages for Tarantool testing. In some
      latest OS like Fedora 32 old Python packages based on
      Python 2 version were deprecated and changed to Python 3.
      Currently Tarantool testing based on Python 2 which
      packages stored at local backport repository and it
      should be used from there calling it as python2-* packages.
      
      Issue:
      ...
      No matching package to install: 'python-yaml >= 3.0.9'
      ...
      Not all dependencies satisfied
      Error: Some packages could not be found.
      
      Needed for #4599
      Closes #4965
      b304a78d
    • Alexander.V Tikhonov's avatar
      Enable script for saving RPM packages in S3 for modules · 64d1336a
      Alexander.V Tikhonov authored
      Found that modules may have only sources packages w/o binaries
      packages. Script updated to be able to work with only binaries
      either sources RPM packages. The same fix was already done for
      DEB packages at commit 4527a4da.
      
      Close #4839
      64d1336a
    • Alexander V. Tikhonov's avatar
      test: mark tests as fragile, 2nd group · 430c0e80
      Alexander V. Tikhonov authored
      Fragiled flaky tests from parallel runs to avoid
      of flaky fails in regular testing:
      
        app/fiber.test.lua                        ; gh-4987
        app/fiber_channel.test.lua                ; gh-4961
        app/socket.test.lua                       ; gh-4978
        box/alter_limits.test.lua                 ; gh-4926
        box/misc.test.lua                         ; gh-4982
        box/role.test.lua                         ; gh-4998
        box/rtree_rect.test.lua                   ; gh-4994
        box/sequence.test.lua                     ; gh-4996
        box/tuple.test.lua                        ; gh-4988
        engine/ddl.test.lua                       ; gh-4353
        replication/box_set_replication_stress    ; gh-4992
        replication/recover_missing_xlog.test.lua ; gh-4989
        replication/replica_rejoin.test.lua       ; gh-4985
        replication/wal_rw_stress.test.lua        ; gh-4977
        replication-py/conflict.test.py           ; gh-4980
        vinyl/errinj_ddl.test.lua                 ; gh-4993
        vinyl/misc.test.lua                       ; gh-4979
        vinyl/snapshot.test.lua                   ; gh-4984
        vinyl/write_iterator.test.lua             ; gh-4572
        xlog/panic_on_broken_lsn.test.lua         ; gh-4991
      
      Part of #4953
      430c0e80
    • Sergey Bronnikov's avatar
      Mention OpenBSD as supported platorm · 33cc961c
      Sergey Bronnikov authored
      Part of #4967
      33cc961c
    • Sergey Bronnikov's avatar
      Add README.OpenBSD · 54d682e2
      Sergey Bronnikov authored
      Part of #4967
      54d682e2
    • Sergey Bronnikov's avatar
      test: mute broken tests on OpenBSD · c244c0b2
      Sergey Bronnikov authored
      Part of #4967
      c244c0b2
    • Sergey Bronnikov's avatar
      say: fix compilation on OpenBSD · 64308484
      Sergey Bronnikov authored
      - define macros LOG_MAKEPRI() on OpenBSD as it is absent
      - replace sigtimedwait() by sigwait() as latter is unsupported on OpenBSD
      
      Part of #4967
      64308484
    • Sergey Bronnikov's avatar
      Include libgen.h when building on OpenBSD · fd653200
      Sergey Bronnikov authored
      Part of #4967
      fd653200
    • Sergey Bronnikov's avatar
      sql: use mremap() on OpenBSD · 43ffbba6
      Sergey Bronnikov authored
      Part of #4967
      43ffbba6
    • Sergey Bronnikov's avatar
      Fix building of tt_pthread_attr_getstack() on OpenBSD · 15601e09
      Sergey Bronnikov authored
      Part of #4967
      15601e09
Loading