Skip to content
Snippets Groups Projects
  1. Jul 19, 2017
  2. Jul 18, 2017
  3. Jul 17, 2017
  4. Jul 14, 2017
  5. Jul 13, 2017
  6. Jul 12, 2017
    • Vladimir Davydov's avatar
      vinyl: zap include_deleted flag argument of vy_recovery_iterate · ea7af7f3
      Vladimir Davydov authored
      This flag is needed to skip records corresponding to dropped and
      incomplete runs on recovery, because given VY_LOG_CREATE_RUN the
      vy_recovery_iterate() callback can't tell if the run is used or
      going to be dropped. This flag needlessly complicates the code of
      vy_recovery_iterate(), which is supposed to simply replay all records
      recovered from the log, not try to be smart. Let's get rid of it and
      instead add a hint to vy_log_record indicating that a run created by
      VY_LOG_CREATE_RUN is going to be dropped.
      ea7af7f3
    • Vladimir Davydov's avatar
      vinyl: do not try to make index directory on truncate · 1b0aa562
      Vladimir Davydov authored
      vy_prepare_truncate_space() doesn't need to make directories for
      truncated indexes - they must already exist as the indexes were
      created. It just needs to create initial range for each of them.
      Factor out vy_index_init_range_tree() out of vy_index_create()
      and use it instead where appropriate.
      1b0aa562
    • Vladimir Davydov's avatar
      vinyl: refactor index recovery from vylog · 90fb2372
      Vladimir Davydov authored
      We have vy_recovery_lookup_index() function to look up an index in a
      recovery context by id and vy_recovery_iterate_index() to iterate over
      ranges, runs, and slices of a found index. vy_recovery_lookup_index()
      used to be a part of vy_recovery_iterate_index() and was factored out
      when index logging was moved to be called after WAL write, from
      vy_index_commit_create(), because during recovery we need to check if an
      index creation record was flushed to vylog before restart - currently we
      do it by trying to look it up in the recovery context.
      
      To stop using index lsn as vylog index id and remove lsn from index
      options, I'm planning to make the function loading an index from vylog
      advance an internal vylog counter so that the next time it is called it
      loads a newer incarnation of the same index. vy_recovery_lookup_index()
      doesn't fit this concept. So I introduce vy_recovery_load_index() that
      calls vy_recovery_lookup_index() and vy_recovery_iterate_index()
      internally and make the two functions private to vylog. To deal with
      indexes not logged due to vylog errors, I introduce a per index flag,
      vy_index->is_committed, which is set if the index record was flushed to
      vylog - the same approach is already used to handle index drop (see
      vy_index_commit_drop()).
      90fb2372
    • Roman Tsisyk's avatar
      Add comments to box_tuple_extract_key() · 6833e700
      Roman Tsisyk authored
      Closes #2535
      6833e700
    • Vladislav Shpilevoy's avatar
    • Alexandr Lyapunov's avatar
      vinyl: fix rollback of prepared TX · 87a2989b
      Alexandr Lyapunov authored
      Now if a prepared transaction is aborted, it expects to be the
      latest prepared TX in TX manager. It's not true in two cases:
      
      - The transaction failed during preparation. The TX is in partially
        prepared state and must rollback all the changes it made in mems
        but the preparation was not finished and thus the TX could not be
        considered as the latest in TX manager.
      
      - It's a cascading rollback with more than on TX. It would be
        graceful for the latest aborted TX to set the previous TX as
        the latest after the abortion. But the TX does not know the
        previous prepared TX and simply set to NULL appropriate pointer;
        when the time comes for the previous TX to be aborted it
        does not see itself as the latest.
      
      The TX must not expect itself to be the latest but must handle
      the last_prepared_tx pointer only if it is the latest.
      
      Fix it and add tests.
      
      Fix #2588 (case 1)
      Fix #2591 (case 2)
      87a2989b
  7. Jul 11, 2017
Loading