Skip to content
Snippets Groups Projects
  1. Jan 25, 2021
    • Alexander V. Tikhonov's avatar
      test: enable replication/ suite in packaging · 2fc2527f
      Alexander V. Tikhonov authored
      Enabled replication/ suite in packaging testing. After major number of
      issues were resolved in test-run tool and in frequently failing flaky
      tests replication/ suite can be tested within packaging testing.
      
      Closes #4798
      2fc2527f
    • Alexander V. Tikhonov's avatar
      build: bump zstd submodule · c7094cd7
      Alexander V. Tikhonov authored
      Updated third_party/zstd submodule from v1.3.3 to v1.4.8 version.
      
      Found issue building on Fedora 33:
      
        third_party/zstd/lib/decompress/zstd_decompress.c: In function ‘ZSTD_findFrameCompressedSize’:
        third_party/zstd/lib/decompress/zstd_decompress.c:1502:18: error: ‘zfh.headerSize’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
         1502 |         ip += zfh.headerSize;
              |                  ^
      
      Also found that later releases of third_party/zstd submodule already
      fixed it. Decided to bump third_party/zstd submodule from v1.3.3 to
      v1.4.8. Added to zstd cmake build rules new files appeared on bumping.
      
      Found that some checking in static-build test exporting symbols like:
      
        ZSTD_free
        ZSTD_malloc
      
      never were public symbols and should not be tested for presence in the
      Tarantool executable, but also these symbols currently outdated and
      broke the testing. To avoid of it these symbols removed from test.
      
      Needed for #5502
      Closes #5697
      c7094cd7
  2. Jan 22, 2021
  3. Jan 21, 2021
  4. Jan 20, 2021
  5. Jan 18, 2021
  6. Jan 15, 2021
  7. Jan 14, 2021
  8. Dec 30, 2020
    • Kirill Yukhin's avatar
      Dummy commit · efc30ccf
      Kirill Yukhin authored
    • Sergey Nikiforov's avatar
      base64: Properly ignore invalid characters · 726b96f0
      Sergey Nikiforov authored
      Not all invalid characters were ignored by base64 decoder
      causing data corruption and reads beyond decode table
      (faults under ASAN).
      
      Added corresponding check into base64 unit test.
      
      Fixes: #5627
      726b96f0
    • Igor Munkin's avatar
      luajit: bump new version · 94203c14
      Igor Munkin authored
      * core: remove excess assertion inside memprof
      * core: fix resources leak in memory profiler
      * misc: fix build with disabled memory profiler
      
      Follows up #5442
      94203c14
    • Alexander Turenko's avatar
      build: don't re-export libcurl.so/dylib symbols · 47c19eeb
      Alexander Turenko authored
      Export libcurl's symbols only when they are provided by tarantool
      itself: when the library is linked statically into the tarantool's
      executable. There is no much sense to export the symbols when we link
      against the library dynamically.
      
      Regarding motivation of the change. Since 2.6.0-36-g29ec62891 ('Ensure
      all curl symbols are exported') the curl_multi_poll() function is
      exported from the tarantool executable. It leads to a failure in
      Homebrew's build, because there we link (dynamically) with a system
      libcurl. On Mac OS 10.15 it is libcurl 7.64.1, while the function
      appears since libcurl 7.66.0. So a linker reports the undefined symbol:
      `curl_multi_poll`.
      
      Now the symbols are not exported at dynamic linking with libcurl, so the
      linker is happy.
      
      This commit relaxes bounds for dynamic linking, but an attempt to link
      with libcurl older than 7.66.0 statically still leads to a linking
      failure. The box-tap/gh-5223-curl-exports.test.lua test still fails when
      tarantool is linked (dynamically) against an old libcurl.
      
      It looks as the good compromise. When libcurl functionality is provided
      by tarantool itself, *all* functions listed in the test are present
      (otherwise a linker will complain). But tarantool does not enforce a
      newer libcurl version, when it just *uses* this functionality and don't
      provide it for modules and stored procedured. It is not tarantool's
      responsibility in the case.
      
      We possibly should skip the box-tap/gh-5223-curl-exports.test.lua test
      when tarantool is built against libcurl dynamically or revisit the
      described approach. I'll leave it as possible follow up activity.
      
      Fixes #5542
      47c19eeb
    • Aleksandr Lyapunov's avatar
      txm: fix tuple ownership strategy · ecc3f3d2
      Aleksandr Lyapunov authored
      Hotfix of 88b76800
      
      Fix an obvious bug - tuple ref/unref manipulation must be done only
       when we handle the primary index. Even code comment states that.
      
      Part of #5628
      ecc3f3d2
  9. Dec 29, 2020
    • Alexander Turenko's avatar
      github-ci: add --init option for docker containers · 18e24209
      Alexander Turenko authored
      
      Now we have a PID 1 zombie reaping problem, when zombie processes
      launched in Docker aren't collected by init, how it would be done if we
      launch it on a real host.
      
      It is fixed by adding --init option, when a container is created or
      started.
      
      Co-authored-by: default avatarArtem Starshov <artemreyt@tarantool.org>
      
      Follows up #4983
      18e24209
    • Cyrill Gorcunov's avatar
      crash: allow to build on non x86-64 machines · eaa61b5b
      Cyrill Gorcunov authored
      
      The general purpose registers were optional earlier
      lets make them optional back allowing the code to
      be compiled on non x86-64 machines.
      
      Signed-off-by: default avatarCyrill Gorcunov <gorcunov@gmail.com>
      Reviewed-by: default avatarAlexander Turenko <alexander.turenko@tarantool.org>
      eaa61b5b
    • Cyrill Gorcunov's avatar
      crash: extend report with instance data · 7cf4c487
      Cyrill Gorcunov authored
      
      Product team would prefer to have more data to
      be included into a crash report.
      
      So we add "instance" key with appropriate values
      (just like regular feedback entry has). For example
      
      | {
      |   "crashdump": {
      |     "version": "1",
      |     "data": {
      |       "uname": {
      |         "sysname": "Linux",
      |         "release": "5.9.14-100.fc32.x86_64",
      |         "version": "#1 SMP Fri Dec 11 14:30:38 UTC 2020",
      |         "machine": "x86_64"
      |       },
      |       "instance": {
      |         "server_id": "336bfbfd-9e71-4728-91e3-ba84aec4d7ea",
      |         "cluster_id": "176f3669-488f-46a5-a744-1be0b8a31029",
      |         "uptime": "3"
      |       },
      |       "build": {
      |         "version": "2.7.0-183-g02970b402",
      |         "cmake_type": "Linux-x86_64-Debug"
      |       },
      |       "signal": {
      |         "signo": 11,
      |         "si_code": 0,
      |         "si_addr": "0x3e800095fb9",
      |         "backtrace": "#0  0x6317ab in crash_collect+bf...",
      |         "timestamp": "2020-12-28 21:09:29 MSK"
      |       }
      |     }
      |   }
      | }
      
      Closes #5668
      
      Signed-off-by: default avatarCyrill Gorcunov <gorcunov@gmail.com>
      Reviewed-by: default avatarAlexander Turenko <alexander.turenko@tarantool.org>
      7cf4c487
    • Aleksandr Lyapunov's avatar
      txm: change tuple ownership strategy · 88b76800
      Aleksandr Lyapunov authored
      Since a space holds pointers to tuples it must increment
      reference counters of its tuples and must decrement counters
      of tuples that are deleted from the space.
      
      Memtx TX manager also holds references to processing tuples
      in the same way.
      
      Before this patch there was a logic: while a tuple is dirty
      it belongs to TX manager and does not belong to the space. Only
      when a tuple is cleared and it is still in space it will be
      referenced by space.
      
      That logic leads to crashes in some DDL requests since they
      works with indexes directly. For example deleting an index
      causes dereferencing of all its tuples - even dirty.
      
      This patch changes the logic. Now all tuples that are physically
      in the primary index of the space a referenced. Once removed from
      primary index - the tuple is dereferenced. TX manager references
      tuples like before - every holding tuple is referenced.
      
      Part of #5628
      88b76800
    • Aleksandr Lyapunov's avatar
      txm: free resource gracefully on server shutdown · a3741f6b
      Aleksandr Lyapunov authored
      Part of #5628
      a3741f6b
    • Aleksandr Lyapunov's avatar
      txm: fix another simple bug in tx manager · de6a4849
      Aleksandr Lyapunov authored
      There was a typo in collection of read set - a dirty
      tuple was added instead of clean.
      
      Closes #5559
      de6a4849
    • Aleksandr Lyapunov's avatar
      txm: fix a simple bug in tx manager · 122dc47f
      Aleksandr Lyapunov authored
      The problem happened when a tuple story was delete by two
      statements, one committed and one not committed.
      
      Part of #5628
      122dc47f
Loading