Previously, LuaValue was used for deserializing msgpack data.
It is marked with #[serde(untagged)] attribute, meaning that
the enum is deserializaed by probing each variant in order unless one
succeeds. It turned out, that this can cause unexpected type convertions
due to the order of variants.

For example, msgpack integer value was deserialized into LuaValue::Double,
because this variant comes before LuaValue::Integer and integer values
can be represented as floats.

This commit resolves this issue by configuring LuaValue to be deserialized
as rmpv::Value using #[serde(try_from)] attribute.

Closes #1130

Add new files:
- storage/snapshot.rs: stuff related to raft snapshot
- storage/schema.rs: stuff related to DDL logic

Code is only moved, no changes to logic

Dmitry Ivanov authored 3 months ago and Dmitry Ivanov committed 3 months ago

Here's a few data points:
* Linux + amd64: ENABLE_BACKTRACE=ON by default.
* Linux + aarch64: ENABLE_BACKTRACE=OFF by default.

See https://github.com/tarantool/tarantool/issues/8791.

This patch includes the following improvements:
- Use clock_lowres_signal_reset() instead of raw alarm().
- Use path_unlock() instead of raw fcntl().
- Use std's Command api instead of raw execvp().
- reattach_stderr() is no longer needed as of tarantool-sys (28cb2cfa127).

Dmitry Ivanov authored 3 months ago and Dmitry Ivanov committed 3 months ago

Previously, log_destroy would close log->fd even if it's one of the
standard streams. This behavior almost never makes sense, unless
one's trying to write a unix daemon which is obviously not the case.

Closing stderr has the following side effects:
- it breaks a reinit of the default logger;
- it inhibits ASan's final leak report;
- it causes a EPOLLHUP during a restart via `--entrypoint-fd` (Picodata).

We have to specify custom targets to disable ASan for build.rs and such.
This affects the path to picodata, so we have to adapt:

```
target/debug/picodata
target/x86_64-unknown-linux-gnu/asan/picodata
```

Also deduce target for ASan build from `rustc -vV`.

Co-Authored-By: Dmitry Rodionov <d.rodionov@picodata.io>
Co-Authored-By: Dmitry Ivanov <d.ivanov@picodata.io>

This adds support for ASan both in rust code and core tarantool. To build with ASan, simply run

```bash
make build-asan
```

Keep in mind that ASan-enabled executable lives in

```
target/x86_64-unknown-linux-gnu/asan/picodata
```

as opposed to

```
target/debug/picodata
```

This fixes the following issues:

* Release build not working on macos.
* -rdynamic, -export-dynamic and such are a code smell. They expose
  too much and hinder the ability to clearly define the API & ABI bounds.

This patch boils down to the following improvements:

* Various linkage-related shenanigans have been documented and revamped.
* All logic to build tarantool-sys is now encapsulated in tarantool-build.
* Most of the magic `println!`s are now encapsulated in build-rs-helpers.
* Unsound function `export_symbols` has been dropped in favor of
  explicit linker flags (`--require-defined` for linux & `-u` for mac).
* `TarantoolBuildRoot` is now in charge of building and linking
  tarantool libs. It defines the build tree via path helper functions.
* Picodata's `build.rs` should be a little easier to read.