Егор Ивков authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

- Add new variants to `traft::op::Op` for Ddl handling
- Provide corresponding Ddl operation structs
- Provide a builder for `DdlPrepare`

Georgy Moshkin authored 2 years ago and Yaroslav Dynnikov committed 1 year ago

This patch includes:

- Tarantool stored procedure `proc_cas`.
- Lua API `pico.cas`.
- Integration tests.

Now the function returns `first_index` instead of the number of entries
deleted - it has no practical purpose.

This patch adds a missing test for `pico.raft_compact_log` Lua API.
Also, it changes the API to be more alike other relevant Lua functions:
`raft_propose_*`, `raft_read_index`, `raft_timeout_now`.

Yaroslav Dynnikov authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

Adopted styleguide is "actual == expected", not vice versa.

Bumping `tarantool-module` fixes the `fiber::csw()` performance issue
that caused flaky tests in CI.

Also this patch increases the `test_sigsegv_child` timeout. The test is
flaky too, let's see if it helps.

1. Refine and document the behavior of
  - `RaftSpaceAccess::entries()`
  - `raft::Storage::entries()`
  - `raft::Storage::term()`
  - `raft::Storage::first_index()`
  - `raft::Storage::last_index()`

2. Test it intensively.

1. Change `.map_err(box_err)` into `cvt_err()`. It makes lines shorter.
2. Change few unwraps into `.expect()`.
3. Change `.unwrap_or_default()` into `.unwrap_or(v)`. It's shorter and
   saves some cognitive resources.

Denis Smirnov authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

We don't want to strip unused symbols from the static libraries on
the linking stage. This leads to problems with tarantool's crypto
module. Some symbols ("crypto_EVP_get_digestbyname" for example)
were used only by the ffi calls inside `crypto.lua` file. So the
linker stripped these symbols as it was not able to find their
usage in the rest of the C code. This produced SIGABRT on the
picodata startup when tarantool_lua_init() initialized the crypto
module.

Denis Smirnov authored 2 years ago and Yaroslav Dynnikov committed 1 year ago

An attempt to start picodata on macos returns an error:
symbol not found in flat namespace '_res_9_getservers'

The reason is that macos executables require libresolv.dylib to
use resolv.h.

Дмитрий Кибирев authored 2 years ago and Yaroslav Dynnikov committed 2 years ago

Also sign, deploy and check install.

Resolve issue #219
Check package deployment was added for Ubuntu focal, Ubuntu jammy, Debian
bullseye, Alt p9 and Alt p10 to avoid problems with broken deployments.

Yaroslav Dynnikov authored 2 years ago and Alexey Protsenko committed 2 years ago

The build process was refactored recently in b9aeab59 and it broke the
packaging in a tricky way.

Packpack wraps the whole build process in a Makefile which exports its
own `MAKEFLAGS` environment variable:

```
MAKEFLAGS="w -j -- BUILDDIR=/build"
```

The `cmake` crate used to override it with `CARGO_MAKEFLAGS` provided by
cargo. But after we've replaced it with `std::process::Command`, the
`BUILDDIR` setting has made its way to the `icu` build, which suddenly
clashed one of internal `make` variables and wrote there resource files.
As a result, the `icu` build started to fail with the error:

```
icupkg: unable to open input file
"/build/usr/src/debug/picodata-22.11.0.158/
   /target/debug/build/tarantool-sys/icu-prefix/src/icu-build/
   /data/out/build/icudt62l/af.res"
```

while all resources were copied directly to `/build/af.res`.

This patch repeats the behavior of the `cmake` crate.

It also makes logging more verbose and aligns the output. Replacing
`eprintln` with `println` is necessary since `make` and `cmake` both
write the logs to the `stdout`.

It's obsolete anyway.