Denis Smirnov authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

We don't want to strip unused symbols from the static libraries on
the linking stage. This leads to problems with tarantool's crypto
module. Some symbols ("crypto_EVP_get_digestbyname" for example)
were used only by the ffi calls inside `crypto.lua` file. So the
linker stripped these symbols as it was not able to find their
usage in the rest of the C code. This produced SIGABRT on the
picodata startup when tarantool_lua_init() initialized the crypto
module.

Denis Smirnov authored 2 years ago and Yaroslav Dynnikov committed 1 year ago

An attempt to start picodata on macos returns an error:
symbol not found in flat namespace '_res_9_getservers'

The reason is that macos executables require libresolv.dylib to
use resolv.h.

Дмитрий Кибирев authored 2 years ago and Yaroslav Dynnikov committed 2 years ago

Also sign, deploy and check install.

Resolve issue #219
Check package deployment was added for Ubuntu focal, Ubuntu jammy, Debian
bullseye, Alt p9 and Alt p10 to avoid problems with broken deployments.

Yaroslav Dynnikov authored 2 years ago and Alexey Protsenko committed 2 years ago

The build process was refactored recently in b9aeab59 and it broke the
packaging in a tricky way.

Packpack wraps the whole build process in a Makefile which exports its
own `MAKEFLAGS` environment variable:

```
MAKEFLAGS="w -j -- BUILDDIR=/build"
```

The `cmake` crate used to override it with `CARGO_MAKEFLAGS` provided by
cargo. But after we've replaced it with `std::process::Command`, the
`BUILDDIR` setting has made its way to the `icu` build, which suddenly
clashed one of internal `make` variables and wrote there resource files.
As a result, the `icu` build started to fail with the error:

```
icupkg: unable to open input file
"/build/usr/src/debug/picodata-22.11.0.158/
   /target/debug/build/tarantool-sys/icu-prefix/src/icu-build/
   /data/out/build/icudt62l/af.res"
```

while all resources were copied directly to `/build/af.res`.

This patch repeats the behavior of the `cmake` crate.

It also makes logging more verbose and aligns the output. Replacing
`eprintln` with `println` is necessary since `make` and `cmake` both
write the logs to the `stdout`.

It's obsolete anyway.

Without it the previous commit is incomplete - it may raise "address
already in use" error without telling what address exactly is is use.

Pytest xdist significantly reduce integration tests time
by splitting test cases into parallel child process.
Enable this feature by `-n` or `--numprocesses`,
set to 'auto' for optimal hardware resource usage.

Integration tests use some TCP ports. These ports may conflict with:
- already running instances on the developer host
- any other program on the developer host or on the CI host

The `port_range` fixture checks that all ports between
base_port and max_port (inclusive) are unused,
so integration tests are allowed to run.

Yaroslav Dynnikov authored 2 years ago and Yaroslav Dynnikov committed 2 years ago

Also make `Default` trait implementation for `struct Instance` public.
Because keeping it private makes no sence for a public struct with
public fields.

Yaroslav Dynnikov authored 2 years ago and Yaroslav Dynnikov committed 2 years ago

"You should consider adding a `Default` implementation for `Mailbox<T>`"

This reverts commit 267dc61b.

It produces false-positive errors in CI.

Yaroslav Dynnikov authored 2 years ago and Yaroslav Dynnikov committed 2 years ago

Cargo used to complain:

```
error: the linking modifiers `+bundle` and `+whole-archive` are not
compatible with each other when generating rlibs
```

Also remove unnecessary subdir

1. Encapsulate printing rustc flags in their own mod.
2. Arrange paths formatting.

1. Remove build dependency on cmake crate. It doesn't fulfill all our
   needs, so we run cmake directly via `std::process::command`. It also
   makes `build.rs` easier to understand.
2. Arrange paths variable names.

Provide a supplementary `Run` trait for the
`std::process::Command`.

We haven't used rustc < 1.61 for a long time.

It's obsolete as we are not going to implement raft_applier fiber
anymore.