Georgy Moshkin authored 9 months ago and Dmitry Rodionov committed 9 months ago

Previously tests did change environment variables and since they run in
parallel this lead to other tests failing because of unexpected env
content

Co-authored-by: Dmitry Rodionov <d.rodionov@picodata.io>

Previously when running `pico.sql [[ create table foo ]]` we would get
this output:
```
---
- null
- "sbroad: rule parsing error:  --> 1:9\n  |\n1 |  create table foo \n  |  ^---\n
  \ |\n  = expected Unique"
...
```

But now the output will be:
```
---
- null
- |+
  sbroad: rule parsing error:  --> 1:9
    |
  1 |  create table foo
    |         ^---
    |
    = expected Unique

...
```

this fixes the following bug:
```
picodata run --data-dir tmp/i1/
C> invalid socket path: tmp/i1//admin.sock
[supervisor:214288] no ipc message from child
[supervisor:214288] subprocess 214289 exited with code 1
```

We don't need to replace $n with question marks any more, as we support
the pg parameters format.

See https://git.picodata.io/picodata/picodata/sbroad/-/merge_requests/377
and https://git.picodata.io/picodata/picodata/sbroad/-/issues/543.

Close #635

Reasons:
- it's not safe to split raft entries as atomicness is lost
- the original feature was not tested

Maksim Kaitmazian authored 11 months ago and Dmitry Ivanov committed 9 months ago

pgproto used to interact with picodata through lua entrypoins, but after
making pgproto a picodata module, we can get rid of this lua layer and
simply call corresponding rust functions.

Maksim Kaitmazian authored 11 months ago and Dmitry Ivanov committed 9 months ago

After moving pgproto into picodata we can merge their implementations of
Describe into a singe module.

Maksim Kaitmazian authored 11 months ago and Dmitry Ivanov committed 9 months ago

The backend module implements the logic for handling postgres messages.
Note that this commit doesn't bring anything new: it just moves picodata's
handlers into pgproto.

See: https://git.picodata.io/picodata/picodata/picodata/-/issues/630

godzie44 authored 10 months ago and Georgy Moshkin committed 9 months ago

chore(plugins): `update_plugin_tiers` API call is split into `service_append_tier` and `service_remove_tier` calls

godzie44 authored 10 months ago and Georgy Moshkin committed 9 months ago

- add description field to `_pico_plugin` and `_pico_service`
- plugin loading: filter files by its extensions
- plugin loading: check possible service collisions
- plugin loading: now plugin searching at {plugin_dir}/{plugin_name} path
- now all errors between plugin and picodata wrapping with `BoxError` (this protects plugin caller from UAF)

This patch fixes a couple of warnings that look like this:

```
warning: creating a shared reference to mutable static is discouraged
  --> src/error_injection.rs:23:43
   |
23 |     let Some(injected_errors) = (unsafe { &INJECTED_ERRORS }) else {
   |                                           ^^^^^^^^^^^^^^^^ shared reference to mutable static
   |
   = note: for more information, see issue #114447 <https://github.com/rust-lang/rust/issues/114447>
   = note: this will be a hard error in the 2024 edition
   = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior
help: use `addr_of!` instead to create a raw pointer
   |
23 |     let Some(injected_errors) = (unsafe { addr_of!(INJECTED_ERRORS) }) else {
   |                                           ~~~~~~~~~~~~~~~~~~~~~~~~~
```