Skip to content
Snippets Groups Projects
  1. Jun 27, 2023
  2. Jun 23, 2023
    • Aleksandr Lyapunov's avatar
      memtx: abort readers of rollbacked prepared · 0daf852a
      Aleksandr Lyapunov authored
      There's case when a transaction is rolled back from prepared
      state. This happens when WAL fails, synchronized replication
      confirmation failure or perhaps in other similar cases. By design
      other RW transactions and transactions with READ_COMMITTED
      isolation level are allowed to read prepared state. All these
      transactions must be aborted in case of rollback of prepared
      transaction since they definitely have read no more possible
      database state.
      
      This patch implements this abortion.
      
      Closed #8654
      
      NO_DOC=bugfix
      
      (cherry picked from commit 54986902)
      0daf852a
    • Aleksandr Lyapunov's avatar
      memtx: fix and refactor memtx_tx_history_rollback_stmt · 6ace2307
      Aleksandr Lyapunov authored
      Rollback is rather complicated part if MVCC implementation that
      is meant to handle two kinds of rollback:
      * rollback from in-progress state, if box.rollback() is called.
      * rollback from prepared state, when WAL fails.
      Unfortunately the last one was not properly tested and surely
      has at least one flaw. When an inserting transaction becomes
      prepared its stories could be linked as deleted (via del_stmt
      pointer) by other in-progress transactions in order to maintain
      correct visibility. The problem is that in case of rollback of
      such prepared transaction those links remained. Broken links
      breaks the chain structure, and some older changes (that were
      linked as deleted before that hapless preparation) can become
      visible to other transaction.
      
      Refactor, simplify a bit that part of code and fix the issue
      described above; cover with tests.
      
      Closes #8648
      
      NO_DOC=bugfix
      
      (cherry picked from commit 85569d9c)
      6ace2307
    • Aleksandr Lyapunov's avatar
      memtx: simplify and refactor memtx_tx_history_prepare_stmt · 980b414d
      Aleksandr Lyapunov authored
      Almost completely rewrite, simplify and comment this part of code.
      
      Part of #8648
      Part of #8654
      
      NO_DOC=refactoring
      NO_TEST=refactoring
      NO_CHANGELOG=refactoring
      
      (cherry picked from commit e9015074)
      980b414d
    • Aleksandr Lyapunov's avatar
      memtx: simplify and refactor memtx_tx_history_add_stmt · 513005da
      Aleksandr Lyapunov authored
      Almost completely rewrite, simplify and comment this part of code.
      
      Part of #8648
      Part of #8654
      
      NO_DOC=refactoring
      NO_TEST=refactoring
      NO_CHANGELOG=refactoring
      
      (cherry picked from commit 63da3bed)
      513005da
    • Aleksandr Lyapunov's avatar
      memtx: replace is_pure_insert flag with is_own_change flag · ff1e2614
      Aleksandr Lyapunov authored
      The latter flag is a bit wider: it reveals not only inserting
      statements after deleting by the same transaction, but also
      replacing and deleting statements after all kinds of previois
      changes but the same transaction. This extended behavior will
      be used in further commits.
      
      Part of #8648
      Part of #8654
      
      NO_DOC=refactoring
      NO_TEST=refactoring
      NO_CHANGELOG=refactoring
      
      (cherry picked from commit 3cfa6756)
      ff1e2614
    • Aleksandr Lyapunov's avatar
      memtx: remove does_require_old_tuple member · f93a3da7
      Aleksandr Lyapunov authored
      It was an ugly solution when MVCC engine requires outside engine
      to set this flag which is not convenient.
      
      Remove it and use mode arguments to set up proper read trackers.
      
      Part of #8648
      Part of #8654
      
      NO_DOC=refactoring
      NO_TEST=refactoring
      NO_CHANGELOG=refactoring
      
      (cherry picked from commit 74149734)
      f93a3da7
    • Aleksandr Lyapunov's avatar
      memtx: remove dead code · 4981aaa2
      Aleksandr Lyapunov authored
      The function memtx_tx_story_delete is expected to delete fully
      unlinked stories and thus should not try to unlink something by
      itself. So remove unlink and add asserts instead.
      
      Part of #8648
      Part of #8654
      
      NO_DOC=refactoring
      NO_TEST=refactoring
      NO_CHANGELOG=refactoring
      
      (cherry picked from commit 07067407)
      4981aaa2
    • Aleksandr Lyapunov's avatar
      memtx: join and unify mvcc gap trackers · a0d7a95d
      Aleksandr Lyapunov authored
      Now there are three kinds of very close trackers:
      * The transaction have read some tuple that is not committed and
        thus not visible. This kind is now stored as gap_item with
        is_nearby = false.
      * The transaction made a select or range scan, reading a key or
        range between two adjacent tuples of the index. This kind is
        stored as gap_iteam with is_nearby = true.
      * A transaction completed a full scan of unordered index. This
        kind is stored as full_scan_item.
      
      All these trackers serve for the same thing: to record a fact
      that a transaction read something but didn't see anything.
      
      There are some problems with the current solution:
      * gap_item with is_nearby = false has several unused members that
        just consume space.
      * bool is_nearby flag for type descriptin is an ugly solution.
      * full_scan_item is separated from logically close items.
      
      This commit joins all these trackers under one base (that is
      struct gap_item_base) and solves problems above.
      
      Part of #8648
      Part of #8654
      
      NO_DOC=refactoring
      NO_TEST=refactoring
      NO_CHANGELOG=refactoring
      
      (cherry picked from commit f8d97a2e)
      a0d7a95d
    • Aleksandr Lyapunov's avatar
      memtx: logically divide read tracking and gap tracking · 6c212c0c
      Aleksandr Lyapunov authored
      Now read trackers are used both for cases when a transaction has
      read an existing value and it has read nothing (read by key but
      there was no visible tuple in this place). For latter case an
      additional index_mask was used to identify from which index the
      read was done. Along with that there was per-index interval gap
      trackers.
      
      This patch divides area of responsibility between read trackers
      and gap tracker in the following way:
      * Reads of existing visible values are stored in read trackers.
      * Reads of non-existing or non-visible values are store in gap
        trackers.
      
      This new approach allows to provide new invariants: gap trackers
      are stored only at top of chain, and read trackers are stored
      only at topmost committed story in chain.
      
      Part of #8648
      Part of #8654
      
      NO_DOC=refactoring
      NO_TEST=refactoring
      NO_CHANGELOG=refactoring
      
      (cherry picked from commit 7b8b78be)
      6c212c0c
    • Aleksandr Lyapunov's avatar
      memtx: rename nearby_gaps -> read_gaps · 3aec51fd
      Aleksandr Lyapunov authored
      In further commit this list will be used for tracking all read
      gaps, not only 'nearby'. Since this rename has rather huge
      diff, let's make it in separate commit.
      
      No logical changes.
      
      Part of #8648
      Part of #8654
      
      NO_DOC=refactoring
      NO_TEST=refactoring
      NO_CHANGELOG=refactoring
      
      (cherry picked from commit d3feb691)
      3aec51fd
    • Aleksandr Lyapunov's avatar
      memtx: check for ephemeral spaces in a uniform way · a31229d9
      Aleksandr Lyapunov authored
      In our SQL implementation temporary spaces are used. They come to
      MVCC engine in two variants - NULL or ephemeral. In both cases
      MVCC engine must not do anything, there are several checks for
      that in different parts of code.
      
      Normalize these checks and make them similar to each other.
      
      Part of #8648
      Part of #8654
      
      NO_DOC=refactoring
      NO_TEST=refactoring
      NO_CHANGELOG=refactoring
      
      (cherry picked from commit 86a8155c)
      a31229d9
    • Aleksandr Lyapunov's avatar
      memtx: drop memtx_tx_track_read_story_slow · f69de5cd
      Aleksandr Lyapunov authored
      The only place where this static function is used is more general
      static function - memtx_tx_track_read_story. This is a bit
      confusing - usually slow variant stand for public inline 'fast'
      method.
      
      So merge both functions in one.
      
      Part of #8648
      Part of #8654
      
      NO_DOC=refactoring
      NO_TEST=refactoring
      NO_CHANGELOG=refactoring
      
      (cherry picked from commit 32e41b7a)
      f69de5cd
    • Aleksandr Lyapunov's avatar
      memtx: fix lost gap and full scan items · a9e34ec1
      Aleksandr Lyapunov authored
      By a mistake in 8a565144 a shortcut was added to procedure
      that handles gap write: it was considered that if the writing
      transaction is the same as reading - there is no actual conflict
      that must be stored further. That was a wrong decision: if such
      a transaction yields and another transaction comes and commits
      a value with the same key - the first one must go to conflicted
      state since it has read no more possible state.
      
      Another similar mistake was made in e6f5090c, where writing
      after full scan of the same transaction was not tracked as read.
      Obviously that was wrong: if some other transaction overwrites
      the key and commits - this transaction must go to read view since
      it did not see anything by this key which is not so anymore.
      
      Fix it, reverting the first commit and an modifying the second and
      add a test.
      
      Closes #8326
      
      NO_DOC=bugfix
      
      (cherry picked from commit b41c4546)
      a9e34ec1
    • Aleksandr Lyapunov's avatar
      memtx: refactor handling point write · 513d2c0a
      Aleksandr Lyapunov authored
      There's a special 'point hole' mechanism in mvcc transactional
      manager that manages point gap reads by full key when no raw
      tuple was found in the index. For instance, it's the only way
      to collect gap reads for non-tree indexes.
      
      Once a new tuple is inserted to the index, the read records are
      transferred to the normal read set in the corresponding story.
      Actually after that the 'point hole' record in no more needed.
      
      So let's remove it.
      
      While we are here, drop unused point_holes_size, improve names
      and comments.
      
      Part of #8648
      Part of #8654
      
      NO_DOC=refactoring
      NO_TEST=refactoring
      NO_CHANGELOG=refactoring
      
      (cherry picked from commit 62c65639)
      513d2c0a
    • Aleksandr Lyapunov's avatar
      memtx: refactor mvcc story linking to the top of chain · 8b3f7425
      Aleksandr Lyapunov authored
      Before this patch there were several different places in the code
      that deal with referencing tuple in space, setting in_index member
      and marking the story as retained or not. But logically all above
      is about the same - about placing a story to the top of a chain,
      i.e. the first story in version list to which index points.
      
      This commit refactors these things a bit. This mostly relates to
      two functions - memtx_tx_story_new and memtx_tx_story_link_top.
      
      Changes in memtx_tx_story_new are based on the fact that if a story
      is created by tuple, it is or immediately will be at the top of
      chain. Considering this we can omit argument `is_referenced_to_pk`
      and always create a story ready to be in top of chain. If a story
      is already in the top - nothing else is needed; if it is to become
      the top - memtx_tx_story_link_top must be called after.
      
      Further, linking to top of chain is needed exactly in two cases:
      * if a story just created by memtx_tx_story_new must become a top
      * if a chain is reordered involving the top story (the top and the
        next stories are swapped)
      These two cases are logically very close but still different.
      Even more, previously there were two functions for that:
      memtx_tx_story_link_top_light and memtx_tx_story_link_top
      correspondingly. This commit introduces one function for that
      (although with one more argument) that also incapsulates
      activities about referencing tuples and marking stories as
      retained.
      
      After this patch the rules are logical and simple:
      * if a tuple is inserted - call _story_new and _link_top(.. true).
      * if a story of existing clean tuple is needed - call _story_new.
      * if a chain is reordered involving top story - _link_top(.. false).
      
      Part of #8648
      Part of #8654
      
      NO_DOC=refactoring
      NO_TEST=refactoring
      NO_CHANGELOG=refactoring
      
      (cherry picked from commit 202340b7)
      8b3f7425
    • Aleksandr Lyapunov's avatar
      memtx: use xallocation in mvcc engine · 04f9f1f9
      Aleksandr Lyapunov authored
      Remove runtime allocation error handling and use panic-on-fail
      versions of allocation functions. Reasons for that:
      * Memory error handling was never tested an probably doesn't work.
      * Some return codes was ignored so the code had obvious flaws.
      * Rollback in case of memory error made some code overcomplicated.
      
      Part of #8648
      Part of #8654
      
      NO_DOC=no new functionality added
      NO_TEST=no new functionality added
      NO_CHANGELOG=no new functionalily added
      
      (cherry picked from commit c951c9de)
      04f9f1f9
    • Aleksandr Lyapunov's avatar
      memtx: replace conflict trackers with read trackers · 7ae8c354
      Aleksandr Lyapunov authored
      Conflict trackers are used to store information that if some
      transaction is committed then some another transaction must be
      aborted. This happens when the first transaction writes some
      key while the other reads the same key. On the other hand there
      are another trackers - read trackers - that are designed to
      handle exactly the same situation. That's why conflict trackers
      can be simply replaced with read trackers.
      
      That would allow to remove conflict trackers as not needed
      anymore.
      
      Part of #8648
      Part of #8654
      
      NO_DOC=refactoring
      NO_TEST=refactoring
      NO_CHANGELOG=refactoring
      
      (cherry picked from commit a6c2b9ff)
      7ae8c354
    • Aleksandr Lyapunov's avatar
      memtx: refactor rollbacked stories · c80c6ed7
      Aleksandr Lyapunov authored
      If addition of a tuple is rolled back while the corresponding
      story is needed for something else (for example it stores a read
      set of another transaction) - the story cannot be deleted.
      Now there's a special flag `rollbacked` that is set to true
      for such stories, and the flag must be considered in places
      where history chains are scanned. That approach also requires
      psn to be set for rolled-back transactions, which surprisingly
      not as simple as it to say. All that makes the code complicated
      and hard to maintain.
      
      There's another approach for managing rolled back stories: simply
      set their del_psn to a low enough value (lower than any existing
      transaction's PSN) and (if necessary) push them to the end of
      history chain. Such a story would be invisible to any transaction
      due to already existing mechanisms, that's what is needed.
      
      In order to provide "low enough" del_psn it will be natural to
      assign real PSN starting from some predefined value, so any value
      below that predefined value will be less that any existing PSN and
      thus "low enough".
      
      Implement this more simple approach.
      
      Part of #8648
      Part of #8654
      
      NO_DOC=refactoring
      NO_TEST=refactoring
      NO_CHANGELOG=refactoring
      
      (cherry picked from commit ba394a58)
      c80c6ed7
    • Aleksandr Lyapunov's avatar
      memtx: add a couple of test cases to tx_man.test · 3d90f662
      Aleksandr Lyapunov authored
      That's strange, but in this test in a group of simple test cases
      there are test cases that checks replaces, updates and deletes,
      but occasionally there's no test case that checks inserts.
      
      Fix it and add simple test cases for inserts.
      
      No logical changes.
      
      Part of #8648
      Part of #8654
      
      NO_DOC=new test case
      NO_CHANGELOG=new test case
      
      (cherry picked from commit 37b4561f)
      3d90f662
    • Georgiy Lebedev's avatar
      box: fix memory leaks on `ER_MULTISTATEMENT_TRANSACTION` in DDL · c219f1ee
      Georgiy Lebedev authored
      Space index build and space format checking operations don't destroy space
      iterator on `txn_check_singlestatement` failure — fix this.
      
      Closes #8773
      
      NO_DOC=bugfix
      NO_TEST=<leak happens in small, cannot be detected by sanitizer>
      
      (cherry picked from commit 6689f511)
      c219f1ee
    • Georgiy Lebedev's avatar
      core: use `malloc` instead of `region` allocator in procedure name cache · 95cdf5a4
      Georgiy Lebedev authored
      The procedure name cache uses a region for hash table entry allocation, but
      the cache is a thread local variable, while the `region` uses a `slab`
      allocator the lifetime of which is bounded by `main`, while thread locals
      are destroyed after `main`: use the `malloc` allocator instead.
      
      Benchmark from #7207 shows that this change does not effect performance.
      
      Closes #8777
      
      NO_CHANGELOG=<leak does not affect users>
      NO_DOC=bugfix
      NO_TEST=<detected by ASAN>
      
      (cherry picked from commit 7135910e)
      95cdf5a4
  3. Jun 22, 2023
    • Sergey Bronnikov's avatar
      test: testing tarantool in background mode · 9351a095
      Sergey Bronnikov authored
      Before a commit ec1af129 ("box: do not close xlog file descriptors in
      the atfork handler") there was a bug when Tarantool with enabled
      background mode via environment variable could lead a crash:
      
      NO_WRAP
      ```
      $ TT_PID_FILE=tarantool.pid TT_LOG=tarantool.log TT_BACKGROUND=true TT_LISTEN=3301 tarantool -e 'box.cfg{}'
      $ tail -3 tarantool.log
      2021-11-02 16:05:43.672 [2341202] main init.c:696 E> LuajitError: cannot read stdin: Resource temporarily unavailable
      2021-11-02 16:05:43.672 [2341202] main F> fatal error, exiting the event loop
      2021-11-02 16:05:43.672 [2341202] main F> fatal error, exiting the event loop
      ```
      NO_WRAP
      
      With commit ec1af129 ("box: do not close xlog file descriptors in
      the atfork handler") described bug could not be reproduced.
      
      Proposed patch adds a test that starts Tarantool in background mode
      enabled via box.cfg option and via environment variable TT_BACKGROUND to
      make sure this behaviour will not be broken in a future.
      
      Closes #6128
      
      NO_DOC=test
      
      (cherry picked from commit f676fb7c)
      Unverified
      9351a095
  4. Jun 20, 2023
  5. Jun 19, 2023
    • Yaroslav Lobankov's avatar
      ci: extend default tests run with osx wokflows · 047b7a3c
      Yaroslav Lobankov authored
      It was decided to include the `osx_debug.yml` and `osx_release.yml`
      workflows to the default tests run (without the `full-ci` label).
      Now we can get test results for macOS faster and without an extra
      load on CI.
      
      NO_DOC=ci
      NO_TEST=ci
      NO_CHANGELOG=ci
      
      (cherry picked from commit de404cb0)
      Unverified
      047b7a3c
    • Nikita Zheleztsov's avatar
      limbo: set user for triggers on sync transaction · 81bfb000
      Nikita Zheleztsov authored
      Commit/rollback triggers are run asynchronously, upon receiving the
      write status from WAL. We can't run them in the original fiber that
      submitted the WAL request, because it would open a time window between
      writing a transaction to WAL and committing it in tx, which could lead
      to violating the cascading rolback principles. As a result,
      commit/rollback triggers run with admin privileges.
      
      The issue was already solved for confirming async transaction, but
      session and user are still not correct, when the transaction is
      confirmed by the limbo. Let's fix this issue by temporarily setting
      session and credentials to the original fiberfor running
      commit/rollback triggers.
      
      Closes #8742
      
      NO_DOC=bugfix
      
      (cherry picked from commit 8cd0cd09)
      81bfb000
    • Nikita Zheleztsov's avatar
      limbo: fix commit/rollback failures with triggers · c9d5e5b3
      Nikita Zheleztsov authored
      Currently some transactions on synchronous space fail to complete with
      the `ER_CURSOR_NO_TRANSACTION` error, when on_rollback/on_commit triggers
      are set.
      
      This is caused due to the fact, that some rollback/commit triggers
      require in_txn fiber variable to be set but it's not done when a
      transaction is completed from the limbo. Callbacks, which are used to
      work with iterators (`lbox_txn_pairs` and `lbox_txn_iterator_next`),
      acquire tnx statements from the current transactions, but they cannot
      do that, when this transaction is not assigned to the current fiber, so
      `ER_CURSOR_NO_TRANSACTION` is thrown.
      
      Let's assign in_txn variable when we complete transaction from the limbo.
      Moreover, let's add assertions, which check whether in_txn() is correct,
      in order to be sure, that `txn_complete_success/fail` always run with
      in_txn set.
      
      Closes #8505
      
      NO_DOC=bugfix
      
      (cherry picked from commit 6fadc8a0)
      c9d5e5b3
  6. Jun 15, 2023
    • Georgiy Lebedev's avatar
      build: replace `string` with JOIN option to `string_join` helper in CMake · 3250910f
      Georgiy Lebedev authored
      `string` with JOIN option is only available since CMake 3.12, but we have
      developers using CMake 3.1: implement a utility `string_join` function to
      remove this dependency.
      
      Closes #5881
      
      NO_CHANGELOG=<build fix>
      NO_DOC=<build fix>
      NO_TEST=<build fix>
      
      (cherry picked from commit 55298308)
      3250910f
    • Vladimir Davydov's avatar
      xrow: fix large bit shift error in xrow_decode_dml · 992ea525
      Vladimir Davydov authored
      Reported by ASAN. The issue was fixed in the master branch in commit
      b9550f19 ("box: support space and index names in IPROTO requests").
      
      NO_TEST=asan
      NO_DOC=bug fix
      NO_CHANGELOG=minor
      
      (cherry picked from commit d64a639b)
      992ea525
    • Vladimir Davydov's avatar
      xrow: ignore unknown IPROTO keys on decode · 5bbc2b6e
      Vladimir Davydov authored
      The xrow_decode_* functions are written in such a way that they ignore
      unknown IPROTO keys. This is required for connectivity between different
      Tarantool version. However, there's bug in the code connected with the
      value type checking: we fail if the key is >= iproto_key_MAX. This
      worked fine as long as we added new IPROTO keys in the middle of the key
      space, without bumping iproto_key_MAX, but this assumption broke when we
      added IPROTO_AUTH_TYPE. The issue is exacerbated by the fact that
      IPROTO_AUTH_TYPE is used by IPROTO_ID, which is sent unconditionally on
      connect. Let's fix the value type check and add some tests.
      
      Notes:
       - xrow_decode_heartbeat turns out to be unused. Drop it.
       - Fix the net.box helpers response_body_decode and netbox_decode_table
         to handle unknown keys and empty body. This is needed to properly
         decode a response to an injection in tests.
       - Testing unknown keys in replication requests would be complicated.
         Instead we add a bunch of unit tests.
       - Convert the xrow unit test to TAP.
      
      Closes #8745
      
      NO_DOC=bug fix
      
      (cherry picked from commit ee0660b8)
      5bbc2b6e
    • Georgiy Lebedev's avatar
      box: refactor net.box response body decoding · 81ce2185
      Georgiy Lebedev authored
      Response body decoding of DML and call/eval requests is very ad-hoc and
      hard to extend: introduce a new `response_body_decode` helper that decodes
      the response body similarly to `xrow_decode_dml` — this will allow to
      separate decoding from processing.
      
      Needed for #8147
      
      NO_CHANGELOG=refactoring
      NO_DOC=refactoring
      NO_TEST=refactoring
      
      (cherry picked from commit 1d6043fa)
      81ce2185
  7. Jun 13, 2023
  8. Jun 08, 2023
  9. Jun 07, 2023
Loading