Dmitry Travyan authored 2 years ago and Yaroslav Dynnikov committed 1 year ago

This patch introduces `picodata connect` CLI command. It allows
connecting to interactive lua console of a picodata instance via iproto
The whole implementation comes down to invoking a lua script with
`require("console").start()`.

* _picodata_index keys now include space_id
* _picodata_space distribution type changed to "array"
* _picodata_space format type changed to "array"
* add Spaces::insert and Indexes::insert methods
* Ddl now has #[serde(tag = "kind", rename_all = "snake_case")]
* Dml now has #[serde(tag = "op_kind", rename_all = "snake_case")]
* Distribution now has #[serde(tag = "kind", rename_all = "snake_case")]

The main focus is on the snapshot recovery scenarios (bootstrap /
cathcup) interleaving with explicit CaS operations, rather than on
leadership changes and joins.

Consider the case when a client requests `index: X, term: T`, but
`term(X) != T`. Picodata used to check all entries in the range `[X+1,
last]`, but it didn't check the index `X` itself.

This patch provides this one extra check. Thereby it makes sure that
all entries in the range `[X, last]` belong to the same term `T ==
current_term`.

Refactor corresponding tests accordingly

Егор Ивков authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

- Add new variants to `traft::op::Op` for Ddl handling
- Provide corresponding Ddl operation structs
- Provide a builder for `DdlPrepare`

Georgy Moshkin authored 2 years ago and Yaroslav Dynnikov committed 1 year ago

This patch includes:

- Tarantool stored procedure `proc_cas`.
- Lua API `pico.cas`.
- Integration tests.

Now the function returns `first_index` instead of the number of entries
deleted - it has no practical purpose.

This patch adds a missing test for `pico.raft_compact_log` Lua API.
Also, it changes the API to be more alike other relevant Lua functions:
`raft_propose_*`, `raft_read_index`, `raft_timeout_now`.

Yaroslav Dynnikov authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

Adopted styleguide is "actual == expected", not vice versa.

Bumping `tarantool-module` fixes the `fiber::csw()` performance issue
that caused flaky tests in CI.

Also this patch increases the `test_sigsegv_child` timeout. The test is
flaky too, let's see if it helps.

1. Refine and document the behavior of
  - `RaftSpaceAccess::entries()`
  - `raft::Storage::entries()`
  - `raft::Storage::term()`
  - `raft::Storage::first_index()`
  - `raft::Storage::last_index()`

2. Test it intensively.

1. Change `.map_err(box_err)` into `cvt_err()`. It makes lines shorter.
2. Change few unwraps into `.expect()`.
3. Change `.unwrap_or_default()` into `.unwrap_or(v)`. It's shorter and
   saves some cognitive resources.