Dmitry Ivanov authored 4 months ago and Dmitry Ivanov committed 4 months ago

This patch boils down to the following changes:

* Register the hook for all cli commands (previously only `run`).
* Print the whole text as one log line to prevent splitting.
* Always capture backtrace regardless of RUST_BACKTRACE and such.

Currently, we act under the assumption that every panic is severe
and should abort the whole process. This **does not** have to always
be the case -- for instance, we might recover from a mild panic in
Sbroad's query planner if the application state hasn't been corrupted.
A happy outcome isn't completely ruled out.

In the future we might change this behavior by replacing the
uncompromising global panic hook with a combo of strategically placed
`std::panic::catch_unwind`s and a panic hook for non-unwinding panics.

At the moment of writing, `PanicHookInfo::can_unwind` is still unstable.

Dmitry Ivanov authored 4 months ago and Dmitry Ivanov committed 4 months ago

* Use bare exec in inner.rs instead of fork + exec.
* Use parent death signal on linux (man 2 PR_SET_PDEATHSIG).
* Fix usage of waitpid() (man 2 waitpid).

Closes #1077

Maksim Kaitmazian authored 5 months ago and Maksim Kaitmazian committed 4 months ago

Previously, the plan was cloned during execution to avoid polluting
the cache. However, this appears unnecessary as it was already cloned
from the cache before binding parameters.

This commit eliminates this cloning, which can result to +7.56% of
performance improvement, as demonstrated in
https://git.picodata.io/picodata/picodata/picodata/-/issues/1026#note_107222.

Maksim Kaitmazian authored 5 months ago and Maksim Kaitmazian committed 4 months ago

As shown in
https://git.picodata.io/picodata/picodata/picodata/-/issues/1026#note_107222,
enabling LTO and using only one codegen unit can accelerate some
scenarios by 16.89%.

This commit adds these options to the "release" profile. However, it makes
the build much slower, so a new profile "fast-release" is added to address
this problem in CI. The "release" profile will only be used when merging
to master.

Maksim Kaitmazian authored 5 months ago and Dmitry Ivanov committed 4 months ago

Disabling the tracing feature has shown a significant performance improvement
of 72.50%, as demonstrated in https://git.picodata.io/picodata/picodata/picodata/-/issues/1026#note_107222.

This commit disables "tracing" feature for sbroad and eliminates
the opentelemetry wrappers and statistics tables.

Kurdakov Alexander authored 4 months ago and Alexander Kurdakov committed 4 months ago

Removed two certification 'tarantool-sys_expr.patch', 'tarantool-sys_printf.patch' patches that made
tarantool fork tests fail.

Close #764

It is simpler to reuse the script from other downstream pipelines. They
do not need to know the names of submodules in case they change. With
the patch such a change requires only updates to picodata repository.

It's ignore list for gitleaks

Fix tarantool compilation in CI by disabling bundled libcurl.
Bundled libcurl uses a file we removed because gamayun didnt like it.

This patch changes when we update current_master_name during consistent
master switchover. Now it is updated as soon as we determine that the
new master has synchronized it's vclock with the old master.

As a result we can now block expel of a non-last replica in cases where
other replicas are offline, which is crucial because instances can
easily become offline due to temporary network issues.

Now we assume instance may not respond if
- target state is Offline (non-graceful assumed)
- current state is Expelled