Dmitry Rodionov authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

It was previously used in luamod.rs in ops like create_space.
Its usage was replaced by reenterable_schema_change_request
in both Rust and Lua.

feat: add tests for tables format and parameters len, fix bucket_id calculation, add support of is_nullable sql metadata

Add ability to choose multiple fd values in filter
Add side menu
Fix layout to make UI consistent with design

Before this change we were building protobuf twice with different set of
features being enabled.

Part of cargo build --timings output before this change:

protobuf v2.28.0	3.3s	1.5s (46%)	bytes
protobuf v2.28.0	2.6s	0.7s (27%)	bytes, with-bytes

With this patch duplication is removed

The problem lies in nix package which references memfd_create libc symbol 
which doesnt exist in older libc versions available in centos and astra.

The solution is to patch nix to the state of previous version which uses
raw syscall.The offending commit that broke nix for us is:
https://github.com/nix-rust/nix/commit/cf15c2bb5505231bc3128ef61522336e315e2169#diff-17f9119515eead05b2e65afe0b31095ec95425112c31fe3c529a02f46528b970R56

Another instance of the problem in the wild:
https://github.com/lucab/libsystemd-rs/pull/144

The patch uses nix version 26.4 while the latest one is 27 because rustyline
didnt update to 27 yet and keeping two patched versions doesnt make sense.

So this is our fork with the patch: https://git.picodata.io/picodata/picodata/nix/-/tree/fix-memfd-create-for-older-libc-backport-26-4
And upstream PR: https://github.com/nix-rust/nix/pull/2146

In the long run nix doesnt look like a stable option. There is no libc version
compatibility policy at the moment. The way symbols are used makes them
required even if we're not using them. The alternative, rustix uses weak
symbols or falls back to raw syscalls:
https://github.com/bytecodealliance/rustix/blob/b08519f046787b93121214622aac015b68733c8f/src/backend/libc/fs/syscalls.rs#L1631
I believe with this solution we wouldnt have had this problem in the first
place. There is an open issue in rustyline with suggestion to use rustix
instead of nix: https://github.com/kkawakam/rustyline/issues/733

Denis Smirnov authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

At the moment clusterwide SQL has no protection from anomalies produced
by vshard bucket rebalancer. We plan to fix it ASAP, but at the moment
we need a stable non-flaky CI.

This patch makes tested cluster single-node. Multi-instance tests shall
be added later in scope of fixing the mentioned rebalancing issue.

Дмитрий Кольцов authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

This commit introduces the first iteration of Picodata Web UI.
It lacks a lot of features and also indulges a lot of technically
imperfect decisions. Those are supposed to be addressed later.

Dmitry Ivanov authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

This fixes failing builds on Arch Linux, Fedora and other Linux
distros which don't provide static libgomp or build it without -fPIE.

See https://git.picodata.io/picodata/tarantool/-/merge_requests/107

This patch adds new command `picodata sql`. Arguments are the same as `picodata connect`. The idea would be to eventually replace picodata connect with this version.

Simple prerequisites for testing with auth:

```lua
pico.create_user("Yoda", "12341234")
pico.grant_privilege("Yoda", "execute", "role", "super")
```
Super grant wont be needed in the future when access control will be tuned properly (access to system spaces, context: https://git.picodata.io/picodata/picodata/picodata/-/merge_requests/663).

Then run `target/debug/picodata run` in one terminal and `target/debug/picodata sql Yoda@localhost:3301` in another one

Features:
- Usual lib readline goodies, backward/forward search etc. Provided by [rustyline](https://lib.rs/crates/rustyline)
- Simple file based history (~/.picodata_history by default)
- Displays result sets in ascii tables. Styling can be customized if needed. Here we're using [comfy-table](https://lib.rs/crates/comfy-table) library
- If you type `\e` command your `$EDITOR` will be opened so you can write the query there. Once you close your editor the query will be executed (suggested by @funbringer)

There are a lot of things we can add. Completion, highlighting, more special commands.

Close #363