Skip to content
Snippets Groups Projects

fix: tweak encode::Context with future backwards compatibility in mind

Merged Georgy Moshkin requested to merge gmoshkin/encode-tweaks into master

Summary

  • feat: impl {Encode, Decode} for [T; N]

  • feat: impl {Encode, Decode} for Option

  • test: test Encode/Decode for integers

  • fix: don't allocated in {Encode, Decode} for char

  • feat: impl {Encode, Decode} for {HashMap, HashSet, BTreeSet}

  • feat: impl {Encode, Decode} for pointer types &, &mut, Box, Rc

  • test: be more explicit about what we check in encode tests

  • fix: tweak encode::Context with future backwards compatibility in mind

  • All fields are private and are accessed via getter methods;
  • No Context::new function, as there's no good set of parameters the users are most likely to set. Instead the builder-style methods will be used to set context parameters;
  • Context::style renamed to Context::struct_style to avoid confusion;
  • EncodeStyle renamed StructStyle to avoid confusion;
  • ci: display cpuinfo before running the benchmark

Ensure that

  • New code is covered by tests
  • API is documented
  • Changelog is up to date
  • Version is bumped in the appropriate Cargo.toml files

Merge request reports

Checking pipeline status.

Merged by Georgy MoshkinGeorgy Moshkin 1 year ago (Dec 21, 2023 8:00pm UTC)

Loading

Pipeline #30199 passed

Pipeline passed for 28e26168 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Егор Ивков
  • Егор Ивков
  • Егор Ивков
  • A couple of minor comments

  • Егор Ивков approved this merge request

    approved this merge request

  • Georgy Moshkin added 9 commits

    added 9 commits

    • 3b02cdc8 - fix: tweak encode::Context with future backwards compatibility in mind
    • a3f9cdbe - test: be more explicit about what we check in encode tests
    • b2a0b6c9 - feat: impl {Encode, Decode} for pointer types &, &mut, Box, Rc
    • 7f33a669 - feat: impl {Encode, Decode} for {HashMap, HashSet, BTreeSet}
    • dd0b2f4b - fix: don't allocated in {Encode, Decode} for char
    • c5d0776e - test: test Encode/Decode for integers
    • 1e71c4eb - feat: impl {Encode, Decode} for Option<T>
    • bd13baae - feat: impl {Encode, Decode} for [T; N]
    • 7725cacd - fix: don't ignore context when encoding str enums

    Compare with previous version

  • Georgy Moshkin added 11 commits

    added 11 commits

    • cc8a371e - 1 commit from branch master
    • 3ab843bc - ci: display cpuinfo before running the benchmark
    • 03f006bb - fix: tweak encode::Context with future backwards compatibility in mind
    • da7b2947 - test: be more explicit about what we check in encode tests
    • bb599b50 - feat: impl {Encode, Decode} for pointer types &, &mut, Box, Rc
    • 1ceb465c - feat: impl {Encode, Decode} for {HashMap, HashSet, BTreeSet}
    • b7fa8a1c - fix: don't allocated in {Encode, Decode} for char
    • 44b689e2 - test: test Encode/Decode for integers
    • 95e1ff8f - feat: impl {Encode, Decode} for Option<T>
    • a945a61a - feat: impl {Encode, Decode} for [T; N]
    • 1468ec13 - fix: don't ignore context when encoding str enums

    Compare with previous version

  • Georgy Moshkin resolved all threads

    resolved all threads

  • Georgy Moshkin added 10 commits

    added 10 commits

    • 0b54888f - ci: display cpuinfo before running the benchmark
    • 3b02cdc8 - fix: tweak encode::Context with future backwards compatibility in mind
    • a3f9cdbe - test: be more explicit about what we check in encode tests
    • b2a0b6c9 - feat: impl {Encode, Decode} for pointer types &, &mut, Box, Rc
    • 7f33a669 - feat: impl {Encode, Decode} for {HashMap, HashSet, BTreeSet}
    • bbc0797c - fix: don't allocated in {Encode, Decode} for char
    • 58d082f2 - test: test Encode/Decode for integers
    • 5642ec72 - feat: impl {Encode, Decode} for Option<T>
    • 349b3a50 - feat: impl {Encode, Decode} for [T; N]
    • d95a3ae9 - fix: don't ignore context when encoding str enums

    Compare with previous version

  • Georgy Moshkin added 11 commits

    added 11 commits

    • cc8a371e - 1 commit from branch master
    • 2f35f81e - ci: display cpuinfo before running the benchmark
    • de14ae42 - fix: tweak encode::Context with future backwards compatibility in mind
    • 15a45cee - test: be more explicit about what we check in encode tests
    • c4ad68dc - feat: impl {Encode, Decode} for pointer types &, &mut, Box, Rc
    • 21843cdd - feat: impl {Encode, Decode} for {HashMap, HashSet, BTreeSet}
    • 1ab3d68c - fix: don't allocated in {Encode, Decode} for char
    • 3f1645bf - test: test Encode/Decode for integers
    • 1d39976c - feat: impl {Encode, Decode} for Option<T>
    • c4eb89a6 - feat: impl {Encode, Decode} for [T; N]
    • 0bf997a1 - fix: don't ignore context when encoding str enums

    Compare with previous version

  • Georgy Moshkin enabled an automatic merge when the pipeline for 0bf997a1 succeeds

    enabled an automatic merge when the pipeline for 0bf997a1 succeeds

  • Georgy Moshkin aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading