godzie44 authored 10 months ago and Georgy Moshkin committed 10 months ago

chore(plugins): `update_plugin_tiers` API call is split into `service_append_tier` and `service_remove_tier` calls

godzie44 authored 11 months ago and Georgy Moshkin committed 10 months ago

- add description field to `_pico_plugin` and `_pico_service`
- plugin loading: filter files by its extensions
- plugin loading: check possible service collisions
- plugin loading: now plugin searching at {plugin_dir}/{plugin_name} path
- now all errors between plugin and picodata wrapping with `BoxError` (this protects plugin caller from UAF)

This patch fixes a couple of warnings that look like this:

```
warning: creating a shared reference to mutable static is discouraged
  --> src/error_injection.rs:23:43
   |
23 |     let Some(injected_errors) = (unsafe { &INJECTED_ERRORS }) else {
   |                                           ^^^^^^^^^^^^^^^^ shared reference to mutable static
   |
   = note: for more information, see issue #114447 <https://github.com/rust-lang/rust/issues/114447>
   = note: this will be a hard error in the 2024 edition
   = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior
help: use `addr_of!` instead to create a raw pointer
   |
23 |     let Some(injected_errors) = (unsafe { addr_of!(INJECTED_ERRORS) }) else {
   |                                           ~~~~~~~~~~~~~~~~~~~~~~~~~
```

This commit fixes that non-admin users can't read queries from the query cache.
An attempt to read from the cache used to result in the following error:
sbroad error: failed to get space_def: box error: AccessDenied: Read access to space '_pico_table' is denied for user 'alex3'

Previously, an error would occur when a user ran the same query twice.
During the first execution, the query was prepared and cached. However,
on the second execution, the client attempted to retrieve the query from the
cache and encountered an access denied error.

- we didn't check that index name is unique
in indexes meta table. That led to panics
when index with same name was created for
two tables.
- previous commit set wrong sbroad submodule.
Set sbroad submodule to correct commit

Arseniy Volynets authored 11 months ago and Denis Smirnov committed 10 months ago

- update sbroad submodule to commit
with support of UNION operator
- add integration tests for global
tables (sharded tables were tested
in cartridge tests)
- Usage:

`select a from t union select b from t2`

Fedor Telnov authored 11 months ago and Denis Smirnov committed 10 months ago

It syncs API with new sbroad's one.
For more context refer to sbroad!424

godzie44 authored 11 months ago and Yaroslav Dynnikov committed 10 months ago

Plugin topology is a mapping plugin service to tiers.

Introduce new `pico.update_plugin_tiers` API.
This function may be used for control
where plugin services must be running and where not.

Plugin integration tests have also been refactored.

godzie44 authored 11 months ago and Yaroslav Dynnikov committed 11 months ago

Now for installation and enable plugin, there are two steps instead of one
(`pico.load_plugin` previously).
1. Install plugin (`pico.install_plugin`):
validate plugin, create system tables.
2. Enable plugin (`pico.enable_plugin`):
loads plugin into instances memory, call `on_start` callback.

Same for a plugin removing process (`pico.remove_plugin` previously):
1. Disable plugin (`pico.disable_plugin`): call `on_stop` callbacks, drop
plugin from instances.
2. Remove plugin (`pico.remove_plugin`):
remove plugin meta from system tables.

Currently only 2 cases are supported:
- config_file
- commandline_or_environment

Before this change we would silently replace an instance with current
grade not Online if a new instance with the same name wanted to join.
This was a mistake as it would allow a race condition when joining
several instances at once.

Arseniy Volynets authored 11 months ago and Denis Smirnov committed 11 months ago

- update sbroad submodule with support of
datetime type and new `to_date` builtin
function.
- initialize sbroad builtin functions in
init common. Currently there is only one
builtin function `to_date`
- add integration tests for datetime types
- update tarantool module to commit with
fixes for datetime deserialization