Dmitry Rodionov authored 7 months ago and Dmitry Ivanov committed 7 months ago

> cargo tree -i either
either v1.13.0
├── itertools v0.10.5
│   └── sbroad-core v0.1.0 (picodata/sbroad/sbroad-core)
│       └── picodata v24.5.0 (picodata/picodata)

this fixes the following bug:
```
picodata run --data-dir tmp/i1/
C> invalid socket path: tmp/i1//admin.sock
[supervisor:214288] no ipc message from child
[supervisor:214288] subprocess 214289 exited with code 1
```

Also here we refactor all the places where we checked command line
parameters, because now PicodataConfig is the main source of this
information.

sbroad needs to be updated to the version that supports newer
tarantool-module

sbroad support for new module version was merged here:
https://git.picodata.io/picodata/picodata/sbroad/-/merge_requests/355

The problem lies in nix package which references memfd_create libc symbol 
which doesnt exist in older libc versions available in centos and astra.

The solution is to patch nix to the state of previous version which uses
raw syscall.The offending commit that broke nix for us is:
https://github.com/nix-rust/nix/commit/cf15c2bb5505231bc3128ef61522336e315e2169#diff-17f9119515eead05b2e65afe0b31095ec95425112c31fe3c529a02f46528b970R56

Another instance of the problem in the wild:
https://github.com/lucab/libsystemd-rs/pull/144

The patch uses nix version 26.4 while the latest one is 27 because rustyline
didnt update to 27 yet and keeping two patched versions doesnt make sense.

So this is our fork with the patch: https://git.picodata.io/picodata/picodata/nix/-/tree/fix-memfd-create-for-older-libc-backport-26-4
And upstream PR: https://github.com/nix-rust/nix/pull/2146

In the long run nix doesnt look like a stable option. There is no libc version
compatibility policy at the moment. The way symbols are used makes them
required even if we're not using them. The alternative, rustix uses weak
symbols or falls back to raw syscalls:
https://github.com/bytecodealliance/rustix/blob/b08519f046787b93121214622aac015b68733c8f/src/backend/libc/fs/syscalls.rs#L1631
I believe with this solution we wouldnt have had this problem in the first
place. There is an open issue in rustyline with suggestion to use rustix
instead of nix: https://github.com/kkawakam/rustyline/issues/733

Allow connecting interactive console over a unix socket `picodata run
--console-sock`. Use `picodata connect --unix` to connect.

Dmitry Travyan authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

This patch introduces `picodata connect` CLI command. It allows
connecting to interactive lua console of a picodata instance via iproto
The whole implementation comes down to invoking a lua script with
`require("console").start()`.

Yaroslav Dynnikov authored 2 years ago and Yaroslav Dynnikov committed 2 years ago

Eliminate code duplication, use `define_str_enum` macro from tarantool-module.
Remove personalized `FromStr::Err` for every enum defined that way.