Dmitry Ivanov authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

This fixes failing builds on Arch Linux, Fedora and other Linux
distros which don't provide static libgomp or build it without -fPIE.

See https://git.picodata.io/picodata/tarantool/-/merge_requests/107

This patch adds new command `picodata sql`. Arguments are the same as `picodata connect`. The idea would be to eventually replace picodata connect with this version.

Simple prerequisites for testing with auth:

```lua
pico.create_user("Yoda", "12341234")
pico.grant_privilege("Yoda", "execute", "role", "super")
```
Super grant wont be needed in the future when access control will be tuned properly (access to system spaces, context: https://git.picodata.io/picodata/picodata/picodata/-/merge_requests/663).

Then run `target/debug/picodata run` in one terminal and `target/debug/picodata sql Yoda@localhost:3301` in another one

Features:
- Usual lib readline goodies, backward/forward search etc. Provided by [rustyline](https://lib.rs/crates/rustyline)
- Simple file based history (~/.picodata_history by default)
- Displays result sets in ascii tables. Styling can be customized if needed. Here we're using [comfy-table](https://lib.rs/crates/comfy-table) library
- If you type `\e` command your `$EDITOR` will be opened so you can write the query there. Once you close your editor the query will be executed (suggested by @funbringer)

There are a lot of things we can add. Completion, highlighting, more special commands.

Close #363 

Allow connecting interactive console over a unix socket `picodata run
--console-sock`. Use `picodata connect --unix` to connect.

Previously picodata failed to drop spaces with grants on it ("the
space has grants"). Another problem was that we didn't clean
_pico_privileges grants when the space was dropped. Both problems
were fixed in the current commit.

The most obvious benefit is link checking. This is especially useful with rust-analyzer, because it allows to jump to definition of the item referenced in the doc comment.

The patch also makes CI to use `make lint` to avoid duplication.

The patch adds `password_min_length` parameter to `_pico_properties` space.
The parameter is taken into account in `pico.create_user` and 
`pico.change_password` lua functions.