Was changed in this commit:
https://git.picodata.io/picodata/picodata/picodata/-/commit/4b3b1650423e83724dc8915a0d5bb0c643c31a80

I believe this change was introduced by mistake (most probably because
of bulk rename)

BREAKING CHANGE!:
- pico.trace() function was removed. Use pico.sql() for tracing;
- opentelemetry tables __SBROAD_STAT and __SBROAD_QUERY were renamed
  into _SQL_STAT and _SQL_QUERY tables.

Introduce enrypoints for extended PG protocol:

- pg_bind: bind parameters to portal (IR) by descriptor;
- pg_close: remove portal from the storage by descriptor;
- pg_describe: get the portal metadata and type by descriptor;
- pg_execute: execute portal by descriptor;
- pg_parse: parse an SQL pattern into IR (reusing LRU),
  save IR into portal storage and return the descriptor;
- pg_portals: get a list of portal descriptors visible
  to the current user;

Co-authored-by: Kaitmazian Maksim <m.kaitmazian@picodata.io>

main.rs has grown a bit, adding new stuff to it doesnt feel natural.
Smaller files are easier to digest. For me it is easier to find stuff
when there are less files on the top level and some hierarchy shows.
where to go. A while back I wanted to move sql command to separate
file but there is already sql.rs on the top level.

This patch solves this issue.

Dmitry Rodionov authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

It was previously used in luamod.rs in ops like create_space.
Its usage was replaced by reenterable_schema_change_request
in both Rust and Lua.

feat: add tests for tables format and parameters len, fix bucket_id calculation, add support of is_nullable sql metadata

The problem lies in nix package which references memfd_create libc symbol 
which doesnt exist in older libc versions available in centos and astra.

The solution is to patch nix to the state of previous version which uses
raw syscall.The offending commit that broke nix for us is:
https://github.com/nix-rust/nix/commit/cf15c2bb5505231bc3128ef61522336e315e2169#diff-17f9119515eead05b2e65afe0b31095ec95425112c31fe3c529a02f46528b970R56

Another instance of the problem in the wild:
https://github.com/lucab/libsystemd-rs/pull/144

The patch uses nix version 26.4 while the latest one is 27 because rustyline
didnt update to 27 yet and keeping two patched versions doesnt make sense.

So this is our fork with the patch: https://git.picodata.io/picodata/picodata/nix/-/tree/fix-memfd-create-for-older-libc-backport-26-4
And upstream PR: https://github.com/nix-rust/nix/pull/2146

In the long run nix doesnt look like a stable option. There is no libc version
compatibility policy at the moment. The way symbols are used makes them
required even if we're not using them. The alternative, rustix uses weak
symbols or falls back to raw syscalls:
https://github.com/bytecodealliance/rustix/blob/b08519f046787b93121214622aac015b68733c8f/src/backend/libc/fs/syscalls.rs#L1631
I believe with this solution we wouldnt have had this problem in the first
place. There is an open issue in rustyline with suggestion to use rustix
instead of nix: https://github.com/kkawakam/rustyline/issues/733

Дмитрий Кольцов authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

This commit introduces the first iteration of Picodata Web UI.
It lacks a lot of features and also indulges a lot of technically
imperfect decisions. Those are supposed to be addressed later.

This patch adds new command `picodata sql`. Arguments are the same as `picodata connect`. The idea would be to eventually replace picodata connect with this version.

Simple prerequisites for testing with auth:

```lua
pico.create_user("Yoda", "12341234")
pico.grant_privilege("Yoda", "execute", "role", "super")
```
Super grant wont be needed in the future when access control will be tuned properly (access to system spaces, context: https://git.picodata.io/picodata/picodata/picodata/-/merge_requests/663).

Then run `target/debug/picodata run` in one terminal and `target/debug/picodata sql Yoda@localhost:3301` in another one

Features:
- Usual lib readline goodies, backward/forward search etc. Provided by [rustyline](https://lib.rs/crates/rustyline)
- Simple file based history (~/.picodata_history by default)
- Displays result sets in ascii tables. Styling can be customized if needed. Here we're using [comfy-table](https://lib.rs/crates/comfy-table) library
- If you type `\e` command your `$EDITOR` will be opened so you can write the query there. Once you close your editor the query will be executed (suggested by @funbringer)

There are a lot of things we can add. Completion, highlighting, more special commands.

Close #363 

Allow connecting interactive console over a unix socket `picodata run
--console-sock`. Use `picodata connect --unix` to connect.