Refactor corresponding tests accordingly

Егор Ивков authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

- Add new variants to `traft::op::Op` for Ddl handling
- Provide corresponding Ddl operation structs
- Provide a builder for `DdlPrepare`

Georgy Moshkin authored 2 years ago and Yaroslav Dynnikov committed 1 year ago

This patch includes:

- Tarantool stored procedure `proc_cas`.
- Lua API `pico.cas`.
- Integration tests.

Now the function returns `first_index` instead of the number of entries
deleted - it has no practical purpose.

This patch adds a missing test for `pico.raft_compact_log` Lua API.
Also, it changes the API to be more alike other relevant Lua functions:
`raft_propose_*`, `raft_read_index`, `raft_timeout_now`.

Yaroslav Dynnikov authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

Adopted styleguide is "actual == expected", not vice versa.

Bumping `tarantool-module` fixes the `fiber::csw()` performance issue
that caused flaky tests in CI.

Also this patch increases the `test_sigsegv_child` timeout. The test is
flaky too, let's see if it helps.

1. Refine and document the behavior of
  - `RaftSpaceAccess::entries()`
  - `raft::Storage::entries()`
  - `raft::Storage::term()`
  - `raft::Storage::first_index()`
  - `raft::Storage::last_index()`

2. Test it intensively.

1. Change `.map_err(box_err)` into `cvt_err()`. It makes lines shorter.
2. Change few unwraps into `.expect()`.
3. Change `.unwrap_or_default()` into `.unwrap_or(v)`. It's shorter and
   saves some cognitive resources.

Denis Smirnov authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

We don't want to strip unused symbols from the static libraries on
the linking stage. This leads to problems with tarantool's crypto
module. Some symbols ("crypto_EVP_get_digestbyname" for example)
were used only by the ffi calls inside `crypto.lua` file. So the
linker stripped these symbols as it was not able to find their
usage in the rest of the C code. This produced SIGABRT on the
picodata startup when tarantool_lua_init() initialized the crypto
module.

Denis Smirnov authored 2 years ago and Yaroslav Dynnikov committed 1 year ago

An attempt to start picodata on macos returns an error:
symbol not found in flat namespace '_res_9_getservers'

The reason is that macos executables require libresolv.dylib to
use resolv.h.

Дмитрий Кибирев authored 2 years ago and Yaroslav Dynnikov committed 2 years ago

Also sign, deploy and check install.