Дмитрий Кольцов authored 6 months ago and Georgy Moshkin committed 6 months ago

All migrations are explicitly listed in manifest.yaml,
so there is no much sense in strict extension check

Closes #990

Kurdakov Alexander authored 6 months ago and Alexander Kurdakov committed 6 months ago

New argument `--timeout` for `picodata expel`.

Kurdakov Alexander authored 6 months ago and Alexander Kurdakov committed 6 months ago

New argument `--timeout` for `picodata connect`.

Note that after this merge request, we no longer validate whether the format
of the created object matches with the schema. Consequently, we do not
suppress errors if formats match anymore.

Before:
```sql
CREATE USER u WITH PASSWORD 'Passw0rd'
1
CREATE USER u WITH PASSWORD 'Passw0rd'
0
CREATE USER u WITH PASSWORD 'DifferentPassw0rd'
error: user already exists with different auth method
```

Now:
```sql
CREATE USER u WITH PASSWORD 'Passw0rd'
1
CREATE USER u WITH PASSWORD 'Passw0rd'
error: user u already exists
CREATE USER u WITH PASSWORD 'DifferentPassw0rd'
error: user u already exists
CREATE USER IF NOT EXISTS u WITH PASSWORD 'DifferentPassw0rd'
0
```

- In sql tests (test_limit) we encountered a bug,
when two different queries had the same hash
for executable subtree. We marked teset as xfail.
- The bug was caused by wrong calculation of hash
in sbroad. This was solved.
- Update sbroad submodule to commit with fix
- Remove xfail mark from test

See https://git.picodata.io/picodata/picodata/sbroad/-/issues/837

Needed because $CI_COMMIT_BRANCH is not available for tags

Note that now we don't have any (is this right?) tests that use pico.cas
which should be considering we plan to get rid of it in the near future.

Also we don't use `password` for cas operations, because the stored
procedure can only be called by the superuser and only the access
control checks rely on the `as_user` parameter.

See doc comments for RouteBuilder::register, but TL;DR it's never safe
to wrap a yielding function in a FnMut.
The user should instead do the regular internal mutability thing.

Up to this patch `instance_uuid` and `replicaset_uuid` were generated
using name-based UUID v3. So all instances named `i1` in all clusters
had the same UUID.

With this patch UUIDs become random v4. Particular UUID values are
generated in two locations:

1. `start_boot` (src/lib.rs)
2. `handle_join_request_and_wait` -> `build_instance` (src/rpc/join.rs)

Function `Instance::new()` is removed in favor of explicit struct
construction.

The main purpose is to reduce the usage of `Instance::new()` function.
It's going to be removed soon. No behavior changes are introduced yet.