Dmitry Ivanov authored 9 months ago and Dmitry Ivanov committed 9 months ago

This reverts commit 95807a30.

Dmitry Ivanov authored 9 months ago and Dmitry Ivanov committed 9 months ago

This reverts commit 9f8687cd.

Dmitry Ivanov authored 9 months ago and Dmitry Ivanov committed 9 months ago

Previously, we took advantage of a faster psycopg-binary, but this
dependency tends to fall short whenever we produce a bad server
packet, leading to obscure backtraces.

Maksim Kaitmazian authored 11 months ago and Dmitry Ivanov committed 9 months ago

pgproto used to interact with picodata through lua entrypoins, but after
making pgproto a picodata module, we can get rid of this lua layer and
simply call corresponding rust functions.

Maksim Kaitmazian authored 11 months ago and Dmitry Ivanov committed 9 months ago

After moving pgproto into picodata we can merge their implementations of
Describe into a singe module.

Maksim Kaitmazian authored 11 months ago and Dmitry Ivanov committed 9 months ago

The backend module implements the logic for handling postgres messages.
Note that this commit doesn't bring anything new: it just moves picodata's
handlers into pgproto.

See: https://git.picodata.io/picodata/picodata/picodata/-/issues/630

godzie44 authored 10 months ago and Georgy Moshkin committed 9 months ago

chore(plugins): `update_plugin_tiers` API call is split into `service_append_tier` and `service_remove_tier` calls

godzie44 authored 10 months ago and Georgy Moshkin committed 9 months ago

- add description field to `_pico_plugin` and `_pico_service`
- plugin loading: filter files by its extensions
- plugin loading: check possible service collisions
- plugin loading: now plugin searching at {plugin_dir}/{plugin_name} path
- now all errors between plugin and picodata wrapping with `BoxError` (this protects plugin caller from UAF)

This patch fixes a couple of warnings that look like this:

```
warning: creating a shared reference to mutable static is discouraged
  --> src/error_injection.rs:23:43
   |
23 |     let Some(injected_errors) = (unsafe { &INJECTED_ERRORS }) else {
   |                                           ^^^^^^^^^^^^^^^^ shared reference to mutable static
   |
   = note: for more information, see issue #114447 <https://github.com/rust-lang/rust/issues/114447>
   = note: this will be a hard error in the 2024 edition
   = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior
help: use `addr_of!` instead to create a raw pointer
   |
23 |     let Some(injected_errors) = (unsafe { addr_of!(INJECTED_ERRORS) }) else {
   |                                           ~~~~~~~~~~~~~~~~~~~~~~~~~
```

This commit fixes that non-admin users can't read queries from the query cache.
An attempt to read from the cache used to result in the following error:
sbroad error: failed to get space_def: box error: AccessDenied: Read access to space '_pico_table' is denied for user 'alex3'

Previously, an error would occur when a user ran the same query twice.
During the first execution, the query was prepared and cached. However,
on the second execution, the client attempted to retrieve the query from the
cache and encountered an access denied error.