box_access_check_ddl has error prone API

From discussion:

At this point grantor_id can be different from meta.user_id only in case it is an admin. In that case we still should su into meta.user_id, so that box_access_check_ddl precondition holds that owner should be equal to session user.

We've discussed this separately, when granting privilege vanilla uses grantor as the owner. This feels strange but for now it is simpler to copy vanilla approach. To catch this I've added an assert to box_access_check_ddl in tarantool and it triggered because I again passed owner of the object and not grantor as owner_id by intuition. So here we should pass grantor_id as the owner and as a user to switch to. Here I've changed it and tests pass: https://git.picodata.io/picodata/picodata/picodata/-/tree/dkr/track-owner-tests

mentioned in merge request picodata!767 (merged)

changed title from Return errors instead of asserts in box_access_check_ddl to box_access_check_ddl has error prone API

changed the description

I would also note that I'm unsure that this discussion belongs to tarantool-module. I find it highly unlikely that this API will be used without picodata context. So to me it is rather ok that it is exposed in somewhat raw form, because it allows to move faster on picodata side without changing module code. Maybe we should move box_access_check_ddl ffi stuff to picodata. Though we cannot do this for box_access_check_space because it is used by sbroad and tarantool-module happens to be the only way to share code between picodata and sbroad

closed