Skip to content
Snippets Groups Projects
  1. Nov 01, 2013
  2. Oct 30, 2013
  3. Oct 17, 2013
  4. Oct 16, 2013
  5. Oct 10, 2013
  6. Oct 06, 2013
  7. Aug 19, 2013
  8. Jul 11, 2013
  9. Jul 10, 2013
  10. Jun 28, 2013
  11. Jun 24, 2013
  12. Jun 20, 2013
  13. Jun 18, 2013
    • Konstantin Osipov's avatar
      tuple-access: code review fixes · af4164fb
      Konstantin Osipov authored
      Two significant changes (both arguable, since this patch is about
      taste by a large measure):
      
      1) Split tuple_seek() into two: tuple_rewind()
      and tuple_seek().
      
      tuple_rewind() simply initializes the iterator and
      sets it to 'before-first' position.
      tuple_seek() returns a field, and sets the iterator
      to the position after the returned field.
      
      Previosly there was only tuple_seek(), which required
      tuple_next() to get the field, and it was confusing whether
      or not tuple_next() after tuple_seek() is required.
      Indeed, the very code I chagned sometimes would
      call tuple_next() after tuple_seek() and sometimes would not.
      
      2) Move the return value of the iterator outside
      of iteration state.
      
      The advantage of "binding" the out parameters of the iterator to
      iterator state is that you bind once, and don't need to supply out
      parameters into every call to tuple_next() function. It also makes
      it easy to add extra out parameters for bind in the future (field
      data type, flags, etc).
      
      This makes "binding" technique popular in database driver
      APIs. Binding makes API more stable, which is also
      important in drivers.
      
      In this case, however, binding adds for extra lines of code
      and (possibly) few extra instructions. Plus, since
      this is an internal API which we can change any day,
      its stability is not as important. So it seems that for
      now we're better of with an API which is a bit
      more concise/efficient, and can switch to using binding later,
      if needed.
      af4164fb
    • Dmitry E. Oboukhov's avatar
      a3767dcc
  14. Jun 14, 2013
  15. Jun 08, 2013
  16. Jun 07, 2013
  17. Jun 06, 2013
  18. Jun 05, 2013
  19. Jun 04, 2013
  20. Jun 02, 2013
  21. May 16, 2013
  22. May 04, 2013
    • Konstantin Osipov's avatar
      Tarantool/Box -> Tarantool. · 6af037d1
      Konstantin Osipov authored
      This messes the old "core/module" paradigm quite a bit, but Box,
      while a neat name, was confusing people.
      
      tarantool_box is preserved as the daemon name.
      6af037d1
  23. Apr 25, 2013
  24. Apr 10, 2013
  25. Mar 26, 2013
    • Konstantin Osipov's avatar
      Fix broken (crashing) command line client on Ubuntu Precise · 3219428f
      Konstantin Osipov authored
      libreadline already goes with libhistory compiled in,
      no reason to add it to the dynamically linked library
      list.
      Apparently, explicitly listing libhistory leads to
      the dl loader pre-loading it instead of the compiled-in
      version, which, in turn, leads to a crash on the first
      history search in the command line client.
      
      The fix is to remove cmake dependency on libhistory
      as well as on libncurses, which we don't need either
      (always require libtermcap).
      3219428f
  26. Mar 07, 2013
    • Konstantin Osipov's avatar
      Give CPACK a pre-edited spec file. · f920175c
      Konstantin Osipov authored
      twistd by default starts with umask 077.
      This is why buildbot has umask setting.
      
      rpm by default takes file and directory umask
      from the build directory.
      
      When building tarantool rpm under buildbot,
      twistd default umask was inherited. Thus
      all paths were created in rwx-- mode.
      
      Now add to this cmake bug CMake bug 0012864.
      That is, by default, cmake cpack generator
      adds %dir directive for every intermediate
      dir into the spec.
      
      E.g. if there is a destination file /etc/rc.d/foo,
      the spec gets
      %dir /etc
      %dir /etc/rc.d
      
      Together with the default dir access mask of
      twistd this nicely messed up our rpm install: an
      install of Tarantool 1.4.8-59 rpm for CentOS would change
      /etc and /usr access mode to 700.
      
      Two things are done about that: Tarantool no longer
      uses a cpack generated cpeck file. Extraneous %dir
      directives are removed from the spec file. This
      should minimize the damage of a broken twistd config,
      should it happen again.
      
      All buildslaves are reconfigured and restarted with umask 022.
      f920175c
  27. Feb 20, 2013
Loading