This patch removes an old CMake kludge, which sets CMAKE_SYSTEM_PROCESSOR
to "x86_64" on all 64-bit architectures, even on ARM (on Darwin).

Closes #7495

NO_DOC=bugfix

(cherry picked from commit d76be7ef)

backtrace_collect() is suffering from the same issue as coro_transfer(),
see commit 215630e6 ("coro: update sp before saving registers to a
stack frame").

It stores x19-x30 and d8-d15 registers to the stack, but only after that
it updates the stack pointer. If a SIGALRM signal is delivered during
the execution of backtrace_collect, the signal handler will use the
stack starting from current sp, thus corrupting the saved registers.

Fix this by updating the stack pointer at the beginning of
backtrace_collect. The constraint of the input operand `bt` is changed
from "m" to "r" to force `bt` always be passed to the inline assembly
via the register. Passing on stack will not work after this fix.

Closes #7985

NO_DOC=bugfix
NO_TEST=Hard to create a stable reproducer

(cherry picked from commit 9adc4aa7)

During rollback read trackers are rebound to newer or older story, if
present. The problem with the current logic is that read trackers are
basically rebound in the first available index: all information about key
parts read from other indexes gets lost — rebind read trackers in all
indexes.

Closes #7828

NO_DOC=bugfix

(cherry picked from commit 559b27db)

We assumed that the successor tuple's story could not get garbage collected
on clarify of result tuple in `tree_iterator_start`, since they coincide in
case of regular iterators. But this is not the case for reverse iterators:
the result tuple is of-by-one from the successor, which means the
successor's story can get garbage collected along with the tuple itself
getting deleted, leading to use-after-free of successor: remove garbage
collection from `memtx_tx_tuple_clarify` and call it manually.

The crash in #7756 revealed that the `put` in transaction manager's story
hash table was performed incorrectly: fix it and add an assertion that
nothing was replaced.

Closes #7755
Closes #7756

NO_DOC=bugfix

(cherry picked from commit 651535bc)

Firstly, there is an assertion that checks if replica_id haven't been
changed after it's registration. Let's replace this assertion with warning
message about id being altered - new id will be used for affected replica.

Secondly, if before_replace trigger, set on space _cluster, returns nil,
tarantool will crash with segmentation fault. This patch handles the case.

Closes #7846

NO_DOC=bugfix

(cherry picked from commit a470bb63)

The test fails with:

  not ok 2 ...ty_or_nil_select.test_log_entry_presence_for_memtx_user_space
  gh_6539_log_user_space_empty_or_nil_select_test.lua:122: log must contain
  a critical entry about `box.space.test_memtx:select({0}, {limit = 1001,
  iterator = "ALL"})` call on a memtx user space
  expected: a value evaluating to true, actual: nil

Looks like it happens, because g.server:grep_log() is executed before
g.server:eval(call) completes writing to the log.
In other tests grep_log() is wrapped into t.helpers.retrying() in order
to avoid such issues, so do the same here.

May close tarantool/tarantool-qa#264

NO_DOC=test fix
NO_CHANGELOG=test fix

(cherry picked from commit e4f1c891)

The read iterator skips DELETE statements. If a skipped DELETE statement
was read from the transaction write set, the read iterator breaks the
current cache chain by clearing vy_read_iterator::last_cached, because
the deleted tuple may actually be present at a lower level so adding
a gap there until the transaction is committed would be incorrect, see
commit dd926790 ("vinyl: fix a bug in adding of a cache chain").

The problem is vy_cache_add() assumes that if last_cached is NULL
the tuple added to the cache must be the first tuple that meets the
iteration criteria and sets the cache node boundary level accordingly.
This may lead to the previous tuple being erroneously skipped later
in case the transaction that attempted to delete it is rolled back.

Fix this issue by passing the flag indicating if the current tuple is
the first result of the iteration explicitly to vy_cache_add().

Closes #7947

NO_DOC=bug fix

(cherry picked from commit e00f16e4)

* Ensure correct stack top for OOM error message.
* x86/x64: Check for jcc when using xor r,r in emit_loadi().
* Save trace recorder state around VM event call.
* Fix io.close() error message.
* Fix io.close().
* Cleanup math function compilation and fix inconsistencies.

Closes #3840
Closes #6782
Part of #7230

NO_DOC=LuaJIT submodule bump
NO_TEST=LuaJIT submodule bump

If you shut down the replica and delete all xlog files on it, and it
reconnect to the master, may occur the restore error. Because there are
intermediate xlog files between the snap on the replica and the last
xlog on the master. When restoring xlog files on the replica, it can be
occurred that prev_signature < signature and this will lead to the crash
of the master.

Closes #5158

NO_DOC=bugfix

(cherry picked from commit f53fde16)

If create_index('...', {parts = {...}}) is called without the `collation`
option, then use collation from the space format.

Closes #5104

@TarantoolBot document
Title: Index options are inherited from the space format
Root document: https://www.tarantool.io/en/doc/latest/reference/reference_lua/box_space/create_index/

If `is_nullable` and `collation` options are not set, then they are
inherited from the space format, if applicable for that field type.

(cherry picked from commit f2f40ff7)

Local spaces can be written to on any replica, even on a read-only one.
This makes sense, because local space data isn't replicated, so it can't
lead to a conflict or violate consistency anyhow.

However, when used together with synchronous replication, local spaces
can't be written to by anyone but the synchro queue owner:
```
tarantool> box.info.synchro.queue.len
---
- 1
...
tarantool> box.space.loc:replace{2}
---
- error: Found uncommitted sync transactions from other instance with id 1
...
```
Fix this and allow to put transactions touching local spaces to the
synchro queue even if it is claimed by someone else.

Note, we can't let local transactions bypass the synchro queue completely.
This would lead to consistency loss in a case when synchro queue
contains a transaction [sync_row, local_row], and another transcation
[local_row], probably based on the sync transaction, bypasses the limbo.

Closes #7592

NO_DOC=bugfix

(cherry picked from commit fb5a990f)

Existence of txn_commit_ro_stmt assumes there is txn_rollback_ro_stmt,
but it does not exist. Instead, currently we use txn_rollback_stmt, which
has nothing to do with 'ro' statements, and will just rollback the
currently running normal statement.

As an example, consider box_index_iterator. It calls txn_begin_ro_stmt,
which does not produce any artefacts in an existing `struct txn`. But in
case of the iterator creation fail it calls txn_rollback_stmt, which will
rollback the currently being executed 'rw' statement.

Drop txn_commit_ro_stmt and introduce txn_end_ro_stmt, which is called
regardless of 'ro' statement result.

NO_DOC=bugfix

Closes #5501

(cherry picked from commit d94eb857)

Currently AArch64 version of coro_transfer stores x19-x30 and d8-d15
registers to the stack, but only after that it updates the stack pointer.
If a SIGALRM signal is delivered during the execution of coro_transfer,
the signal handler will use the stack starting from current sp, thus
corrupting the saved registers.

Fix this by updating the stack pointer at the beginning of coro_transfer.
x2 register is still required, because `str sp, [x0, #0]` is invalid in
the A64 instruction set.

Closes #7484
Closes #7523

NO_DOC=bugfix
NO_TEST=Hard to create a stable reproducer,
        mostly covered by existing tests.

(cherry picked from commit 215630e6)

The test fails with:

  master | 2022-11-11 09:03:32.093 [4128822] main/103/default.lua F>
  can't initialize storage: unlink, called on fd 30, aka unix/:(socket),
  peer of unix/:(socket): Address already in use

Looks like it happens, because both test cases share the socket path.
The fix is the same as in commit 3f86cd04 ("test: fix flaky
'test_ignore_with_force_recovery'") - use different socket paths.

Follow-up commit b2dab5f4 ("memtx: log bad row on snapshot recovery
error").

NO_DOC=test fix
NO_CHANGELOG=test fix

(cherry picked from commit 3d3e9dea)

Generate changelog for 2.10.4 release.
Also, clean changelogs/unreleased folder.

NO_DOC=no code changes
NO_TEST=no code changes
NO_CHANGELOG=no code changes

Fix wording, punctuation, and formatting.

NO_CHANGELOG=changelog
NO_DOC=changelog
NO_TEST=changelog

* ci: add workflow for legacy CMake GNU Make build
* build: fix build with the original Makefile
* ci: drop integration for macOS with disabled GC64
* ci: add 'self-hosted' tag to runs-on
* ci: use Ninja generator in CI workflows
* ci: use CMAKE_EXTRA_PARAMS in LuaJIT integration
* test: replace result variable in MakeLuaPath.cmake
* ci: merge Linux and macOS workflows
* ci: merge x86_64 and ARM64 workflows
* ci: remove arch prefix for macOS M1 workflow
* ci: remove excess parallel level setup
* ci: use out of source build in GitHub Actions
* test: fix tarantool suite for out of source build
* test: introduce MakeLuaPath.cmake helper
* test: introduce utils.profilename helper

NO_DOC=LuaJIT submodule bump
NO_TEST=LuaJIT submodule bum
NO_CHANGELOG=ci

We log bad row on xlog recovery error. We should log bad row on snapshot
recovery error ase well to ease debugging.

Closes #7917

NO_DOC=bug fix

(cherry picked from commit b2dab5f4)

fh:pread() will raise a clear error on wrong arguments.

Closes #4963

NO_DOC=bugfix
NO_CHANGELOG=bugfix

(cherry picked from commit 22ecf87a)

If we find a newer story in the secondary index, the statement of which
deletes a story added in the same transaction, there can be two cases: if
the secondary index is not unique, then it is conflicted by primary index
(since it's `cmp_def` is extended with the primary index's
`key_def`, every history chain in the secondary index has a corresponding
chain in the primary index). Otherwise, the prepared story must also
conflict the newer one.

Summarizing the above: remove the unnecessary check.

Closes #7761

NO_DOC=bugfix

(cherry picked from commit a1ba58d2)

Gap trackers are stored in the story at the top of the history chain (see
`memtx_tx_story_{un}link_top_light`): following this logic, during rollback
we need to rebind them to the older story. We already maintain this in
56cf737c, since a story is not retained iff it has a newer story (which
means it does not store trackers) or if it has an older story (in which
case rebinding is done in `memtx_tx_story_{un}link_top_light`): add an
assertion that a story deleted during rollback does not have any gap
trackers and a test for this case.

Follow-up 56cf737c

NO_CHANGELOG=internal
NO_DOC=internal

(cherry picked from commit e0114464)

`memtx_tx_story_unlink_both` is called in two separate contexts: on space
delete and on rollback. In the former case we need to simply unlink the
story, while in the latter case we need to rebind read and gap trackers,
and, perhaps do some other logic in the future. Calling
`memtx_tx_story_unlink_both` in the former context can trigger assertion:
split the function and its helpers into two separate functions for each
case, grouping the common logic into third `*_common` functions.

Closes #7757

NO_DOC=bugfix

(cherry picked from commit 21d3af42)

Since this feature is compiler-dependent, we need to skip the test if the
server was build with a compiler that does not support the
`-fmacro-prefix-map` flag.

Follow-up #7808

NO_CHANGELOG=test
NO_DOC=test
NO_TEST=test

(cherry picked from commit ffb17a55)

Currently, `tarantool.build.compiler` stores the `CMAKE_C_COMPILER` and
`CMAKE_CXX_COMPILER` strings from CMake, which are basically paths to the
compiler used for build, and are usually set to `/usr/bin/cc` and
`/usr/bin/c++` accordingly, which does not yield any useful information:
instead, set it to `${CMAKE_C_COMPILER_ID}-${CMAKE_C_COMPILER_VERSION}`,
assuming the same compiler is used for building C and C++.

Closes #7888

@TarantoolBot document
Title: change of information shown in compiler information
Compiler information provided by `tarantool --version` and
`tarantool.build.compiler` now show
`${CMAKE_C_COMPILER_ID}-${CMAKE_C_COMPILER_VERSION}` instead of paths to C
and C++ compilers used to build tarantool, for instance:

```console
tarantool> tarantool.build.compiler

---
- Clang-14.0.0.14000029
...

tarantool> tarantool.build.compiler

---
- GNU-12.2.0
...
```

(cherry picked from commit aec0393e)

The `-Wa,--debug-prefix-map` compiler flag breaks GNU-based LTO, and also
we cannot reliably test this feature.

Follow-up 256da010

NO_CHANGELOG=bugfix
NO_DOC=bugfix
NO_TEST=bugfix

(cherry picked from commit 41c7db41)

This patch renames index_def_is_valid() to index_def_check() and makes
it return 0 or -1 because that function sets a diag.

NO_DOC=refactoring
NO_TEST=refactoring
NO_CHANGELOG=refactoring

(cherry picked from commit 5df76ade)

Prior to this patch, there was no error of creating too many indexes in
SQL. This led to a situation where indexes with IDs greater than
BOX_INDEX_MAX were not created, but no error was thrown. For example, in
the case of CREATE TABLE, only indexes with an ID less than
BOX_INDEX_MAX were created. Now an error is thrown when creating too
many indexes.

Closes #5526

NO_DOC=bugfix

(cherry picked from commit 2705e227)

After this patch, the list of auto-increment IDs will be reset before
executing the prepared statement.

Closes #6422

NO_DOC=bugfix

(cherry picked from commit 5eefa06f)

In case the space format is changed after inserting tuples, the new
format contains new fields, and a new index is created that works with
those new fields, it is possible to get an assertion during SELECT. This
problem was fixed in this path.

Closes #5183

NO_DOC=bugfix

(cherry picked from commit 440a0f8c)

The async transactions should always wait for LSN from the master after
switch to replica.

Closes tarantool/tarantool-qa#274

NO_CHANGELOG=testing
NO_DOC=testing

(cherry picked from commit 0fbdfd0f)

The bug was fixed in https://github.com/tarantool/msgpuck/pull/24.

This commit just bumps the submodule.

Closes https://github.com/tarantool/security/issues/18

NO_DOC=bug fix

(cherry picked from commit dec0e022)

Add a forgotten changelog entry.

Follow-up https://github.com/tarantool/security/issues/17

NO_DOC=changelog
NO_TEST=changelog

(cherry picked from commit 2be81637)

decimal_unpack() and hence mp_decode_decimal() didn't check length of
digits array, overflowing the output structure.

Fix that and a couple of typos in comments as well.

Closes https://github.com/tarantool/security/issues/17

NO_DOC=security
NO_CHANGELOG=security

(cherry picked from commit 142c324e)

Some internal modules have been recently copied to luatest repo [1,2,3]
and now they can be safely removed, and the corresponding functionality
from luatest can be used instead.

Affected modules:

- test/luatest_helpers/misc.lua
- test/luatest_helpers/fiber.lua
- test/luatest_helpers/proxy/*

[1] https://github.com/tarantool/luatest/pull/247
[2] https://github.com/tarantool/luatest/pull/248
[3] https://github.com/tarantool/luatest/pull/255

Closes tarantool/luatest#238
Closes tarantool/luatest#251

NO_DOC=testing stuff
NO_TEST=testing stuff
NO_CHANGELOG=testing stuff

(cherry picked from commit 54bd77ad)

Bump test-run to new version with the following improvements:

- Bump luatest to 0.5.7-6-gee1f5c1 [1]
- Fix detection of debug builds [2]

[1] https://github.com/tarantool/test-run/pull/354
[2] https://github.com/tarantool/test-run/pull/356

Part of tarantool/luatest#238
Part of tarantool/luatest#251

NO_DOC=testing stuff
NO_TEST=testing stuff
NO_CHANGELOG=testing stuff

(cherry picked from commit 002b1ffc)

Drop unused code and arguments to fix the warning:

src/lua/log.lua:223:11: variable log_type is never accessed

Follow-up commit 21c6fa6e ("say: enable json log format with
syslog").

NO_DOC=luacheck
NO_TEST=luacheck
NO_CHANGELOG=luacheck

All the heavy lifting was done in the previous commit that dropped
the syslog formatter. This commit just removes the checks that forbid
using syslog with json.

Closes #7860

@TarantoolBot document
Title: JSON log format can now be used with syslog

The configuration reference says that syslog is incompatible with
the JSON log format:

https://www.tarantool.io/en/doc/latest/reference/configuration/#confval-log_format

This isn't true anymore. If JSON is used with syslog, then a JSON
message body is appended to the syslog header.

See https://github.com/tarantool/tarantool/issues/7860.

(cherry picked from commit ec1747b4)

All messages written to syslog must have a header, which contains the
current time, message severity, and process identity, so we have a
special formatter function for syslog. As a result, the syslog log
destination is incompatible with the json log format, which has its own
formatter function. This is confusing, because there's nothing that
prevents us from writing json in the log entry body to syslog - we just
need to prepend the message with a proper header.

As a preparation for befriending json and syslog, let's get rid of the
syslog formatter function and instead write the header right in log_vsay
in case logs are written to syslog. We just need to strip the duplicate
information from the log entry in say_format_plain so as not to print
the time and pid twice.

Needed for #7860

NO_DOC=refactoring
NO_TEST=refactoring
NO_CHANGELOG=refactoring

(cherry picked from commit 11ac72bd)

We have three places in say.c where we peform exactly the same steps to
obtain the current time. Let's add a helper function to avoid code and
comments duplication.

NO_DOC=refactoring
NO_TEST=refactoring
NO_CHANGELOG=refactoring

(cherry picked from commit dd825873)

It's a global althoug static variable so better use say_ prefix so as
not to mix it with a local variable.

NO_DOC=refactoring
NO_TEST=refactoring
NO_CHANGELOG=refactoring

(cherry picked from commit 0920ab39)