tests: add coverage for statement-level rollback

Add a functional test for statement-level rollback.

Check that rollback actually frees the rolled back data in wal_off/oom.test.
Also check that slabs are reused and returned to the pool when they
have no tuples.

src/lua/log.lua

@@ -23,7 +23,7 @@ ffi.cdef[[
 
 local function say(level, fmt, ...)
     local debug = require('debug')
-    local str = string.format(fmt, ...)
+    local str = string.format(tostring(fmt), ...)
     local frame = debug.getinfo(3, "Sl")
     local line = 0
     local file = 'eval'

test/box/transaction.result

@@ -12,7 +12,7 @@ box.begin() box.begin();
 box.commit();
 ---
 ...
--- double commit - implicit start of transaction 
+-- double commit - implicit start of transaction
 box.begin() box.commit() box.commit();
 ---
 ...
@@ -30,7 +30,7 @@ box.begin() box.rollback() box.rollback();
 box.begin() box.rollback();
 ---
 ...
--- no current transaction - implicit begin 
+-- no current transaction - implicit begin
 box.commit();
 ---
 ...
@@ -261,23 +261,23 @@ s:drop();
 ---
 ...
 --# setopt delimiter ''
-tester = box.schema.space.create('tester')
+test = box.schema.space.create('test')
 ---
 ...
-tindex = tester:create_index('primary')
+tindex = test:create_index('primary')
 ---
 ...
-box.begin() tester:insert{1} box.rollback()
+box.begin() test:insert{1} box.rollback()
 ---
 ...
-tester:select{1}
+test:select{1}
 ---
 - []
 ...
-box.begin() tester:insert{1} box.commit()
+box.begin() test:insert{1} box.commit()
 ---
 ...
-tester:select{1}
+test:select{1}
 ---
 - - [1]
 ...
@@ -310,3 +310,41 @@ cn = nil
 box.schema.func.drop('test')
 ---
 ...
+--
+-- Test statement-level rollback
+--
+box.space.test:truncate()
+---
+...
+function insert(a) box.space.test:insert(a) end
+---
+...
+--# setopt delimiter ';'
+function dup_key()
+    box.begin()
+    box.space.test:insert{1}
+    status, _ = pcall(insert, {1})
+    if not status then
+        if box.error.last().code ~= box.error.TUPLE_FOUND then
+            box.error.raise()
+        end
+        box.space.test:insert{2}
+    end
+    box.commit()
+end;
+---
+...
+--# setopt delimiter ''
+dup_key()
+---
+...
+box.space.test:select{}
+---
+- - [1]
+  - [2]
+...
+-- cleanup
+--
+box.space.test:drop()
+---
+...

test/box/transaction.test.lua

@@ -5,7 +5,7 @@ box.begin() box.commit();
 box.begin() box.begin();
 -- no active transaction since exception rolled it back
 box.commit();
--- double commit - implicit start of transaction 
+-- double commit - implicit start of transaction
 box.begin() box.commit() box.commit();
 -- commit if not started - implicit start of transaction
 box.commit();
@@ -15,7 +15,7 @@ box.rollback()
 box.begin() box.rollback() box.rollback();
 -- rollback of an empty trans - ends transaction
 box.begin() box.rollback();
--- no current transaction - implicit begin 
+-- no current transaction - implicit begin
 box.commit();
 fiber = require('fiber');
 function sloppy()
@@ -121,12 +121,12 @@ t;
 s:select{};
 s:drop();
 --# setopt delimiter ''
-tester = box.schema.space.create('tester')
-tindex = tester:create_index('primary')
-box.begin() tester:insert{1} box.rollback()
-tester:select{1}
-box.begin() tester:insert{1} box.commit()
-tester:select{1}
+test = box.schema.space.create('test')
+tindex = test:create_index('primary')
+box.begin() test:insert{1} box.rollback()
+test:select{1}
+box.begin() test:insert{1} box.commit()
+test:select{1}
 --
 -- gh-793 box.rollback() is not invoked after CALL
 --
@@ -138,3 +138,28 @@ cn:call('test') -- first CALL starts transaction
 cn:call('test') -- iproto reuses fiber on the second call
 cn = nil
 box.schema.func.drop('test')
+
+--
+-- Test statement-level rollback
+--
+box.space.test:truncate()
+function insert(a) box.space.test:insert(a) end
+--# setopt delimiter ';'
+function dup_key()
+    box.begin()
+    box.space.test:insert{1}
+    status, _ = pcall(insert, {1})
+    if not status then
+        if box.error.last().code ~= box.error.TUPLE_FOUND then
+            box.error.raise()
+        end
+        box.space.test:insert{2}
+    end
+    box.commit()
+end;
+--# setopt delimiter ''
+dup_key()
+box.space.test:select{}
+-- cleanup
+--
+box.space.test:drop()

test/wal_off/oom.result

@@ -152,13 +152,54 @@ space.index['primary']:get{0}
 ---
 - [0, 'test']
 ...
-space:drop()
+collectgarbage('collect')
 ---
+- 0
 ...
-t = nil
+--
+-- Check that statement-level rollback does not leak tuples
+--
+space:truncate()
 ---
 ...
-collectgarbage('collect')
+function insert(a) space:insert(a) end
+---
+...
+--# setopt delimiter ';'
+function dup_key()
+    box.begin()
+    space:insert{1}
+    local i = 1
+    while i < 2000 do
+        status, _ = pcall(insert, {1, string.rep('test', i)})
+        if status then
+            error('Unexpected success when inserting a duplicate')
+        end
+        if box.error.last().code ~= box.error.TUPLE_FOUND then
+            box.error.raise()
+        end
+        i = i + 1
+    end
+    box.commit()
+    return i
+end;
+---
+...
+--# setopt delimiter ''
+dup_key()
+---
+- 2000
+...
+space:select{}
+---
+- - [1]
+...
+--
+-- Cleanup
+--
+space:drop()
+---
+...
+t = nil
 ---
-- 0
 ...

test/wal_off/oom.test.lua

@@ -43,6 +43,35 @@ t
 space:truncate()
 space:insert{0, 'test'}
 space.index['primary']:get{0}
+collectgarbage('collect')
+--
+-- Check that statement-level rollback does not leak tuples
+--
+space:truncate()
+function insert(a) space:insert(a) end
+--# setopt delimiter ';'
+function dup_key()
+    box.begin()
+    space:insert{1}
+    local i = 1
+    while i < 2000 do
+        status, _ = pcall(insert, {1, string.rep('test', i)})
+        if status then
+            error('Unexpected success when inserting a duplicate')
+        end
+        if box.error.last().code ~= box.error.TUPLE_FOUND then
+            box.error.raise()
+        end
+        i = i + 1
+    end
+    box.commit()
+    return i
+end;
+--# setopt delimiter ''
+dup_key()
+space:select{}
+--
+-- Cleanup
+--
 space:drop()
 t = nil
-collectgarbage('collect')