Skip to content
Snippets Groups Projects

fix(webui): set sane timeout for get_instances_data calls

Merged Дмитрий Кольцов requested to merge dkoltsov/fix-timeout into master

Summary

  • fix(http_server): consider timeout for establishin TCP connections in HTTP server

Due to the bug in RPC (see #991) RPC call timeout does not account TCP connection establishment. So a request to a peer without a connection was not aborted due to timeout. Force a timeout directly for a future returned by RPC to avoid this

Closes #991

  • fix(webui): set sane timeout for get_instances_data calls

Previously webUI failed to retrieve data about instances if one of those was dead. The cause was that webUI HTTP request timeout was less than get_instances_data timeout.

References #943 (closed)


  • Close #...
  • Cherry-pick to: none
  • Docs follow-up: not necessary
Edited by Дмитрий Кольцов

Merge request reports

Pipeline #52508 passed

Pipeline passed for 0785fa25 on dkoltsov/fix-timeout

Approved by

Merged by Dmitry RodionovDmitry Rodionov 6 months ago (Oct 7, 2024 11:23am UTC)

Pipeline #52509 failed

Pipeline: picodata-in-docker

#52510

    Pipeline: sbroad-nt

    #52511

      Pipeline failed for 0785fa25 on master

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
      Please register or sign in to reply
      Loading