It makes no sence to perform a wait, and `docs/clustering.md` already
states that it's skipped. Anyway, the result is unused.

The case is wierd, but it could lead to box error and panic.

1. Merge duplicating tests
2. Provide detailed comments

Yaroslav Dynnikov authored 2 years ago and Georgy Moshkin committed 2 years ago

Part of https://git.picodata.io/picodata/picodata/picodata/-/issues/98

Yaroslav Dynnikov authored 2 years ago and Georgy Moshkin committed 2 years ago

Part of https://git.picodata.io/picodata/picodata/picodata/-/issues/98

Initially, JoinResponse was supplied with every single peer in cluster.
If the cluster is big enough, it results in the "max tuple size limit
reached" error. In fact, only voters are needed for the raft to
operate normally.

Since a recent commit, message destination (`to` field) is taken into
account. Make it correct to avoid skipping.

Joint state latch was mistakenly dropped, and conf_change_loop couldn't
receive a notification.

Also assert it's not overridden by mistake.

It allows us to use raft::EntryType directly without obscure i32 tricks.