- Aug 14, 2024
-
-
-
-
-
-
-
-
-
-
-
-
Previously function was ~700 loc. The patch splits out the logic of conversion from ir node to operation. Previously there were two stages, initial validation that constructed intermediate structure and then intermediate structure was transformed into Op potentially several times in case of retries. The patch removes intermediate conversion by direct mapping from ir node to op. It makes reading more convenient since there is no need to jump back and forth between initial checks and actual Op construction. Another benefit is that some checks need to be repeated on each retry since retries originate from conflicts and conflicts change system state. So in newer state operation may no longer make sense. By coupling both operations together there is no way a check can be missed in the retry phase. We still do some cloning here and there. We can probably improve on that by constructing Op once and then adjusting it in place for conflicts but since retries should be rare in practice it shouldnt be a problem. Additionally we do a lot of conversion between SmolStr and String. We need to use SmolStr in more placese inside picodata so we dont need to do that.
-
Вартан Бабаян authored
-
Georgy Moshkin authored
We use migration file from the manifest file to store it in the system tables and to display logging messages. But the full filepath is used for reading files from the disk.
-
Georgy Moshkin authored
-
Georgy Moshkin authored
-
Georgy Moshkin authored
-
-
- Aug 12, 2024
-
-
Кирилл Безуглый authored
-
Georgy Moshkin authored
-
Georgy Moshkin authored
-
-
Maksim Kaitmazian authored
-
Вартан Бабаян authored
-
-
use split_once instead split
-
Closes #651
-
Closes #584
-
Closes #741
-
Closes #682
- Aug 09, 2024
-
-
Georgy Moshkin authored
-
Maksim Kaitmazian authored
-
- Aug 08, 2024
-
-
Кирилл Безуглый authored
-
Maksim Kaitmazian authored
-
- Aug 06, 2024
-
-
Closes 813
-
Closes 798
-
- Aug 02, 2024
-
-
-
Вартан Бабаян authored
-
Maksim Kaitmazian authored
-