Kurdakov Alexander authored 5 months ago and Егор Ивков committed 2 months ago

Prints all current members of the cluster and their status.

The same result can be achieved by executing SQL
query to system tables.

Now panics from plugin code are handled the same way panics from
picodata code, that is they log the backtrace to the tarantool logger
and then abort the process.

This patch boils down to the following improvements:

* Various linkage-related shenanigans have been documented and revamped.
* All logic to build tarantool-sys is now encapsulated in tarantool-build.
* Most of the magic `println!`s are now encapsulated in build-rs-helpers.
* Unsound function `export_symbols` has been dropped in favor of
  explicit linker flags (`--require-defined` for linux & `-u` for mac).
* `TarantoolBuildRoot` is now in charge of building and linking
  tarantool libs. It defines the build tree via path helper functions.
* Picodata's `build.rs` should be a little easier to read.

Dmitry Ivanov authored 4 months ago and Dmitry Ivanov committed 4 months ago

This patch boils down to the following changes:

* Register the hook for all cli commands (previously only `run`).
* Print the whole text as one log line to prevent splitting.
* Always capture backtrace regardless of RUST_BACKTRACE and such.

Currently, we act under the assumption that every panic is severe
and should abort the whole process. This **does not** have to always
be the case -- for instance, we might recover from a mild panic in
Sbroad's query planner if the application state hasn't been corrupted.
A happy outcome isn't completely ruled out.

In the future we might change this behavior by replacing the
uncompromising global panic hook with a combo of strategically placed
`std::panic::catch_unwind`s and a panic hook for non-unwinding panics.

At the moment of writing, `PanicHookInfo::can_unwind` is still unstable.

main.rs has grown a bit, adding new stuff to it doesnt feel natural.
Smaller files are easier to digest. For me it is easier to find stuff
when there are less files on the top level and some hierarchy shows.
where to go. A while back I wanted to move sql command to separate
file but there is already sql.rs on the top level.

This patch solves this issue.

This patch adds new command `picodata sql`. Arguments are the same as `picodata connect`. The idea would be to eventually replace picodata connect with this version.

Simple prerequisites for testing with auth:

```lua
pico.create_user("Yoda", "12341234")
pico.grant_privilege("Yoda", "execute", "role", "super")
```
Super grant wont be needed in the future when access control will be tuned properly (access to system spaces, context: https://git.picodata.io/picodata/picodata/picodata/-/merge_requests/663).

Then run `target/debug/picodata run` in one terminal and `target/debug/picodata sql Yoda@localhost:3301` in another one

Features:
- Usual lib readline goodies, backward/forward search etc. Provided by [rustyline](https://lib.rs/crates/rustyline)
- Simple file based history (~/.picodata_history by default)
- Displays result sets in ascii tables. Styling can be customized if needed. Here we're using [comfy-table](https://lib.rs/crates/comfy-table) library
- If you type `\e` command your `$EDITOR` will be opened so you can write the query there. Once you close your editor the query will be executed (suggested by @funbringer)

There are a lot of things we can add. Completion, highlighting, more special commands.

Close #363 

Allow connecting interactive console over a unix socket `picodata run
--console-sock`. Use `picodata connect --unix` to connect.

This reverts commit 5a5a1919.

When picodata process forks, the parent and child are connected by
two unix pipes:
- the fuse (used by the child to detect parent's death);
- the ipc channel (used by the parent to get on-exit messages from
  the child to change its state in the finite-state machine);

The problem was that the parent tried to read the message from the
pipe right after the fork (and before the child's exit). Usually
the pipe was empty at that moment and the parent collected serde's
"failed to fill whole buffer" error instead the real message provided
by the child.

NB: this commit needs the fixes in tarantool-sys,
so we have to update the git submodule.

Dmitry Travyan authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

The following commands are affected:

- `picodata connect [user@][host][:port]`
- `picodata run --peer`
- `picodata run --listen`
- `picodata run --http-listen`
- `picodata run --advertise`
- `picodata expel --peer`

Only `picodata connect` respects the username. Other options just ignore
it.

- Provide new `struct Address`
- Replace `try_parse_address` function with `impl FromStr for Address`.
- Provide both unit and pytests

Dmitry Travyan authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

This patch introduces `picodata connect` CLI command. It allows
connecting to interactive lua console of a picodata instance via iproto
The whole implementation comes down to invoking a lua script with
`require("console").start()`.