And remove unused index_def_check_xc().

As index_def_dup() never returns NULL anymore, change index_create() and
index_read_view_create() return type to `void` and update their callers.

NO_DOC=refactoring
NO_TEST=refactoring
NO_CHANGELOG=refactoring