Skip to content
Snippets Groups Projects
user avatar
Alexander V. Tikhonov authored
Fixed Mojave Mac build with setting MACOSX_DEPLOYMENT_TARGET environment
variable for LuaJIT's Makefile. This variable specifies the minimum
version of OS X on which the target binaries are to be deployed.

The reason why we need to set MACOSX_DEPLOYMENT_TARGET to at least 10.6
is that 10.4 SDK (which is set by default in LuaJIT's Makefile) is not
longer included in Mac OS X Mojave 10.14.

See also https://github.com/LuaJIT/LuaJIT/issues/484

We already set -Wl,-macosx_version_min,10.6 (-macosx_version_min and
MACOSX_DEPLOYMENT_TARGET are synonymous), but it affects only a linker.
We possibly should remove -macosx_version_min, because it superseded by
MACOSX_DEPLOYMENT_TARGET, but it should be done with verification that
the original problem really fixed by the new way to set a deployment
target. This is not part of this patch.

Removed virtualenv usage in CI for OS X (so pip just installs packages
into a system), because OS X Mojave 10.14 does not offer virtualenv by
default.

Fixed #3797
eb964471
History
Name Last commit Last update
..