- Jun 18, 2013
-
-
Konstantin Osipov authored
Two significant changes (both arguable, since this patch is about taste by a large measure): 1) Split tuple_seek() into two: tuple_rewind() and tuple_seek(). tuple_rewind() simply initializes the iterator and sets it to 'before-first' position. tuple_seek() returns a field, and sets the iterator to the position after the returned field. Previosly there was only tuple_seek(), which required tuple_next() to get the field, and it was confusing whether or not tuple_next() after tuple_seek() is required. Indeed, the very code I chagned sometimes would call tuple_next() after tuple_seek() and sometimes would not. 2) Move the return value of the iterator outside of iteration state. The advantage of "binding" the out parameters of the iterator to iterator state is that you bind once, and don't need to supply out parameters into every call to tuple_next() function. It also makes it easy to add extra out parameters for bind in the future (field data type, flags, etc). This makes "binding" technique popular in database driver APIs. Binding makes API more stable, which is also important in drivers. In this case, however, binding adds for extra lines of code and (possibly) few extra instructions. Plus, since this is an internal API which we can change any day, its stability is not as important. So it seems that for now we're better of with an API which is a bit more concise/efficient, and can switch to using binding later, if needed.
-
- Jun 14, 2013
-
-
Roman Tsisyk authored
-
- Jun 11, 2013
-
-
Dmitry E. Oboukhov authored
-
Roman Tsisyk authored
-
http://travis-ci.org/Roman Tsisyk authored
-
Konstantin Osipov authored
-
Konstantin Osipov authored
-
Roman Tsisyk authored
-
Roman Tsisyk authored
-
Roman Tsisyk authored
-
- Jun 10, 2013
-
-
Dmitry Simonenko authored
-
Dmitry Simonenko authored
-
- Jun 08, 2013
-
-
Dmitry E. Oboukhov authored
-
Konstantin Osipov authored
Conflicts: .gitignore include/pickle.h test/unit/CMakeLists.txt third_party/luajit
-
Konstantin Osipov authored
-
Konstantin Osipov authored
Don't load corrupted tuples.
-
- Jun 07, 2013
-
-
Dmitry Simonenko authored
-
Dmitry Simonenko authored
-
Dmitry Simonenko authored
-
Dmitry Simonenko authored
g++ (not gcc) works correctly when dealing with extern __inline and __extern_inline constructions, thus this hack is not necessary now.
-
- Jun 06, 2013
-
-
Dmitry Simonenko authored
-
Dmitry Simonenko authored
-
Konstantin Osipov authored
-
Konstantin Osipov authored
The patch which removes the CPack-generated spec and adds a proper spec for client, server and library was done by Dmitry Simonenko. Hand-port the patch to the master, since it's gone too far away from the origin and merging it ends up in a mess.
-
Roman Tsisyk authored
-
Roman Tsisyk authored
-
Roman Tsisyk authored
-
Konstantin Osipov authored
-
Konstantin Osipov authored
Minor tweaks of the code as per a more thorough review of the 10k patch which introduces C++ instead of Objective C. No bugs found or fixed, only style changes.
-
- Jun 05, 2013
-
-
Roman Tsisyk authored
-
Roman Tsisyk authored
-
Roman Tsisyk authored
-
Roman Tsisyk authored
-
- Jun 04, 2013
-
-
Konstantin Osipov authored
-
Konstantin Osipov authored
-
Konstantin Osipov authored
-
Konstantin Osipov authored
Conflicts: src/CMakeLists.txt third_party/luajit
-
Konstantin Osipov authored
-