- Feb 20, 2013
-
-
Roman Tsisyk authored
-
Roman Tsisyk authored
-
Konstantin Osipov authored
Conflicts: src/box/space.m
-
- Feb 18, 2013
-
-
Konstantin Osipov authored
-
Konstantin Osipov authored
-
- Feb 15, 2013
-
-
Konstantin Osipov authored
Use a single argument for mh_hash() and mh_eq().
-
Konstantin Osipov authored
In search for a bug in the hash index, cleanup its code: replace a redundant mh_replace with improved mh_put.
-
- Feb 14, 2013
-
-
Konstantin Osipov authored
-
Konstantin Osipov authored
-
Konstantin Osipov authored
-
Konstantin Osipov authored
-
- Feb 13, 2013
-
-
Roman Tsisyk authored
-
Konstantin Osipov authored
Conflicts: test/big/tarantool.cfg
-
Konstantin Osipov authored
-
- Feb 12, 2013
-
-
Konstantin Osipov authored
-
Konstantin Osipov authored
-
Konstantin Osipov authored
-
Konstantin Osipov authored
Conflicts: test/box/lua.result
-
Konstantin Osipov authored
-
Dmitry E. Oboukhov authored
-
Roman V. Nikolaev authored
-
- Feb 11, 2013
-
-
Konstantin Osipov authored
Conflicts: src/box/box_lua.m src/lua/init.m test/box/lua.result
-
Konstantin Osipov authored
-
Konstantin Osipov authored
Preparation for addition of 't' format specifier in pack/unpack: move these functions to box_lua.m.
-
Konstantin Osipov authored
-
- Feb 09, 2013
-
-
Konstantin Osipov authored
-
Konstantin Osipov authored
-
Konstantin Osipov authored
There were two cases when the new async I/O worked incorrectly. The problems only revealed themselves under specific concurrency circumstances. In one case, the client would get a mix of pieces of different packets (responses). The reason for this was that, when selecting which output buffer to write to the client, the flushing algorithm used to select whichever of two buffers, associated with a session, had data to flush. This worked OK as long as the entire contents of the buffer could be written in one writev() call. But when writev() would only be able to write a part of the buffer, the next writev() could already be done with another buffer, thus producing a mix of *partial* writes from both buffers. Between two buffers used for a session, one is always newer than the other (contains responses to requests which came in earlier). So basically the bug was that we would select a newer buffer for flushing, while there were still unhandled requests in the older buffer. One approach to a fix would be to, once started, keep writing the newer buffer until there is nothing to write in it. The actual fix chooses a simpler approach: to never begin with a newer buffer, until the older one is completely written. Thus, there is never reordering of output between two output buffers, only within a single buffer. The second bug was caused by wrong calculation of write offset for iproto header. When iproto_header would fall on the border of two iov vectors, obuf_book would rightfully discard the tail of the first iov vector, and "position" the header at the beginning of the second vector. However, the savepoint used to memcpy() the output would still point at the first vector, and the header would be (partially) written at the end of the first vector, not at the beginning of of the second. This led to a) write beyond allocated memory b) loss of a piece of a packet (effect seen by the client). The fix is to correctly record the write position when making a booking. obuf_book signature is changed respectively. No test cases since the bug is only spottable under certain concurrency circumstances (a single CPU box, client/server I/O). @todo: add unit tests.
-
- Feb 08, 2013
-
-
Roman Tsisyk authored
Conflicts: src/box/box.lua test/big/tarantool.cfg
-
Roman Tsisyk authored
-
Konstantin Osipov authored
Conflicts: doc/user/stored-procedures.xml
-
Konstantin Osipov authored
-
Konstantin Osipov authored
Conflicts: test/box/lua.result
-
Konstantin Osipov authored
-
Konstantin Osipov authored
-
Roman Tsisyk authored
Conflicts: src/box/index.m
-
Dmitry Simonenko authored
Conflicts: test/box/lua.result
-
Roman Tsisyk authored
-
Roman Tsisyk authored
-
Roman Tsisyk authored
-