box: change box_issue_promote(demote) return type

Make box_issue_promote and box_issue_demote return a return code.
For now it's always 0, but soon they will return errors.

Part-of #5295

NO_DOC=refactoring
NO_TEST=refactoring
NO_CHANGELOG=refactoring