sql: refactor sql_expr_coll and sql_binary_compare_coll_seq
Lets make sql_expr_coll() return error code. It is needed since we are going to use this function to detect operands of concatenation with incompatible collations. Hence, struct coll* has been moved to output parameters. For the same reason lets make sql_binary_compare_coll_seq() return error code instead of struct coll*. The latter is really required only in one out of six usages, so lets remove it at all. Needed for #3947
Showing
- src/box/sql/expr.c 51 additions, 38 deletionssrc/box/sql/expr.c
- src/box/sql/select.c 25 additions, 12 deletionssrc/box/sql/select.c
- src/box/sql/sqlInt.h 11 additions, 8 deletionssrc/box/sql/sqlInt.h
- src/box/sql/where.c 36 additions, 29 deletionssrc/box/sql/where.c
- src/box/sql/whereexpr.c 20 additions, 10 deletionssrc/box/sql/whereexpr.c
Loading
Please register or sign in to comment