Skip to content
Snippets Groups Projects
Unverified Commit ca40aa3c authored by HustonMmmavr's avatar HustonMmmavr Committed by Alexander Turenko
Browse files

fio: fix race condition in mktree

Despite the lack of documentation, fio.mktree() was designed to work
similar to mkdir -p: it creates the directory along with it's parents
and doesn't complain about existing ones.

But this function was subject to a race if two different processes were
trying to create the same directory at the same time. It was caused by
the fact that directory existence check and its creation aren't atomic.

This patch fixes the race by impoving error handling: it's not an error
if directory exists, even if it was created by someone else and mktree
failed.

Related to https://github.com/tarantool/doc/issues/1063
Closes #4660

(cherry picked from commit 21ae2899)
parent 51130eb8
No related branches found
No related tags found
No related merge requests found
......@@ -364,7 +364,11 @@ fio.mktree = function(path, mode)
local stat = fio.stat(current_dir)
if stat == nil then
local st, err = fio.mkdir(current_dir, mode)
if err ~= nil then
-- fio.stat() and fio.mkdir() above are separate calls
-- and a file system may be changed between them. So
-- if the error here is due to an existing directory,
-- the function should not report an error.
if err ~= nil and not fio.path.is_dir(current_dir) then
return false, string.format("Error creating directory %s: %s",
current_dir, tostring(err))
end
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment