Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
T
tarantool
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
core
tarantool
Commits
919b342b
Commit
919b342b
authored
11 years ago
by
Eugine Blikh
Browse files
Options
Downloads
Patches
Plain Diff
1. Make `=` to be optional in `setopt delimiter 'string'`
2. Make support of multiline delimiters
parent
830f3e47
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
client/tarantool/tc_buf.c
+20
-0
20 additions, 0 deletions
client/tarantool/tc_buf.c
client/tarantool/tc_buf.h
+4
-1
4 additions, 1 deletion
client/tarantool/tc_buf.h
client/tarantool/tc_cli.c
+36
-23
36 additions, 23 deletions
client/tarantool/tc_cli.c
with
60 additions
and
24 deletions
client/tarantool/tc_buf.c
+
20
−
0
View file @
919b342b
...
...
@@ -112,6 +112,26 @@ int tc_buf_str_append(struct tc_buf *buf, char *str, size_t len) {
return
0
;
}
/* Remove last num symbols from STR */
size_t
tc_buf_str_delete
(
struct
tc_buf
*
buf
,
size_t
len
)
{
size_t
ret
=
tc_buf_delete
(
buf
,
len
+
1
);
/* Remove '\0' + len */
if
(
tc_buf_append
(
buf
,
(
void
*
)
"
\0
"
,
1
))
return
0
;
return
ret
;
}
/*
* Make admin command from multiline command
* and delete delimiter (last num bytes)
*/
void
tc_buf_cmdfy
(
struct
tc_buf
*
buf
,
size_t
num
)
{
tc_buf_delete
(
buf
,
num
);
buf
->
data
[
buf
->
size
]
=
'\0'
;
for
(
int
i
=
0
;
i
<
buf
->
used
;
++
i
)
if
(
buf
->
data
[
i
]
==
'\n'
)
buf
->
data
[
i
]
=
' '
;
}
/* Remove trailing ws from STR */
int
tc_buf_str_stripws
(
struct
tc_buf
*
buf
)
{
if
(
buf
->
data
)
{
...
...
This diff is collapsed.
Click to expand it.
client/tarantool/tc_buf.h
+
4
−
1
View file @
919b342b
...
...
@@ -40,12 +40,15 @@ struct tc_buf {
int
tc_buf
(
struct
tc_buf
*
buf
);
void
*
tc_buf_realloc
(
void
*
data
,
size_t
size
);
int
tc_buf_append
(
struct
tc_buf
*
buf
,
void
*
str
,
size_t
len
);
size_t
tc_buf_delete
(
struct
tc_buf
*
buf
,
size_t
len
);
size_t
tc_buf_delete
(
struct
tc_buf
*
buf
,
size_t
num
);
int
tc_buf_isempty
(
struct
tc_buf
*
buf
);
void
tc_buf_clear
(
struct
tc_buf
*
buf
);
void
tc_buf_free
(
struct
tc_buf
*
buf
);
int
tc_buf_str
(
struct
tc_buf
*
buf
);
int
tc_buf_str_append
(
struct
tc_buf
*
buf
,
char
*
str
,
size_t
len
);
size_t
tc_buf_str_delete
(
struct
tc_buf
*
buf
,
size_t
num
);
int
tc_buf_str_stripws
(
struct
tc_buf
*
buf
);
int
tc_buf_str_isempty
(
struct
tc_buf
*
buf
);
void
tc_buf_cmdfy
(
struct
tc_buf
*
buf
,
size_t
num
);
This diff is collapsed.
Click to expand it.
client/tarantool/tc_cli.c
+
36
−
23
View file @
919b342b
...
...
@@ -117,6 +117,9 @@ static struct tnt_lex_keyword tc_lex_keywords[] =
{
"s"
,
1
,
TC_SETOPT
},
{
"setopt"
,
6
,
TC_SETOPT
},
{
"delim"
,
5
,
TC_SETOPT_DELIM
},
{
"delimi"
,
6
,
TC_SETOPT_DELIM
},
{
"delimit"
,
7
,
TC_SETOPT_DELIM
},
{
"delimite"
,
8
,
TC_SETOPT_DELIM
},
{
"delimiter"
,
9
,
TC_SETOPT_DELIM
},
{
NULL
,
0
,
TNT_TK_NONE
}
};
...
...
@@ -137,8 +140,8 @@ tc_cmd_usage(void)
" - tee 'path'
\n
"
" - notee
\n
"
" - loadfile 'path'
\n
"
" - setopt key
=
val
\n
"
" - (possible pairs: delim
=
\
'
str
\
'
)
\n
"
" - setopt key
val
\n
"
" - (possible pairs: delim
iter
'str
ing
')
\n
"
"...
\n
"
;
tc_printf
(
"%s"
,
usage
);
}
...
...
@@ -232,6 +235,17 @@ tc_cmd_loadfile(char *path, int *reconnect)
return
rc
;
}
static
void
replace_newline
(
char
*
cmd
)
{
int
len
=
strlen
(
cmd
);
int
offset
=
0
;
for
(
int
i
=
0
;
i
<
len
-
1
;
++
i
)
if
(
cmd
[
i
]
==
'\\'
&&
cmd
[
i
+
1
]
==
'n'
)
cmd
[
i
-
offset
++
]
=
'\n'
;
else
if
(
offset
!=
0
)
cmd
[
i
-
offset
]
=
cmd
[
i
];
cmd
[
len
-
offset
]
=
'\0'
;
}
static
enum
tc_cli_cmd_ret
tc_cmd_try
(
char
*
cmd
,
size_t
size
,
int
*
reconnect
)
{
...
...
@@ -269,8 +283,9 @@ tc_cmd_try(char *cmd, size_t size, int *reconnect)
case
TC_SETOPT
:
switch
(
tnt_lex
(
&
lex
,
&
tk
))
{
case
TC_SETOPT_DELIM
:
if
(
tnt_lex
(
&
lex
,
&
tk
)
==
'='
&&
tnt_lex
(
&
lex
,
&
tk
)
==
TNT_TK_STRING
)
{
if
(
tnt_lex
(
&
lex
,
&
tk
)
!=
'='
)
tnt_lex_push
(
&
lex
,
tk
);
if
(
tnt_lex
(
&
lex
,
&
tk
)
==
TNT_TK_STRING
)
{
if
(
!
TNT_TK_S
(
tk
)
->
size
)
{
tc
.
opt
.
delim
=
""
;
tc
.
opt
.
delim_len
=
0
;
...
...
@@ -283,11 +298,12 @@ tc_cmd_try(char *cmd, size_t size, int *reconnect)
strncpy
(
temp
,
(
const
char
*
)
TNT_TK_S
(
tk
)
->
data
,
TNT_TK_S
(
tk
)
->
size
+
1
);
replace_newline
(
temp
);
tc
.
opt
.
delim
=
temp
;
tc
.
opt
.
delim_len
=
strlen
(
tc
.
opt
.
delim
);
}
else
{
tc_printf
(
"---
\n
"
);
tc_printf
(
" - Expected
delim=
'string'
\n
"
);
tc_printf
(
" - Expected
`setopt delimiter
'string'
`
\n
"
);
tc_printf
(
"---
\n
"
);
}
break
;
...
...
@@ -402,7 +418,6 @@ static char* tc_cli_readline_pipe() {
static
int
check_delim
(
char
*
str
,
size_t
len
,
size_t
sep_len
)
{
const
char
*
sep
=
tc
.
opt
.
delim
;
len
=
strip_end_ws
(
str
);
if
(
sep_len
==
0
)
return
1
;
if
(
len
<
sep_len
)
...
...
@@ -411,8 +426,6 @@ static int check_delim(char* str, size_t len, size_t sep_len) {
for
(
i
=
len
;
sep_len
>
0
;
--
sep_len
,
--
i
)
if
(
str
[
i
-
1
]
!=
sep
[
sep_len
-
1
])
return
0
;
str
[
i
]
=
'\0'
;
len
=
strip_end_ws
(
str
);
return
1
;
}
...
...
@@ -442,37 +455,37 @@ int tc_cli(void)
if
(
isatty
(
STDIN_FILENO
))
{
snprintf
(
prompt_delim
,
sizeof
(
prompt_delim
),
"%*s> "
,
prompt_len
,
"-"
);
part_cmd
=
readline
(
!
tc_buf_str_isempty
(
&
cmd
)
?
prompt_delim
:
prompt
);
part_cmd
=
readline
(
!
tc_buf_str_isempty
(
&
cmd
)
?
prompt_delim
:
prompt
);
}
else
{
clearerr
(
stdin
);
part_cmd
=
tc_cli_readline_pipe
();
}
if
(
!
part_cmd
)
break
;
size_t
part_cmd_len
=
strlen
(
part_cmd
);
int
delim_exists
=
check_delim
(
part_cmd
,
part_cmd_len
,
tc
.
opt
.
delim_len
);
if
(
tc_buf_str_append
(
&
cmd
,
part_cmd
,
strlen
(
part_cmd
)))
tc_error
(
TC_REALLOCATION_ERROR
,
cmd
.
size
);
int
delim_exists
=
check_delim
(
cmd
.
data
,
cmd
.
used
-
1
,
tc
.
opt
.
delim_len
);
if
(
tc_buf_str_append
(
&
cmd
,
"
\n
"
,
1
))
/* Append '\n' to the STR */
tc_error
(
TC_REALLOCATION_ERROR
,
cmd
.
size
);
free
(
part_cmd
);
if
(
!
delim_exists
&&
!
feof
(
stdin
))
{
if
(
tc_buf_str_append
(
&
cmd
,
" "
,
1
))
tc_error
(
TC_REALLOCATION_ERROR
,
cmd
.
size
);
if
(
!
delim_exists
&&
!
feof
(
stdin
))
/* If still without delimiter and not EOF */
continue
;
}
tc_buf_str_stripws
(
&
cmd
);
tc_buf_str_delete
(
&
cmd
,
1
);
/* Delete last appended '\n' */
if
(
isatty
(
STDIN_FILENO
))
/* Enable history on readline use only */
add_history
(
cmd
.
data
);
tc_buf_cmdfy
(
&
cmd
,
tc
.
opt
.
delim_len
);
/* Create admin cmd from STR */
if
(
delim_exists
&&
tc_buf_str_isempty
(
&
cmd
))
goto
next
;
goto
next
;
/* If empty - don't send to server, it crashes */
tc_print_cmd2tee
(
cmd
.
used
!=
1
?
prompt_delim
:
prompt
,
cmd
.
data
,
cmd
.
used
-
1
);
enum
tc_cli_cmd_ret
ret
=
tc_cli_cmd
(
cmd
.
data
,
cmd
.
used
-
1
);
if
(
isatty
(
STDIN_FILENO
))
add_history
(
cmd
.
data
);
next:
tc_buf_clear
(
&
cmd
);
if
(
ret
==
TC_CLI_EXIT
||
feof
(
stdin
))
{
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment