sql: make FOR EACH ROW clause mandatory in trigger definition
Before this patch, it was possible to create a trigger without FOR EACH ROW clause, for example: CREATE TRIGGER trg AFTER DELETE ON tbl BEGIN ; END; In ANSI SQL, if trigger-timing-clause is not specified, FOR EACH STATEMENT is used. Tarantool, however, did not support FOR EACH STATEMENT and assumed FOR EACH ROW. This could break future applications, once FOR EACH STATEMENT is added. Thus, make FOR EACH ROW clause mandatory. Update tests. No docs ticket since there is no docs for this feature yet :/ - will document the fixed behaviour right away.
Showing
- src/box/sql/parse.y 5 additions, 1 deletionsrc/box/sql/parse.y
- test/sql-tap/alter.test.lua 6 additions, 6 deletionstest/sql-tap/alter.test.lua
- test/sql-tap/autoinc.test.lua 8 additions, 8 deletionstest/sql-tap/autoinc.test.lua
- test/sql-tap/fkey2.test.lua 7 additions, 2 deletionstest/sql-tap/fkey2.test.lua
- test/sql-tap/fkey4.test.lua 3 additions, 3 deletionstest/sql-tap/fkey4.test.lua
- test/sql-tap/gh-2931-savepoints.test.lua 1 addition, 0 deletionstest/sql-tap/gh-2931-savepoints.test.lua
- test/sql-tap/gh2127-indentifier-max-length.test.lua 2 additions, 1 deletiontest/sql-tap/gh2127-indentifier-max-length.test.lua
- test/sql-tap/gh2964-abort.test.lua 1 addition, 0 deletionstest/sql-tap/gh2964-abort.test.lua
- test/sql-tap/identifier-characters.test.lua 1 addition, 0 deletionstest/sql-tap/identifier-characters.test.lua
- test/sql-tap/identifier_case.test.lua 1 addition, 1 deletiontest/sql-tap/identifier_case.test.lua
- test/sql-tap/insert3.test.lua 8 additions, 5 deletionstest/sql-tap/insert3.test.lua
- test/sql-tap/sql-errors.test.lua 1 addition, 1 deletiontest/sql-tap/sql-errors.test.lua
- test/sql-tap/tkt-31338dca7e.test.lua 1 addition, 1 deletiontest/sql-tap/tkt-31338dca7e.test.lua
- test/sql-tap/tkt-4ef7e3cfca.test.lua 3 additions, 3 deletionstest/sql-tap/tkt-4ef7e3cfca.test.lua
- test/sql-tap/tkt-7bbfb7d442.test.lua 2 additions, 1 deletiontest/sql-tap/tkt-7bbfb7d442.test.lua
- test/sql-tap/tkt2767.test.lua 6 additions, 3 deletionstest/sql-tap/tkt2767.test.lua
- test/sql-tap/tkt2832.test.lua 2 additions, 2 deletionstest/sql-tap/tkt2832.test.lua
- test/sql-tap/tkt3201.test.lua 8 additions, 4 deletionstest/sql-tap/tkt3201.test.lua
- test/sql-tap/tkt3298.test.lua 2 additions, 0 deletionstest/sql-tap/tkt3298.test.lua
- test/sql-tap/tkt3554.test.lua 1 addition, 1 deletiontest/sql-tap/tkt3554.test.lua
Loading
Please register or sign in to comment