space: drop space with its triggers set with old API
Attaching triggers to space id instead of space object is a significant pitfall. The users who haven't discovered new triggers may not expect the triggers of a dropped space will be fired by a new one. So let's drop triggers that were set with old API along with the space. All the tests, changed because of described above breaking change, are restored. Closes #9223 NO_DOC=later
Showing
- changelogs/unreleased/gh-8657-move-triggers-to-trigger-registry.md 2 additions, 6 deletions...s/unreleased/gh-8657-move-triggers-to-trigger-registry.md
- src/box/alter.cc 1 addition, 0 deletionssrc/box/alter.cc
- src/box/lua/space.cc 5 additions, 4 deletionssrc/box/lua/space.cc
- src/box/lua/trigger.c 14 additions, 8 deletionssrc/box/lua/trigger.c
- src/box/lua/trigger.h 10 additions, 1 deletionsrc/box/lua/trigger.h
- src/box/space.c 13 additions, 0 deletionssrc/box/space.c
- src/box/space.h 6 additions, 0 deletionssrc/box/space.h
- test/box-luatest/gh_4264_recursive_trigger_test.lua 0 additions, 2 deletionstest/box-luatest/gh_4264_recursive_trigger_test.lua
- test/box-luatest/gh_8027_txn_handle_abort_in_trigger_test.lua 5 additions, 9 deletions.../box-luatest/gh_8027_txn_handle_abort_in_trigger_test.lua
- test/box/before_replace.result 2 additions, 11 deletionstest/box/before_replace.result
- test/box/before_replace.test.lua 2 additions, 5 deletionstest/box/before_replace.test.lua
- test/box/on_replace.result 5 additions, 29 deletionstest/box/on_replace.result
- test/box/on_replace.test.lua 5 additions, 13 deletionstest/box/on_replace.test.lua
- test/box/push.result 1 addition, 7 deletionstest/box/push.result
- test/box/push.test.lua 1 addition, 3 deletionstest/box/push.test.lua
- test/engine-luatest/space_triggers_test.lua 98 additions, 0 deletionstest/engine-luatest/space_triggers_test.lua
- test/engine/savepoint.result 0 additions, 9 deletionstest/engine/savepoint.result
- test/engine/savepoint.test.lua 0 additions, 3 deletionstest/engine/savepoint.test.lua
- test/sql/iproto.result 0 additions, 3 deletionstest/sql/iproto.result
- test/sql/iproto.test.lua 0 additions, 1 deletiontest/sql/iproto.test.lua
Loading
Please register or sign in to comment