upgrade: fix generated sequence upgrade from 2.1
The bug was in an attempt to update a record in _space_sequence in-place, to add field path and number. This was not properly supported by the system space's trigger, and was banned in the previous patch of this series. But delete + tuple update + insert work fine. The patch uses them. To test it the old disabled and heavily outdated xlog/upgrade.test.lua was replaced with a smaller analogue, which is supposed to be created separately for each upgrade bug. According to the new policy of creating test files. The patch tries to make it easy to add new upgrade tests and snapshots. A new test should consist of fill.lua script to populate spaces, snapshot, needed xlogs, and a .test.lua file. Fill script and binaries should be in the same folder as test file name, which is located in version folder. Like this: xlog/ | + <test_name>.test.lua | +- upgrade/ | +- <version>/ | | | +-<test_name>/ | | | +- fill.lua | +- *.snap | +- *.xlog Version is supposed to say explicitly what a version files in there have. Closes #4771
Showing
- src/box/lua/upgrade.lua 6 additions, 1 deletionsrc/box/lua/upgrade.lua
- test/xlog/gh-4771-upgrade.result 78 additions, 0 deletionstest/xlog/gh-4771-upgrade.result
- test/xlog/gh-4771-upgrade.test.lua 24 additions, 0 deletionstest/xlog/gh-4771-upgrade.test.lua
- test/xlog/suite.cfg 0 additions, 5 deletionstest/xlog/suite.cfg
- test/xlog/suite.ini 1 addition, 2 deletionstest/xlog/suite.ini
- test/xlog/upgrade.result 0 additions, 265 deletionstest/xlog/upgrade.result
- test/xlog/upgrade.test.lua 0 additions, 46 deletionstest/xlog/upgrade.test.lua
- test/xlog/upgrade/2.1.3/gh-4771-upgrade-sequence/00000000000000000014.snap 0 additions, 0 deletions.../2.1.3/gh-4771-upgrade-sequence/00000000000000000014.snap
- test/xlog/upgrade/2.1.3/gh-4771-upgrade-sequence/fill.lua 14 additions, 0 deletionstest/xlog/upgrade/2.1.3/gh-4771-upgrade-sequence/fill.lua
- test/xlog/upgrade/how_to_add_new_test.md 36 additions, 0 deletionstest/xlog/upgrade/how_to_add_new_test.md
Loading
Please register or sign in to comment