Skip to content
Snippets Groups Projects
Commit 63dd2f33 authored by Vladimir Davydov's avatar Vladimir Davydov Committed by Vladimir Davydov
Browse files

sql: drop extern_alloc flag of sql_expr_delete

It's always false.

I don't understand why it was added in the first place. Initially, it
was introduced by commit b9c9792d ("sql: move default col values to
Tarantool's core"). The flag was set to true only in Tarantool core for
some reason. Then there was commit 7c6c572c ("sql: Fix DEFAULTs AST
memory leak on alter") that claimed there was a memory leak because the
flag was set it to true and switched it to false in all places except
one: when a space_def was destroyed it was still set to true. I dropped
usage of space_expr_dup and switched the flag to false in the previous
commit, and everything seems to work just fine now.

NO_DOC=refactoring
NO_TEST=refactoring
NO_CHANGELOG=refactoring
parent 3dcc3fd6
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment