sql: drop extern_alloc flag of sql_expr_delete
It's always false. I don't understand why it was added in the first place. Initially, it was introduced by commit b9c9792d ("sql: move default col values to Tarantool's core"). The flag was set to true only in Tarantool core for some reason. Then there was commit 7c6c572c ("sql: Fix DEFAULTs AST memory leak on alter") that claimed there was a memory leak because the flag was set it to true and switched it to false in all places except one: when a space_def was destroyed it was still set to true. I dropped usage of space_expr_dup and switched the flag to false in the previous commit, and everything seems to work just fine now. NO_DOC=refactoring NO_TEST=refactoring NO_CHANGELOG=refactoring
Showing
- src/box/ck_constraint.c 2 additions, 2 deletionssrc/box/ck_constraint.c
- src/box/sql.c 1 addition, 1 deletionsrc/box/sql.c
- src/box/sql.h 1 addition, 2 deletionssrc/box/sql.h
- src/box/sql/build.c 5 additions, 5 deletionssrc/box/sql/build.c
- src/box/sql/delete.c 1 addition, 1 deletionsrc/box/sql/delete.c
- src/box/sql/expr.c 13 additions, 14 deletionssrc/box/sql/expr.c
- src/box/sql/fk_constraint.c 3 additions, 3 deletionssrc/box/sql/fk_constraint.c
- src/box/sql/parse.y 11 additions, 11 deletionssrc/box/sql/parse.y
- src/box/sql/prepare.c 1 addition, 1 deletionsrc/box/sql/prepare.c
- src/box/sql/resolve.c 6 additions, 6 deletionssrc/box/sql/resolve.c
- src/box/sql/select.c 9 additions, 9 deletionssrc/box/sql/select.c
- src/box/sql/trigger.c 6 additions, 6 deletionssrc/box/sql/trigger.c
- src/box/sql/update.c 1 addition, 1 deletionsrc/box/sql/update.c
- src/box/sql/wherecode.c 1 addition, 1 deletionsrc/box/sql/wherecode.c
- src/box/sql/whereexpr.c 3 additions, 3 deletionssrc/box/sql/whereexpr.c
Loading
Please register or sign in to comment